remove more memsets

PATCH New Patrick McHardy 1 participant 1 message Jun 29, 2003

Subsystems (2)

Networking netfilter

lore

Share & tools

lore

Patrick McHardy

author

2003-06-29 19:43 UTC #0 lore raw

PATCH 1/1 remove more memsets

Hi Harald,
these patches (2.4 and 2.5) removes the remaining unnecessary memsets. Best regards,
Patrick

===== net/ipv4/netfilter/ip_conntrack_amanda.c 1.2 vs edited =====

net/ipv4/netfilter/ip_conntrack_amanda.c +0 -1

@@ -205,7 +205,6 @@
 {
 	int ret;
 
-	memset(&amanda_helper, 0, sizeof(struct ip_conntrack_helper));
 	amanda_helper.tuple.src.u.udp.port = htons(10080);
 	amanda_helper.tuple.dst.protonum = IPPROTO_UDP;
 	amanda_helper.mask.src.u.udp.port = 0xFFFF;

===== net/ipv4/netfilter/ip_conntrack_tftp.c 1.1 vs edited =====

net/ipv4/netfilter/ip_conntrack_tftp.c +0 -2

@@ -94,8 +94,6 @@
 
 	for (i = 0 ; (i < MAX_PORTS) && ports[i] ; i++) {
 		/* Create helper structure */
-		memset(&tftp[i], 0, sizeof(struct ip_conntrack_helper));
-
 		tftp[i].tuple.dst.protonum = IPPROTO_UDP;
 		tftp[i].tuple.src.u.udp.port = htons(ports[i]);
 		tftp[i].mask.dst.protonum = 0xFFFF;

===== net/ipv4/netfilter/ip_nat_amanda.c 1.2 vs edited =====

net/ipv4/netfilter/ip_nat_amanda.c +0 -2

@@ -195,8 +195,6 @@
 	struct ip_nat_helper *hlpr;
 
 	hlpr = &ip_nat_amanda_helper;
-	memset(hlpr, 0, sizeof(struct ip_nat_helper));
-
 	hlpr->tuple.dst.protonum = IPPROTO_UDP;
 	hlpr->tuple.src.u.udp.port = htons(10080);
 	hlpr->mask.src.u.udp.port = 0xFFFF;

===== net/ipv4/netfilter/ip_nat_tftp.c 1.1 vs edited =====

net/ipv4/netfilter/ip_nat_tftp.c +0 -2

@@ -160,8 +160,6 @@
 		ports[0] = TFTP_PORT;
 
 	for (i = 0 ; (i < MAX_PORTS) && ports[i] ; i++) {
-		memset(&tftp[i], 0, sizeof(struct ip_nat_helper));
-
 		tftp[i].tuple.dst.protonum = IPPROTO_UDP;
 		tftp[i].tuple.src.u.udp.port = htons(ports[i]);
 		tftp[i].mask.dst.protonum = 0xFFFF;

===== net/ipv4/netfilter/ip_conntrack_tftp.c 1.3 vs edited =====

net/ipv4/netfilter/ip_conntrack_tftp.c +0 -2

@@ -97,8 +97,6 @@
 
 	for (i = 0 ; (i < MAX_PORTS) && ports[i] ; i++) {
 		/* Create helper structure */
-		memset(&tftp[i], 0, sizeof(struct ip_conntrack_helper));
-
 		tftp[i].tuple.dst.protonum = IPPROTO_UDP;
 		tftp[i].tuple.src.u.udp.port = htons(ports[i]);
 		tftp[i].mask.dst.protonum = 0xFFFF;

===== net/ipv4/netfilter/ip_nat_amanda.c 1.3 vs edited =====

net/ipv4/netfilter/ip_nat_amanda.c +0 -2

@@ -195,8 +195,6 @@
 	struct ip_nat_helper *hlpr;
 
 	hlpr = &ip_nat_amanda_helper;
-	memset(hlpr, 0, sizeof(struct ip_nat_helper));
-
 	hlpr->tuple.dst.protonum = IPPROTO_UDP;
 	hlpr->tuple.src.u.udp.port = htons(10080);
 	hlpr->mask.src.u.udp.port = 0xFFFF;

===== net/ipv4/netfilter/ip_nat_tftp.c 1.3 vs edited =====

net/ipv4/netfilter/ip_nat_tftp.c +0 -2

@@ -164,8 +164,6 @@
 		ports[0] = TFTP_PORT;
 
 	for (i = 0 ; (i < MAX_PORTS) && ports[i] ; i++) {
-		memset(&tftp[i], 0, sizeof(struct ip_nat_helper));
-
 		tftp[i].tuple.dst.protonum = IPPROTO_UDP;
 		tftp[i].tuple.src.u.udp.port = htons(ports[i]);
 		tftp[i].mask.dst.protonum = 0xFFFF;