Skip to contentSkip to conversation

What to expect in dosemu-1.2?

DISCUSSION Stas Sergeev 1 participant 1 message Jul 23, 2003

lore
Share & tools
lore

Stas Sergeev

author
#0 lore raw

Hello.

Quoted 3 lines · Justin Zygmont
Quoted 1 line

- Client-server approach for port I/O, which allows

I wonder if this is why there is a lock file problem with a modem now?

No, this has nothing to do with locks. However there is a bug in a serial code which, but only in case open() fails, prints a misleading message that the device is already locked, and leaves a stale lock file.
The fix is attached. This may not be the problem you see however. I have no idea what you see actually, as you have provided no details. But as I already have a fix to something similar - try it and maybe it will help.

base/serial/ser_init.c +8 -0
@@ -245,6 +245,14 @@
   }
   
   com[num].fd = RPT_SYSCALL(open(com[num].dev, O_RDWR | O_NONBLOCK));
+  if (com[num].fd < 0) {
+    error("SERIAL: Unable to open device %s: %s\n",
+      com[num].dev, strerror(errno));
+    if (tty_lock(com[num].dev, 0) >= 0)   		/* Unlock port */
+      com[num].dev_locked = FALSE;
+    com[num].fd = -2; // disable permanently
+    return -1;
+  }
   RPT_SYSCALL(tcgetattr(com[num].fd, &com[num].oldset));
   return (com[num].fd);
 }