Skip to contentSkip to conversation

i2c-isa functionality

PATCH New Mark D. Studebaker 2 participants 2 messages May 19, 2005 I2C subsystem host drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c-isa functionality

Greg, please apply. thanks.
mds

The "functionality" return was incorrectly removed for i2c-isa.c when porting to 2.5. A driver that does nothing must return a 0 or else i2c-core assumes 0xffffffff (all functionality).
-------------- next part --------------

drivers/i2c/busses/i2c-isa.c +9 -0
@@ -30,10 +30,13 @@
 #include <linux/errno.h>
 #include <linux/i2c.h>
 
+static u32 isa_func(struct i2c_adapter *adapter);
+
 /* This is the actual algorithm we define */
 static struct i2c_algorithm isa_algorithm = {
 	.name		= "ISA bus algorithm",
 	.id		= I2C_ALGO_ISA,
+	.functionality	= isa_func,
 };
 
 /* There can only be one... */
@@ -44,6 +47,12 @@
 	.algo		= &isa_algorithm,
 	.name		= "ISA main adapter",
 };
+
+/* We can't do a thing... */
+static u32 isa_func(struct i2c_adapter *adapter)
+{
+	return 0;
+}
 
 static int __init i2c_isa_init(void)
 {
Applied
#1 lore raw

PATCH 1/1 i2c-isa functionality

Quoted 9 lines · Mark D. Studebaker

Greg, please apply. thanks.
mds

The "functionality" return was incorrectly removed for i2c-isa.c when porting to 2.5.
A driver that does nothing must return a 0 or else i2c-core assumes 0xffffffff (all functionality).

Applied, thanks.

Next time try to CC: me, I almost missed this one :)

greg k-h