Skip to contentSkip to conversation

ethtool_features?

DISCUSSION Jeff Garzik 2 participants 2 messages Aug 27, 2003 – Aug 28, 2003

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hum. Instead of adding all these _get_foo ops to test dev->features bits, would anyone mind if I created a single _get_features() ethtool sub-ioctl?

Given the current ethtool_ops code, its implementation would in fact be completely transparent to low-level drivers. It need only be implemented in net/core/ethtool.c, without even adding a new hook.

Jeff

#1 lore raw
Quoted 3 lines · On Wed, 27 Aug 2003 18:22:35 -0400 Jeff Garzik <[email protected]> wrote:

Hum. Instead of adding all these _get_foo ops to test dev->features bits, would anyone mind if I created a single _get_features() ethtool sub-ioctl?

I'm personally OK with this _iff_ you add values local to ethtool for the various feature bits. Ie. don't export the NETIF_F_* values to userspace.