fix ifdown/ifup bug

PATCH In review Jeff Garzik 2 participants 2 messages Sep 12, 2003 – Sep 13, 2003 Networking

lore

Share & tools

lore

Jeff Garzik

author

2003-09-12 21:12 UTC #0 lore raw

PATCH 1/1 fix ifdown/ifup bug

Marcelo,

If you haven't gotten this patch from somebody else, please make sure this is applied. It fixes a bug I introduced in -pre3 when moving some helpers from tg3 to netdevice.h.

Jeff

net/core/dev.c +5 -1

diff -Nru a/net/core/dev.c b/net/core/dev.c
@@ -851,7 +851,11 @@
 	 * engine, but this requires more changes in devices. */
 
 	smp_mb__after_clear_bit(); /* Commit netif_running(). */
-	netif_poll_disable(dev);
+	while (test_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
+		/* No hurry. */
+		current->state = TASK_INTERRUPTIBLE;
+		schedule_timeout(1);
+	}
 
 	/*
 	 *	Call the device specific close. This cannot fail.

Fedor Karpelevitch

2003-09-13 06:10 UTC #1 lore raw

Quoted 6 lines · Jeff Garzik

Marcelo,
If you haven't gotten this patch from somebody else, please make sure this is applied. It fixes a bug I introduced in -pre3 when moving some helpers from tg3 to netdevice.h.

FYI it does not seem to fix this issue for me.

Fedor