Skip to contentSkip to conversation

APM suspend still broken in -test9

DISCUSSION David Brownell 4 participants 7 messages Oct 27, 2003 – Oct 29, 2003

lore
Share & tools
lore
#0 lore raw

Those are the same symptoms I saw in test7, fixed by:

http://marc.theaimsgroup.com/?l=linux-kernel&m=106606272103414&w=2

Patrick, were you going to submit your patch to resolve this? I'm thinking this kind of problem would meet Linus's test10 integration criteria.

(That's not an APM problem, it's a generic PM problem that'd show up with swsusp too. And likely even some ACPI systems.)

- Dave

#1 lore raw

Yes, that patch solves it for me, and applies cleanly to -test9. Ian

Quoted 12 lines · David Brownell

Those are the same symptoms I saw in test7, fixed by:

   http://marc.theaimsgroup.com/?l=linux-kernel&m=106606272103414&w=2

Patrick, were you going to submit your patch to resolve this? I'm thinking this kind of problem would meet Linus's test10 integration criteria.

(That's not an APM problem, it's a generic PM problem that'd show up with swsusp too. And likely even some ACPI systems.)

- Dave

#3 lore raw
In reply to David Brownell
Quoted 7 lines · David Brownell

Those are the same symptoms I saw in test7, fixed by:

   http://marc.theaimsgroup.com/?l=linux-kernel&m=106606272103414&w=2

Patrick, were you going to submit your patch to resolve this? I'm thinking this kind of problem would meet Linus's test10 integration criteria.

I should be merging early this week. Sorry about the delay, but it will get in soon.

BTW, can you help with any of the uhci-hcd suspend/resume issues? I do not know the code well enough to track it down..

Pat

#4 lore raw
Quoted 5 lines · Patrick Mochel
Quoted 2 lines · David Brownell

Those are the same symptoms I saw in test7, fixed by:

Quoted 8 lines
Quoted 5 lines

http://marc.theaimsgroup.com/?l=linux-kernel&m=106606272103414&w=2

Patrick, were you going to submit your patch to resolve this? I'm thinking this kind of problem would meet Linus's test10 integration criteria.

I should be merging early this week. Sorry about the delay, but it will get in soon.

Good -- I just wanted to make sure it didn't get lost, more folk are noticing it lately.

Quoted 1 line

BTW, can you help with any of the uhci-hcd suspend/resume issues? I do not know the code well enough to track it down..

I'm trying to avoid that; sorry! Some of them could be related to UHCI patches that are waiting for feedback/approval from Johannes.

- Dave

#5 lore raw
Quoted 14 lines · David Brownell
Quoted 4 lines · Patrick Mochel
Quoted 2 lines · David Brownell

Those are the same symptoms I saw in test7, fixed by:

Quoted 8 lines
Quoted 5 lines

http://marc.theaimsgroup.com/?l=linux-kernel&m=106606272103414&w=2

Patrick, were you going to submit your patch to resolve this? I'm thinking this kind of problem would meet Linus's test10 integration criteria.

I should be merging early this week. Sorry about the delay, but it will get in soon.

Quoted 8 lines

Good -- I just wanted to make sure it didn't get lost, more folk are noticing it lately.

Quoted 2 lines

BTW, can you help with any of the uhci-hcd suspend/resume issues? I do not know the code well enough to track it down..

I'm trying to avoid that; sorry! Some of them could be related to UHCI patches that are waiting for feedback/approval from Johannes.

Which patches do you suspect are related? It's hard for me to test anything suspend/resume related with UHCI since I don't have any systems with a UHCI controller that would be affected.

However, I can (well, I should have already...) eyeball the patches atleast.

JE

#6 lore raw
Quoted 10 lines
Quoted 5 lines
Quoted 2 lines

BTW, can you help with any of the uhci-hcd suspend/resume issues? I do not know the code well enough to track it down..

I'm trying to avoid that; sorry! Some of them could be related to UHCI patches that are waiting for feedback/approval from Johannes.

Which patches do you suspect are related? It's hard for me to test anything suspend/resume related with UHCI since I don't have any systems with a UHCI controller that would be affected.

Clearly not the "don't modify toggles in control queues" patch!

But I remember some patches related to quiescing endpoints, unlinking, shutdown, and so on.

- Dave

Quoted 5 lines

However, I can (well, I should have already...) eyeball the patches atleast.

JE

#2 lore raw
In reply to Ian Soboroff

Scratch that. I attempted to wake up the laptop yesterday after it had been sleeping for several hours, and it was locked hard. My success report was based on just a quick sleep of a minute or so.

The last -test kernel that works properly for APM suspend and resume for me is -test7.

Ian

Quoted 17 lines · Ian Soboroff

Yes, that patch solves it for me, and applies cleanly to -test9. Ian

Quoted 12 lines · David Brownell

Those are the same symptoms I saw in test7, fixed by:

   http://marc.theaimsgroup.com/?l=linux-kernel&m=106606272103414&w=2

Patrick, were you going to submit your patch to resolve this? I'm thinking this kind of problem would meet Linus's test10 integration criteria.

(That's not an APM problem, it's a generic PM problem that'd show up with swsusp too. And likely even some ACPI systems.)

- Dave