Skip to contentSkip to conversation

forcedeth: version 0.17 available

DISCUSSION Carl-Daniel Hailfinger 3 participants 5 messages Nov 16, 2003 – Nov 18, 2003

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hello all,

version 0.17 of forcedeth for Linux 2.4 and 2.6 is available at
http://www.hailfinger.org/carldani/linux/patches/forcedeth/

Fixes in this release over 0.14:
* 0.15: 08 Nov 2003: fix smp deadlock with set_multicast_list
* during open.
* 0.16: 15 Nov 2003: include file cleanup for ppc64, rx buffer
* size increased to 1628 bytes.
* 0.17: 16 Nov 2003: undo rx buffer size increase. Substract 1
* from the tx length.

Known issues:
* Oops during module removal, probably sysfs related. Could a sysfs expert please take a look at the code? Call trace is at
http://www.ussg.iu.edu/hypermail/linux/kernel/0311.1/0213.html
More traces (roughly the same) available on request.
* Some boards give bogus MAC addresses and work only partially. Same problem happens with nvnet on these boards.
* Transmit for packets close to MTU size was broken, should be fixed now.

Please test.

Regards,
Carl-Daniel

#1 lore raw

Carl-Daniel,

I just went through a similar oops for another driver last Thursday. Move the register_netdev(dev) after the initialization of 'dev->dev_stats = get_stats;' and the oops should be eliminated.

Don

Quoted 33 lines

Hello all,

version 0.17 of forcedeth for Linux 2.4 and 2.6 is available at
http://www.hailfinger.org/carldani/linux/patches/forcedeth/

Fixes in this release over 0.14:
* 0.15: 08 Nov 2003: fix smp deadlock with set_multicast_list
* during open.
* 0.16: 15 Nov 2003: include file cleanup for ppc64, rx buffer
* size increased to 1628 bytes.
* 0.17: 16 Nov 2003: undo rx buffer size increase. Substract 1
* from the tx length.

Known issues:
* Oops during module removal, probably sysfs related. Could a sysfs expert please take a look at the code? Call trace is at
http://www.ussg.iu.edu/hypermail/linux/kernel/0311.1/0213.html
More traces (roughly the same) available on request.
* Some boards give bogus MAC addresses and work only partially. Same problem happens with nvnet on these boards.
* Transmit for packets close to MTU size was broken, should be fixed now.

Please test.

Regards,
Carl-Daniel

Signature · 2 lines
Don Fry
[email protected]
#3 lore raw

Well, the problem I saw was with the 2.6 patch.

These lines:

+++ build-2.6/drivers/net/forcedeth.c 2003-11-15 23:00:30.000000000 +0100
@@ -0,0 +1,1416 @@

Should be

+++ build-2.6/drivers/net/forcedeth.c 2003-11-15 23:00:30.000000000 +0100
@@ -0,0 +1,1418 @@

Otherwise, the last 2 lines:
+module_init(init_nic);
+module_exit(exit_nic);

Get cut off.

-Brad

Quoted 15 lines · Carl-Daniel Hailfinger
Quoted 2 lines · Carl-Daniel Hailfinger

version 0.17 of forcedeth for Linux 2.4 and 2.6 is available at
http://www.hailfinger.org/carldani/linux/patches/forcedeth/

The patches for Linux 2.4 were malformed. Corrected versions have been uploaded a few hours ago.
Thanks to Brad House for spotting this.

Regards,
Carl-Daniel

#4 lore raw

Review

Quoted 13 lines · Brad House

Well, the problem I saw was with the 2.6 patch.

These lines:

+++ build-2.6/drivers/net/forcedeth.c 2003-11-15 23:00:30.000000000
+0100

(quoted diff) +0 -0
@@ -0,0 +1,1416 @@

Should be

+++ build-2.6/drivers/net/forcedeth.c 2003-11-15 23:00:30.000000000
+0100

(quoted diff) +0 -0
@@ -0,0 +1,1418 @@

Aaah! The files were corrupted during upload. That's why I didn't find the problem you described in my local version.
The problem is fixed now and MD5 sums have been uploaded to avoid this in the future.

Thanks again,
Carl-Daniel

Quoted 12 lines
Quoted 10 lines · Carl-Daniel Hailfinger
Quoted 2 lines · Carl-Daniel Hailfinger

version 0.17 of forcedeth for Linux 2.4 and 2.6 is available at
http://www.hailfinger.org/carldani/linux/patches/forcedeth/

The patches for Linux 2.4 were malformed. Corrected versions have been uploaded a few hours ago.
Thanks to Brad House for spotting this.