Skip to contentSkip to conversation

[2.4] change two annoying messages from framebuffer drivers

PATCH In review Michael Hunold 3 participants 4 messages Dec 12, 2003 – Dec 22, 2003 Framebuffer layer

lore
Share & tools
lore

Michael Hunold

author
#0 lore raw

PATCH 1/1 [2.4] change two annoying messages from framebuffer drivers

Hello,

the Linux-on-a-CD system Knoppix has nearly all framebuffer drivers for 2.4.23 compiled in. Additionally, it surpreesses most kernel messages by lowering the kernel log level.

Two framebuffer drivers (clgenfb.c and hgafb.c), however, use KERN_ERR to say that their particular card has *not* been found which is very annoying.

Especially the clgenfb.c driver simply says on bootup:

Quoted 1 line

Couldn't find PCI device

which can really confuse newbie users.

The appended patch replaces two KERN_ERR with KERN_INFO and additionally makes the clgen.c message more descriptive.

Please apply, thanks!

I'll create a separate patch 2.6 later, apparently clgenfb.c has gone there.

CU
Michael.

drivers/video/clgenfb.c +1 -1
diff -ur xx-linux-2.4.22/drivers/video/clgenfb.c xx-linux-2.4.22.p/drivers/video/clgenfb.c
@@ -2547,7 +2547,7 @@
 
 	pdev = clgen_pci_dev_get (btype);
 	if (!pdev) {
-		printk (KERN_ERR " Couldn't find PCI device\n");
+		printk (KERN_INFO "clgen: couldn't find Cirrus Logic PCI device\n");
 		DPRINTK ("EXIT, returning 1\n");
 		return 1;
 	}
drivers/video/hgafb.c +1 -1
diff -ur xx-linux-2.4.22/drivers/video/hgafb.c xx-linux-2.4.22.p/drivers/video/hgafb.c
@@ -704,7 +704,7 @@
 int __init hgafb_init(void)
 {
 	if (! hga_card_detect()) {
-		printk(KERN_ERR "hgafb: HGA card not detected.\n");
+		printk(KERN_INFO "hgafb: HGA card not detected.\n");
 		return -EINVAL;
 	}
#1 lore raw
Quoted 4 lines · Michael Hunold

Two framebuffer drivers (clgenfb.c and hgafb.c), however, use KERN_ERR to say that their particular card has *not* been found which is very annoying.

Quoted 8 lines

Especially the clgenfb.c driver simply says on bootup:

Quoted 1 line

Couldn't find PCI device

which can really confuse newbie users.

The appended patch replaces two KERN_ERR with KERN_INFO and additionally makes the clgen.c message more descriptive.

Please apply, thanks!

Patch looks OK to me, except that I would print clgenfb' instead of clgen'.

Quoted 1 line

I'll create a separate patch 2.6 later, apparently clgenfb.c has gone there.

It was renamed to cirrusfb.c.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#2 lore raw
Quoted 9 lines · Geert Uytterhoeven
Quoted 8 lines · Michael Hunold

Two framebuffer drivers (clgenfb.c and hgafb.c), however, use KERN_ERR to say that their particular card has *not* been found which is very annoying.

Especially the clgenfb.c driver simply says on bootup:

Quoted 1 line

Couldn't find PCI device

which can really confuse newbie users.

Quoted 6 lines
Quoted 4 lines

The appended patch replaces two KERN_ERR with KERN_INFO and additionally makes the clgen.c message more descriptive.

Please apply, thanks!

Patch looks OK to me, except that I would print clgenfb' instead of clgen'.

That looks sane.

Can you change it Michael?

author
#3 lore raw

Hello Marcelo,

Quoted 17 lines · Marcelo Tosatti
Quoted 13 lines · Geert Uytterhoeven
Quoted 11 lines · Michael Hunold

Two framebuffer drivers (clgenfb.c and hgafb.c), however, use KERN_ERR to say that their particular card has *not* been found which is very annoying.

Especially the clgenfb.c driver simply says on bootup:

Quoted 1 line

Couldn't find PCI device

which can really confuse newbie users.

The appended patch replaces two KERN_ERR with KERN_INFO and additionally makes the clgen.c message more descriptive.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Please apply, thanks!

Patch looks OK to me, except that I would print clgenfb' instead of clgen'.

That looks sane.

Can you change it Michael?

Attached is an updated patch -- sorry for the long delay.

I'll create a separate patch for 2.6 and sent it to Linus/Andrew.

CU
Michael.

drivers/video/clgenfb.c +1 -1
diff -ur xx-linux-2.4.22/drivers/video/clgenfb.c xx-linux-2.4.22.p/drivers/video/clgenfb.c
@@ -2547,7 +2547,7 @@
 
 	pdev = clgen_pci_dev_get (btype);
 	if (!pdev) {
-		printk (KERN_ERR " Couldn't find PCI device\n");
+		printk (KERN_INFO "clgenfb: couldn't find Cirrus Logic PCI device\n");
 		DPRINTK ("EXIT, returning 1\n");
 		return 1;
 	}
drivers/video/hgafb.c +1 -1
diff -ur xx-linux-2.4.22/drivers/video/hgafb.c xx-linux-2.4.22.p/drivers/video/hgafb.c
@@ -704,7 +704,7 @@
 int __init hgafb_init(void)
 {
 	if (! hga_card_detect()) {
-		printk(KERN_ERR "hgafb: HGA card not detected.\n");
+		printk(KERN_INFO "hgafb: HGA card not detected.\n");
 		return -EINVAL;
 	}