Skip to contentSkip to conversation

PCI Express support for 2.4 kernel

DISCUSSION Pete Zaitcev 1 participant 1 message Dec 15, 2003 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 4 lines

Date: Sun, 14 Dec 2003 19:28:37 +0200
From: Vladimir Kondratiev <[email protected]>

+++ linux-2.4.23-pciexp/arch/i386/kernel/pci-i386.h 2003-12-14 11:08:17.000000000 +0200

Generally I'm pretty tolerant of bizzare spacing, but in this case tabs were mixed into the patch, which causes funny effects.

Review

Quoted 5 lines
(quoted diff) +5 -0
+union pci_exp_data {
+    u32 l;
+    u16 w[2];
+    u8  b[4];
+} __attribute__((packed));

Bogus __attribute__((packed)), but it's only the begining. Whole thing is used where shifts would have worked.

Review

Quoted 5 lines
(quoted diff) +5 -0
+static void pci_express_fini(void)
+{
+    if (rrbar_virt) {	<====== Not trusting own code
+        iounmap(rrbar_virt);
+    }

All in all, raw. Also, a healthy dose of Itanium is prescribed.

-- Pete