bprm_count and stack_mprotect error when testing BPF LSM on v5.7-rc3
Hi,
When I test bpf lsm with (/test_progs -vv -t test_lsm ), failed with below issue:
root@lkp-skl-d01 /usr/src/perf_selftests-x86_64-rhel-7.6-kselftests-bpf-lsm-2-6a8b55ed4056ea5559ebe4f6a4b247f627870d4c/tools/testing/selftests/bpf# ./test_progs -vv -t test_lsm
libbpf: loading object 'lsm' from buffer
libbpf: section(1) .strtab, size 306, link 0, flags 0, type=3
libbpf: skip section(1) .strtab
libbpf: section(2) .text, size 0, link 0, flags 6, type=1
libbpf: skip section(2) .text
libbpf: section(3) lsm/file_mprotect, size 192, link 0, flags 6, type=1
libbpf: found program lsm/file_mprotect
libbpf: section(4) .rellsm/file_mprotect, size 32, link 25, flags 0, type=9
libbpf: section(5) lsm/bprm_committed_creds, size 104, link 0, flags 6, type=1
libbpf: found program lsm/bprm_committed_creds
libbpf: section(6) .rellsm/bprm_committed_creds, size 32, link 25, flags 0, type=9
libbpf: section(7) license, size 4, link 0, flags 3, type=1
libbpf: license of lsm is GPL
libbpf: section(8) .bss, size 12, link 0, flags 3, type=8
libbpf: section(9) .debug_loc, size 383, link 0, flags 0, type=1
libbpf: skip section(9) .debug_loc
libbpf: section(10) .rel.debug_loc, size 112, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_loc(10) for section(9)
libbpf: section(11) .debug_abbrev, size 901, link 0, flags 0, type=1
libbpf: skip section(11) .debug_abbrev
libbpf: section(12) .debug_info, size 237441, link 0, flags 0, type=1
libbpf: skip section(12) .debug_info
libbpf: section(13) .rel.debug_info, size 112, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_info(13) for section(12)
libbpf: section(14) .debug_ranges, size 96, link 0, flags 0, type=1
libbpf: skip section(14) .debug_ranges
libbpf: section(15) .rel.debug_ranges, size 128, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_ranges(15) for section(14)
libbpf: section(16) .debug_str, size 142395, link 0, flags 30, type=1
libbpf: skip section(16) .debug_str
libbpf: section(17) .BTF, size 5634, link 0, flags 0, type=1
libbpf: section(18) .rel.BTF, size 64, link 25, flags 0, type=9
libbpf: skip relo .rel.BTF(18) for section(17)
libbpf: section(19) .BTF.ext, size 484, link 0, flags 0, type=1
libbpf: section(20) .rel.BTF.ext, size 416, link 25, flags 0, type=9
libbpf: skip relo .rel.BTF.ext(20) for section(19)
libbpf: section(21) .debug_frame, size 64, link 0, flags 0, type=1
libbpf: skip section(21) .debug_frame
libbpf: section(22) .rel.debug_frame, size 32, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_frame(22) for section(21)
libbpf: section(23) .debug_line, size 227, link 0, flags 0, type=1
libbpf: skip section(23) .debug_line
libbpf: section(24) .rel.debug_line, size 32, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_line(24) for section(23)
libbpf: section(25) .symtab, size 288, link 1, flags 0, type=2
libbpf: looking for externs among 12 symbols...
libbpf: collected 0 externs total
libbpf: map 'lsm.bss' (global data): at sec_idx 8, offset 0, flags 400.
libbpf: map 0 is "lsm.bss"
libbpf: collecting relocating info for: 'lsm/file_mprotect'
libbpf: relo for shdr 8, symb 8, value 0, type 1, bind 1, name 232 ('monitored_pid'), insn 12
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 12
libbpf: relo for shdr 8, symb 9, value 4, type 1, bind 1, name 34 ('mprotect_count'), insn 17
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 17
libbpf: collecting relocating info for: 'lsm/bprm_committed_creds'
libbpf: relo for shdr 8, symb 8, value 0, type 1, bind 1, name 232 ('monitored_pid'), insn 1
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 1
libbpf: relo for shdr 8, symb 7, value 8, type 1, bind 1, name 49 ('bprm_count'), insn 6
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 6
libbpf: loading kernel BTF '/sys/kernel/btf/vmlinux': 0
libbpf: created map lsm.bss: fd=4
libbpf: loading kernel BTF '/sys/kernel/btf/vmlinux': 0
libbpf: prog 'lsm/file_mprotect': performing 4 CO-RE offset relocs
libbpf: prog 'lsm/file_mprotect': relo #0: kind 0, spec is [6] vm_area_struct + 0:6 => 64.0 @ &x[0].vm_mm
libbpf: [6] vm_area_struct: found candidate [329] vm_area_struct
libbpf: prog 'lsm/file_mprotect': relo #0: matching candidate #0 vm_area_struct against spec [329] vm_area_struct + 0:6 => 64.0 @ &x[0].vm_mm: 1
libbpf: prog 'lsm/file_mprotect': relo #0: patched insn #5 (LDX/ST/STX) off 64 -> 64
libbpf: prog 'lsm/file_mprotect': relo #1: kind 0, spec is [32] mm_struct + 0:0:35 => 304.0 @ &x[0].start_stack
libbpf: [32] mm_struct: found candidate [308] mm_struct
libbpf: prog 'lsm/file_mprotect': relo #1: matching candidate #0 mm_struct against spec [308] mm_struct + 0:0:35 => 304.0 @ &x[0].start_stack: 1
libbpf: prog 'lsm/file_mprotect': relo #1: patched insn #7 (LDX/ST/STX) off 304 -> 304
libbpf: prog 'lsm/file_mprotect': relo #2: kind 0, spec is [6] vm_area_struct + 0:0 => 0.0 @ &x[0].vm_start
libbpf: prog 'lsm/file_mprotect': relo #2: matching candidate #0 vm_area_struct against spec [329] vm_area_struct + 0:0 => 0.0 @ &x[0].vm_start: 1
libbpf: prog 'lsm/file_mprotect': relo #2: patched insn #8 (LDX/ST/STX) off 0 -> 0
libbpf: prog 'lsm/file_mprotect': relo #3: kind 0, spec is [6] vm_area_struct + 0:1 => 8.0 @ &x[0].vm_end
libbpf: prog 'lsm/file_mprotect': relo #3: matching candidate #0 vm_area_struct against spec [329] vm_area_struct + 0:1 => 8.0 @ &x[0].vm_end: 1
libbpf: prog 'lsm/file_mprotect': relo #3: patched insn #10 (LDX/ST/STX) off 8 -> 8
test_test_lsm:PASS:skel_load 0 nsec
test_test_lsm:PASS:attach 0 nsec
test_test_lsm:PASS:exec_cmd 0 nsec
test_test_lsm:FAIL:bprm_count bprm_count = 0
test_test_lsm:FAIL:stack_mprotect want err=EPERM, got 0
#70 test_lsm:FAIL
Summary: 0/0 PASSED, 0 SKIPPED, 1 FAILED
kconfig:
CONFIG_BPF_LSM=y
CONFIG_LSM="lockdown,yama,loadpin,safesetid,integrity,selinux,smack,tomoyo,apparmor"
besides:
when I add bpf to CONFIG_LSM, then boot failed.
boot error:
``` Cannot determine cgroup we are running in: No data available Failed to allocate manager object: No data available [!!!!!!] Failed to allocate manager object, freezing. Freezing execution. ```
seems bpf in CONFIG_LSM and CONFIG_BPF_LSM conflict.
clang version: v11.0.0
commit: 54b35c066417d4856e9d53313f7e98b354274584
# pahole --version v1.17
Signature · 2 lines
Best Regards. Ma Xinjian
Quoted 142 lines · Ma Xinjian
Hi,
When I test bpf lsm with (/test_progs -vv -t
test_lsm), failed with below issue:root@lkp-skl-d01 /usr/src/perf_selftests-x86_64-rhel-7.6-kselftests-bpf-lsm-2-6a8b55ed4056ea5559ebe4f6a4b247f627870d4c/tools/testing/selftests/bpf# ./test_progs -vv -t
test_lsmlibbpf: loading object 'lsm' from buffer
libbpf: section(1) .strtab, size 306, link 0, flags 0, type=3
libbpf: skip section(1) .strtab
libbpf: section(2) .text, size 0, link 0, flags 6, type=1
libbpf: skip section(2) .text
libbpf: section(3) lsm/file_mprotect, size 192, link 0, flags 6, type=1
libbpf: found program lsm/file_mprotect
libbpf: section(4) .rellsm/file_mprotect, size 32, link 25, flags 0, type=9
libbpf: section(5) lsm/bprm_committed_creds, size 104, link 0, flags 6, type=1
libbpf: found program lsm/bprm_committed_creds
libbpf: section(6) .rellsm/bprm_committed_creds, size 32, link 25, flags 0, type=9
libbpf: section(7) license, size 4, link 0, flags 3, type=1
libbpf: license of lsm is GPL
libbpf: section(8) .bss, size 12, link 0, flags 3, type=8
libbpf: section(9) .debug_loc, size 383, link 0, flags 0, type=1
libbpf: skip section(9) .debug_loc
libbpf: section(10) .rel.debug_loc, size 112, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_loc(10) for section(9)
libbpf: section(11) .debug_abbrev, size 901, link 0, flags 0, type=1
libbpf: skip section(11) .debug_abbrev
libbpf: section(12) .debug_info, size 237441, link 0, flags 0, type=1
libbpf: skip section(12) .debug_info
libbpf: section(13) .rel.debug_info, size 112, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_info(13) for section(12)
libbpf: section(14) .debug_ranges, size 96, link 0, flags 0, type=1
libbpf: skip section(14) .debug_ranges
libbpf: section(15) .rel.debug_ranges, size 128, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_ranges(15) for section(14)
libbpf: section(16) .debug_str, size 142395, link 0, flags 30, type=1
libbpf: skip section(16) .debug_str
libbpf: section(17) .BTF, size 5634, link 0, flags 0, type=1
libbpf: section(18) .rel.BTF, size 64, link 25, flags 0, type=9
libbpf: skip relo .rel.BTF(18) for section(17)
libbpf: section(19) .BTF.ext, size 484, link 0, flags 0, type=1
libbpf: section(20) .rel.BTF.ext, size 416, link 25, flags 0, type=9
libbpf: skip relo .rel.BTF.ext(20) for section(19)
libbpf: section(21) .debug_frame, size 64, link 0, flags 0, type=1
libbpf: skip section(21) .debug_frame
libbpf: section(22) .rel.debug_frame, size 32, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_frame(22) for section(21)
libbpf: section(23) .debug_line, size 227, link 0, flags 0, type=1
libbpf: skip section(23) .debug_line
libbpf: section(24) .rel.debug_line, size 32, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_line(24) for section(23)
libbpf: section(25) .symtab, size 288, link 1, flags 0, type=2
libbpf: looking for externs among 12 symbols...
libbpf: collected 0 externs total
libbpf: map 'lsm.bss' (global data): atsec_idx8, offset 0, flags 400.
libbpf: map 0 is "lsm.bss"
libbpf: collecting relocating info for: 'lsm/file_mprotect'
libbpf: relo for shdr 8, symb 8, value 0, type 1, bind 1, name 232 ('monitored_pid'), insn 12
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 12
libbpf: relo for shdr 8, symb 9, value 4, type 1, bind 1, name 34 ('mprotect_count'), insn 17
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 17
libbpf: collecting relocating info for: 'lsm/bprm_committed_creds'
libbpf: relo for shdr 8, symb 8, value 0, type 1, bind 1, name 232 ('monitored_pid'), insn 1
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 1
libbpf: relo for shdr 8, symb 7, value 8, type 1, bind 1, name 49 ('bprm_count'), insn 6
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 6
libbpf: loading kernel BTF '/sys/kernel/btf/vmlinux': 0
libbpf: created map lsm.bss: fd=4
libbpf: loading kernel BTF '/sys/kernel/btf/vmlinux': 0
libbpf: prog 'lsm/file_mprotect': performing 4 CO-RE offset relocs
libbpf: prog 'lsm/file_mprotect': relo #0: kind 0, spec is [6]vm_area_struct+ 0:6 => 64.0 @ &x[0].vm_mm
libbpf: [6]vm_area_struct: found candidate [329]vm_area_struct
libbpf: prog 'lsm/file_mprotect': relo #0: matching candidate #0vm_area_structagainst spec [329]vm_area_struct+ 0:6 => 64.0 @ &x[0].vm_mm: 1
libbpf: prog 'lsm/file_mprotect': relo #0: patched insn #5 (LDX/ST/STX) off 64 -> 64
libbpf: prog 'lsm/file_mprotect': relo #1: kind 0, spec is [32]mm_struct+ 0:0:35 => 304.0 @ &x[0].start_stack
libbpf: [32]mm_struct: found candidate [308]mm_struct
libbpf: prog 'lsm/file_mprotect': relo #1: matching candidate #0mm_structagainst spec [308]mm_struct+ 0:0:35 => 304.0 @ &x[0].start_stack: 1
libbpf: prog 'lsm/file_mprotect': relo #1: patched insn #7 (LDX/ST/STX) off 304 -> 304
libbpf: prog 'lsm/file_mprotect': relo #2: kind 0, spec is [6]vm_area_struct+ 0:0 => 0.0 @ &x[0].vm_start
libbpf: prog 'lsm/file_mprotect': relo #2: matching candidate #0vm_area_structagainst spec [329]vm_area_struct+ 0:0 => 0.0 @ &x[0].vm_start: 1
libbpf: prog 'lsm/file_mprotect': relo #2: patched insn #8 (LDX/ST/STX) off 0 -> 0
libbpf: prog 'lsm/file_mprotect': relo #3: kind 0, spec is [6]vm_area_struct+ 0:1 => 8.0 @ &x[0].vm_end
libbpf: prog 'lsm/file_mprotect': relo #3: matching candidate #0vm_area_structagainst spec [329]vm_area_struct+ 0:1 => 8.0 @ &x[0].vm_end: 1
libbpf: prog 'lsm/file_mprotect': relo #3: patched insn #10 (LDX/ST/STX) off 8 -> 8
test_test_lsm:PASS:skel_load 0 nsec
test_test_lsm:PASS:attach 0 nsec
test_test_lsm:PASS:exec_cmd 0 nsec test_test_lsm:FAIL:bprm_countbprm_count= 0 test_test_lsm:FAIL:stack_mprotect want err=EPERM, got 0
#70 test_lsm:FAIL
Summary: 0/0 PASSED, 0 SKIPPED, 1 FAILEDkconfig:
CONFIG_BPF_LSM=y
CONFIG_LSM="lockdown,yama,loadpin,safesetid,integrity,selinux,smack,tomoyo,apparmor"besides:
when I add bpf to
CONFIG_LSM, then boot failed.boot error:
``` Cannot determine cgroup we are running in: No data available Failed to allocate manager object: No data available [!!!!!!] Failed to allocate manager object, freezing. Freezing execution. ```seems bpf in
CONFIG_LSMandCONFIG_BPF_LSMconflict.
Quoted 7 lines
clang version: v11.0.0
commit:
54b35c066417d4856e9d53313f7e98b354274584# pahole --version v1.17
It might be due to bug in default return value of one of the functions, which KP recently fixed. But just to be sure, KP, could you please take a look?
Quoted 5 lines
--
Best Regards.
Ma Xinjian
A message that is not in the archive (sent off-list or not yet received): CAFLU3KuU6zFs7+xQ-=vy9WEx-4U=cTSW9VXNMyxRdwY3LHc9HA@mail.gmail.com
Adding the list back after an HTML/text mess up.
Quoted 171 lines · KP Singh
Can you check if you have the following fix:
https://lore.kernel.org/bpf/[email protected]/
The test fails because the "bpf" is not in the LSM string which means the
file_mprotecthook does not return a-EPERMerror.- KP
Quoted 161 lines · Andrii Nakryiko
Quoted 142 lines · Ma Xinjian
Hi,
When I test bpf lsm with (/test_progs -vv -t
test_lsm), failed with below issue:root@lkp-skl-d01 /usr/src/perf_selftests-x86_64-rhel-7.6-kselftests-bpf-lsm-2-6a8b55ed4056ea5559ebe4f6a4b247f627870d4c/tools/testing/selftests/bpf# ./test_progs -vv -t
test_lsmlibbpf: loading object 'lsm' from buffer
libbpf: section(1) .strtab, size 306, link 0, flags 0, type=3
libbpf: skip section(1) .strtab
libbpf: section(2) .text, size 0, link 0, flags 6, type=1
libbpf: skip section(2) .text
libbpf: section(3) lsm/file_mprotect, size 192, link 0, flags 6, type=1
libbpf: found program lsm/file_mprotect
libbpf: section(4) .rellsm/file_mprotect, size 32, link 25, flags 0, type=9
libbpf: section(5) lsm/bprm_committed_creds, size 104, link 0, flags 6, type=1
libbpf: found program lsm/bprm_committed_creds
libbpf: section(6) .rellsm/bprm_committed_creds, size 32, link 25, flags 0, type=9
libbpf: section(7) license, size 4, link 0, flags 3, type=1
libbpf: license of lsm is GPL
libbpf: section(8) .bss, size 12, link 0, flags 3, type=8
libbpf: section(9) .debug_loc, size 383, link 0, flags 0, type=1
libbpf: skip section(9) .debug_loc
libbpf: section(10) .rel.debug_loc, size 112, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_loc(10) for section(9)
libbpf: section(11) .debug_abbrev, size 901, link 0, flags 0, type=1
libbpf: skip section(11) .debug_abbrev
libbpf: section(12) .debug_info, size 237441, link 0, flags 0, type=1
libbpf: skip section(12) .debug_info
libbpf: section(13) .rel.debug_info, size 112, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_info(13) for section(12)
libbpf: section(14) .debug_ranges, size 96, link 0, flags 0, type=1
libbpf: skip section(14) .debug_ranges
libbpf: section(15) .rel.debug_ranges, size 128, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_ranges(15) for section(14)
libbpf: section(16) .debug_str, size 142395, link 0, flags 30, type=1
libbpf: skip section(16) .debug_str
libbpf: section(17) .BTF, size 5634, link 0, flags 0, type=1
libbpf: section(18) .rel.BTF, size 64, link 25, flags 0, type=9
libbpf: skip relo .rel.BTF(18) for section(17)
libbpf: section(19) .BTF.ext, size 484, link 0, flags 0, type=1
libbpf: section(20) .rel.BTF.ext, size 416, link 25, flags 0, type=9
libbpf: skip relo .rel.BTF.ext(20) for section(19)
libbpf: section(21) .debug_frame, size 64, link 0, flags 0, type=1
libbpf: skip section(21) .debug_frame
libbpf: section(22) .rel.debug_frame, size 32, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_frame(22) for section(21)
libbpf: section(23) .debug_line, size 227, link 0, flags 0, type=1
libbpf: skip section(23) .debug_line
libbpf: section(24) .rel.debug_line, size 32, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_line(24) for section(23)
libbpf: section(25) .symtab, size 288, link 1, flags 0, type=2
libbpf: looking for externs among 12 symbols...
libbpf: collected 0 externs total
libbpf: map 'lsm.bss' (global data): atsec_idx8, offset 0, flags 400.
libbpf: map 0 is "lsm.bss"
libbpf: collecting relocating info for: 'lsm/file_mprotect'
libbpf: relo for shdr 8, symb 8, value 0, type 1, bind 1, name 232 ('monitored_pid'), insn 12
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 12
libbpf: relo for shdr 8, symb 9, value 4, type 1, bind 1, name 34 ('mprotect_count'), insn 17
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 17
libbpf: collecting relocating info for: 'lsm/bprm_committed_creds'
libbpf: relo for shdr 8, symb 8, value 0, type 1, bind 1, name 232 ('monitored_pid'), insn 1
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 1
libbpf: relo for shdr 8, symb 7, value 8, type 1, bind 1, name 49 ('bprm_count'), insn 6
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 6
libbpf: loading kernel BTF '/sys/kernel/btf/vmlinux': 0
libbpf: created map lsm.bss: fd=4
libbpf: loading kernel BTF '/sys/kernel/btf/vmlinux': 0
libbpf: prog 'lsm/file_mprotect': performing 4 CO-RE offset relocs
libbpf: prog 'lsm/file_mprotect': relo #0: kind 0, spec is [6]vm_area_struct+ 0:6 => 64.0 @ &x[0].vm_mm
libbpf: [6]vm_area_struct: found candidate [329]vm_area_struct
libbpf: prog 'lsm/file_mprotect': relo #0: matching candidate #0vm_area_structagainst spec [329]vm_area_struct+ 0:6 => 64.0 @ &x[0].vm_mm: 1
libbpf: prog 'lsm/file_mprotect': relo #0: patched insn #5 (LDX/ST/STX) off 64 -> 64
libbpf: prog 'lsm/file_mprotect': relo #1: kind 0, spec is [32]mm_struct+ 0:0:35 => 304.0 @ &x[0].start_stack
libbpf: [32]mm_struct: found candidate [308]mm_struct
libbpf: prog 'lsm/file_mprotect': relo #1: matching candidate #0mm_structagainst spec [308]mm_struct+ 0:0:35 => 304.0 @ &x[0].start_stack: 1
libbpf: prog 'lsm/file_mprotect': relo #1: patched insn #7 (LDX/ST/STX) off 304 -> 304
libbpf: prog 'lsm/file_mprotect': relo #2: kind 0, spec is [6]vm_area_struct+ 0:0 => 0.0 @ &x[0].vm_start
libbpf: prog 'lsm/file_mprotect': relo #2: matching candidate #0vm_area_structagainst spec [329]vm_area_struct+ 0:0 => 0.0 @ &x[0].vm_start: 1
libbpf: prog 'lsm/file_mprotect': relo #2: patched insn #8 (LDX/ST/STX) off 0 -> 0
libbpf: prog 'lsm/file_mprotect': relo #3: kind 0, spec is [6]vm_area_struct+ 0:1 => 8.0 @ &x[0].vm_end
libbpf: prog 'lsm/file_mprotect': relo #3: matching candidate #0vm_area_structagainst spec [329]vm_area_struct+ 0:1 => 8.0 @ &x[0].vm_end: 1
libbpf: prog 'lsm/file_mprotect': relo #3: patched insn #10 (LDX/ST/STX) off 8 -> 8
test_test_lsm:PASS:skel_load 0 nsec
test_test_lsm:PASS:attach 0 nsec
test_test_lsm:PASS:exec_cmd 0 nsec test_test_lsm:FAIL:bprm_countbprm_count= 0 test_test_lsm:FAIL:stack_mprotect want err=EPERM, got 0
#70 test_lsm:FAIL
Summary: 0/0 PASSED, 0 SKIPPED, 1 FAILEDkconfig:
CONFIG_BPF_LSM=y
CONFIG_LSM="lockdown,yama,loadpin,safesetid,integrity,selinux,smack,tomoyo,apparmor"besides:
when I add bpf to
CONFIG_LSM, then boot failed.boot error:
``` Cannot determine cgroup we are running in: No data available Failed to allocate manager object: No data available [!!!!!!] Failed to allocate manager object, freezing. Freezing execution. ```seems bpf in
CONFIG_LSMandCONFIG_BPF_LSMconflict.Quoted 7 lines
clang version: v11.0.0
commit:
54b35c066417d4856e9d53313f7e98b354274584# pahole --version v1.17It might be due to bug in default return value of one of the functions, which KP recently fixed. But just to be sure, KP, could you please take a look?
Quoted 5 lines
--
Best Regards.
Ma Xinjian
Quoted 10 lines · KP Singh
Adding the list back after an HTML/text mess up.
Quoted 7 lines · KP Singh
Can you check if you have the following fix:
https://lore.kernel.org/bpf/[email protected]/
The test fails because the "bpf" is not in the LSM string which means the
file_mprotecthook does not return a-EPERMerror.- KP
I have rebuilt kernel with this fix.
root@lkp-skl-d01 ~# grep "ENOPARAM" /usr/src/perf_selftests-x86_64-rhel-7.6-kselftests-bpf-lsm-2-79dede78c0573618e3137d3d8cbf78c84e25fabd/include/linux/lsm_hook_defs.h LSM_HOOK(int, -ENOPARAM, fs_context_parse_param, struct fs_context *fc,
But still the same issue, and error message are exactly the same.
Anything else I can check in my env?
Ma
Quoted 159 lines
Quoted 159 lines · Andrii Nakryiko
Quoted 157 lines · Ma Xinjian
Quoted 141 lines
Hi,
When I test bpf lsm with (/test_progs -vv -t
test_lsm), failed with below issue:root@lkp-skl-d01 /usr/src/perf_selftests-x86_64-rhel-7.6-kselftests-bpf-lsm-2-6a8b55ed4056ea5559ebe4f6a4b247f627870d4c/tools/testing/selftests/bpf# ./test_progs -vv -t
test_lsmlibbpf: loading object 'lsm' from buffer
libbpf: section(1) .strtab, size 306, link 0, flags 0, type=3
libbpf: skip section(1) .strtab
libbpf: section(2) .text, size 0, link 0, flags 6, type=1
libbpf: skip section(2) .text
libbpf: section(3) lsm/file_mprotect, size 192, link 0, flags 6, type=1
libbpf: found program lsm/file_mprotect
libbpf: section(4) .rellsm/file_mprotect, size 32, link 25, flags 0, type=9
libbpf: section(5) lsm/bprm_committed_creds, size 104, link 0, flags 6, type=1
libbpf: found program lsm/bprm_committed_creds
libbpf: section(6) .rellsm/bprm_committed_creds, size 32, link 25, flags 0, type=9
libbpf: section(7) license, size 4, link 0, flags 3, type=1
libbpf: license of lsm is GPL
libbpf: section(8) .bss, size 12, link 0, flags 3, type=8
libbpf: section(9) .debug_loc, size 383, link 0, flags 0, type=1
libbpf: skip section(9) .debug_loc
libbpf: section(10) .rel.debug_loc, size 112, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_loc(10) for section(9)
libbpf: section(11) .debug_abbrev, size 901, link 0, flags 0, type=1
libbpf: skip section(11) .debug_abbrev
libbpf: section(12) .debug_info, size 237441, link 0, flags 0, type=1
libbpf: skip section(12) .debug_info
libbpf: section(13) .rel.debug_info, size 112, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_info(13) for section(12)
libbpf: section(14) .debug_ranges, size 96, link 0, flags 0, type=1
libbpf: skip section(14) .debug_ranges
libbpf: section(15) .rel.debug_ranges, size 128, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_ranges(15) for section(14)
libbpf: section(16) .debug_str, size 142395, link 0, flags 30, type=1
libbpf: skip section(16) .debug_str
libbpf: section(17) .BTF, size 5634, link 0, flags 0, type=1
libbpf: section(18) .rel.BTF, size 64, link 25, flags 0, type=9
libbpf: skip relo .rel.BTF(18) for section(17)
libbpf: section(19) .BTF.ext, size 484, link 0, flags 0, type=1
libbpf: section(20) .rel.BTF.ext, size 416, link 25, flags 0, type=9
libbpf: skip relo .rel.BTF.ext(20) for section(19)
libbpf: section(21) .debug_frame, size 64, link 0, flags 0, type=1
libbpf: skip section(21) .debug_frame
libbpf: section(22) .rel.debug_frame, size 32, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_frame(22) for section(21)
libbpf: section(23) .debug_line, size 227, link 0, flags 0, type=1
libbpf: skip section(23) .debug_line
libbpf: section(24) .rel.debug_line, size 32, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_line(24) for section(23)
libbpf: section(25) .symtab, size 288, link 1, flags 0, type=2
libbpf: looking for externs among 12 symbols...
libbpf: collected 0 externs total
libbpf: map 'lsm.bss' (global data): atsec_idx8, offset 0, flags 400.
libbpf: map 0 is "lsm.bss"
libbpf: collecting relocating info for: 'lsm/file_mprotect'
libbpf: relo for shdr 8, symb 8, value 0, type 1, bind 1, name 232 ('monitored_pid'), insn 12
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 12
libbpf: relo for shdr 8, symb 9, value 4, type 1, bind 1, name 34 ('mprotect_count'), insn 17
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 17
libbpf: collecting relocating info for: 'lsm/bprm_committed_creds'
libbpf: relo for shdr 8, symb 8, value 0, type 1, bind 1, name 232 ('monitored_pid'), insn 1
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 1
libbpf: relo for shdr 8, symb 7, value 8, type 1, bind 1, name 49 ('bprm_count'), insn 6
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 6
libbpf: loading kernel BTF '/sys/kernel/btf/vmlinux': 0
libbpf: created map lsm.bss: fd=4
libbpf: loading kernel BTF '/sys/kernel/btf/vmlinux': 0
libbpf: prog 'lsm/file_mprotect': performing 4 CO-RE offset relocs
libbpf: prog 'lsm/file_mprotect': relo #0: kind 0, spec is [6]vm_area_struct+ 0:6 => 64.0 @ &x[0].vm_mm
libbpf: [6]vm_area_struct: found candidate [329]vm_area_struct
libbpf: prog 'lsm/file_mprotect': relo #0: matching candidate #0vm_area_structagainst spec [329]vm_area_struct+ 0:6 => 64.0 @ &x[0].vm_mm: 1
libbpf: prog 'lsm/file_mprotect': relo #0: patched insn #5 (LDX/ST/STX) off 64 -> 64
libbpf: prog 'lsm/file_mprotect': relo #1: kind 0, spec is [32]mm_struct+ 0:0:35 => 304.0 @ &x[0].start_stack
libbpf: [32]mm_struct: found candidate [308]mm_struct
libbpf: prog 'lsm/file_mprotect': relo #1: matching candidate #0mm_structagainst spec [308]mm_struct+ 0:0:35 => 304.0 @ &x[0].start_stack: 1
libbpf: prog 'lsm/file_mprotect': relo #1: patched insn #7 (LDX/ST/STX) off 304 -> 304
libbpf: prog 'lsm/file_mprotect': relo #2: kind 0, spec is [6]vm_area_struct+ 0:0 => 0.0 @ &x[0].vm_start
libbpf: prog 'lsm/file_mprotect': relo #2: matching candidate #0vm_area_structagainst spec [329]vm_area_struct+ 0:0 => 0.0 @ &x[0].vm_start: 1
libbpf: prog 'lsm/file_mprotect': relo #2: patched insn #8 (LDX/ST/STX) off 0 -> 0
libbpf: prog 'lsm/file_mprotect': relo #3: kind 0, spec is [6]vm_area_struct+ 0:1 => 8.0 @ &x[0].vm_end
libbpf: prog 'lsm/file_mprotect': relo #3: matching candidate #0vm_area_structagainst spec [329]vm_area_struct+ 0:1 => 8.0 @ &x[0].vm_end: 1
libbpf: prog 'lsm/file_mprotect': relo #3: patched insn #10 (LDX/ST/STX) off 8 -> 8
test_test_lsm:PASS:skel_load 0 nsec
test_test_lsm:PASS:attach 0 nsec
test_test_lsm:PASS:exec_cmd 0 nsec test_test_lsm:FAIL:bprm_countbprm_count= 0 test_test_lsm:FAIL:stack_mprotect want err=EPERM, got 0
#70 test_lsm:FAIL
Summary: 0/0 PASSED, 0 SKIPPED, 1 FAILEDkconfig:
CONFIG_BPF_LSM=y
CONFIG_LSM="lockdown,yama,loadpin,safesetid,integrity,selinux,smack,tomoyo,apparmor"besides:
when I add bpf to
CONFIG_LSM, then boot failed.boot error:
``` Cannot determine cgroup we are running in: No data available Failed to allocate manager object: No data available [!!!!!!] Failed to allocate manager object, freezing. Freezing execution. ```seems bpf in
CONFIG_LSMandCONFIG_BPF_LSMconflict.Quoted 7 lines
clang version: v11.0.0
commit:
54b35c066417d4856e9d53313f7e98b354274584# pahole --version v1.17It might be due to bug in default return value of one of the functions, which KP recently fixed. But just to be sure, KP, could you please take a look?
Quoted 4 lines
--
Best Regards.
Ma Xinjian
Signature · 2 lines
Best Regards. Ma Xinjian
Do you have bpf in your CONFIG_LSM string?
Also, can you share your Kconfig please?
Quoted 190 lines · Ma Xinjian
Quoted 10 lines · KP Singh
Adding the list back after an HTML/text mess up.
Quoted 7 lines · KP Singh
Can you check if you have the following fix:
https://lore.kernel.org/bpf/[email protected]/
The test fails because the "bpf" is not in the LSM string which means the
file_mprotecthook does not return a-EPERMerror.- KP
I have rebuilt kernel with this fix.
root@lkp-skl-d01 ~# grep "ENOPARAM"
/usr/src/perf_selftests-x86_64-rhel-7.6-kselftests-bpf-lsm-2-79dede78c0573618e3137d3d8cbf78c84e25fabd/include/linux/lsm_hook_defs.hLSM_HOOK(int,-ENOPARAM,fs_context_parse_param, structfs_context*fc,But still the same issue, and error message are exactly the same.
Anything else I can check in my env?
Ma
Quoted 151 lines
Quoted 151 lines · Andrii Nakryiko
Quoted 149 lines · Ma Xinjian
Quoted 148 lines
Hi,
When I test bpf lsm with (/test_progs -vv -t
test_lsm), failed with below issue:root@lkp-skl-d01 /usr/src/perf_selftests-x86_64-rhel-7.6-kselftests-bpf-lsm-2-6a8b55ed4056ea5559ebe4f6a4b247f627870d4c/tools/testing/selftests/bpf# ./test_progs -vv -t
test_lsmlibbpf: loading object 'lsm' from buffer
libbpf: section(1) .strtab, size 306, link 0, flags 0, type=3
libbpf: skip section(1) .strtab
libbpf: section(2) .text, size 0, link 0, flags 6, type=1
libbpf: skip section(2) .text
libbpf: section(3) lsm/file_mprotect, size 192, link 0, flags 6, type=1
libbpf: found program lsm/file_mprotect
libbpf: section(4) .rellsm/file_mprotect, size 32, link 25, flags 0, type=9
libbpf: section(5) lsm/bprm_committed_creds, size 104, link 0, flags 6, type=1
libbpf: found program lsm/bprm_committed_creds
libbpf: section(6) .rellsm/bprm_committed_creds, size 32, link 25, flags 0, type=9
libbpf: section(7) license, size 4, link 0, flags 3, type=1
libbpf: license of lsm is GPL
libbpf: section(8) .bss, size 12, link 0, flags 3, type=8
libbpf: section(9) .debug_loc, size 383, link 0, flags 0, type=1
libbpf: skip section(9) .debug_loc
libbpf: section(10) .rel.debug_loc, size 112, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_loc(10) for section(9)
libbpf: section(11) .debug_abbrev, size 901, link 0, flags 0, type=1
libbpf: skip section(11) .debug_abbrev
libbpf: section(12) .debug_info, size 237441, link 0, flags 0, type=1
libbpf: skip section(12) .debug_info
libbpf: section(13) .rel.debug_info, size 112, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_info(13) for section(12)
libbpf: section(14) .debug_ranges, size 96, link 0, flags 0, type=1
libbpf: skip section(14) .debug_ranges
libbpf: section(15) .rel.debug_ranges, size 128, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_ranges(15) for section(14)
libbpf: section(16) .debug_str, size 142395, link 0, flags 30, type=1
libbpf: skip section(16) .debug_str
libbpf: section(17) .BTF, size 5634, link 0, flags 0, type=1
libbpf: section(18) .rel.BTF, size 64, link 25, flags 0, type=9
libbpf: skip relo .rel.BTF(18) for section(17)
libbpf: section(19) .BTF.ext, size 484, link 0, flags 0, type=1
libbpf: section(20) .rel.BTF.ext, size 416, link 25, flags 0, type=9
libbpf: skip relo .rel.BTF.ext(20) for section(19)
libbpf: section(21) .debug_frame, size 64, link 0, flags 0, type=1
libbpf: skip section(21) .debug_frame
libbpf: section(22) .rel.debug_frame, size 32, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_frame(22) for section(21)
libbpf: section(23) .debug_line, size 227, link 0, flags 0, type=1
libbpf: skip section(23) .debug_line
libbpf: section(24) .rel.debug_line, size 32, link 25, flags 0, type=9
libbpf: skip relo .rel.debug_line(24) for section(23)
libbpf: section(25) .symtab, size 288, link 1, flags 0, type=2
libbpf: looking for externs among 12 symbols...
libbpf: collected 0 externs total
libbpf: map 'lsm.bss' (global data): atsec_idx8, offset 0, flags 400.
libbpf: map 0 is "lsm.bss"
libbpf: collecting relocating info for: 'lsm/file_mprotect'
libbpf: relo for shdr 8, symb 8, value 0, type 1, bind 1, name 232 ('monitored_pid'), insn 12
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 12
libbpf: relo for shdr 8, symb 9, value 4, type 1, bind 1, name 34 ('mprotect_count'), insn 17
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 17
libbpf: collecting relocating info for: 'lsm/bprm_committed_creds'
libbpf: relo for shdr 8, symb 8, value 0, type 1, bind 1, name 232 ('monitored_pid'), insn 1
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 1
libbpf: relo for shdr 8, symb 7, value 8, type 1, bind 1, name 49 ('bprm_count'), insn 6
libbpf: found data map 0 (lsm.bss, sec 8, off 0) for insn 6
libbpf: loading kernel BTF '/sys/kernel/btf/vmlinux': 0
libbpf: created map lsm.bss: fd=4
libbpf: loading kernel BTF '/sys/kernel/btf/vmlinux': 0
libbpf: prog 'lsm/file_mprotect': performing 4 CO-RE offset relocs
libbpf: prog 'lsm/file_mprotect': relo #0: kind 0, spec is [6]vm_area_struct+ 0:6 => 64.0 @ &x[0].vm_mm
libbpf: [6]vm_area_struct: found candidate [329]vm_area_struct
libbpf: prog 'lsm/file_mprotect': relo #0: matching candidate #0vm_area_structagainst spec [329]vm_area_struct+ 0:6 => 64.0 @ &x[0].vm_mm: 1
libbpf: prog 'lsm/file_mprotect': relo #0: patched insn #5 (LDX/ST/STX) off 64 -> 64
libbpf: prog 'lsm/file_mprotect': relo #1: kind 0, spec is [32]mm_struct+ 0:0:35 => 304.0 @ &x[0].start_stack
libbpf: [32]mm_struct: found candidate [308]mm_struct
libbpf: prog 'lsm/file_mprotect': relo #1: matching candidate #0mm_structagainst spec [308]mm_struct+ 0:0:35 => 304.0 @ &x[0].start_stack: 1
libbpf: prog 'lsm/file_mprotect': relo #1: patched insn #7 (LDX/ST/STX) off 304 -> 304
libbpf: prog 'lsm/file_mprotect': relo #2: kind 0, spec is [6]vm_area_struct+ 0:0 => 0.0 @ &x[0].vm_start
libbpf: prog 'lsm/file_mprotect': relo #2: matching candidate #0vm_area_structagainst spec [329]vm_area_struct+ 0:0 => 0.0 @ &x[0].vm_start: 1
libbpf: prog 'lsm/file_mprotect': relo #2: patched insn #8 (LDX/ST/STX) off 0 -> 0
libbpf: prog 'lsm/file_mprotect': relo #3: kind 0, spec is [6]vm_area_struct+ 0:1 => 8.0 @ &x[0].vm_end
libbpf: prog 'lsm/file_mprotect': relo #3: matching candidate #0vm_area_structagainst spec [329]vm_area_struct+ 0:1 => 8.0 @ &x[0].vm_end: 1
libbpf: prog 'lsm/file_mprotect': relo #3: patched insn #10 (LDX/ST/STX) off 8 -> 8
test_test_lsm:PASS:skel_load 0 nsec
test_test_lsm:PASS:attach 0 nsec
test_test_lsm:PASS:exec_cmd 0 nsec test_test_lsm:FAIL:bprm_countbprm_count= 0 test_test_lsm:FAIL:stack_mprotect want err=EPERM, got 0
#70 test_lsm:FAIL
Summary: 0/0 PASSED, 0 SKIPPED, 1 FAILEDkconfig:
CONFIG_BPF_LSM=y
CONFIG_LSM="lockdown,yama,loadpin,safesetid,integrity,selinux,smack,tomoyo,apparmor"besides:
when I add bpf to
CONFIG_LSM, then boot failed.boot error:
``` Cannot determine cgroup we are running in: No data available Failed to allocate manager object: No data available [!!!!!!] Failed to allocate manager object, freezing. Freezing execution. ```seems bpf in
CONFIG_LSMandCONFIG_BPF_LSMconflict.clang version: v11.0.0
commit:
54b35c066417d4856e9d53313f7e98b354274584# pahole --version v1.17Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
It might be due to bug in default return value of one of the functions, which KP recently fixed. But just to be sure, KP, could you please take a look?
Quoted 4 lines
--
Best Regards.
Ma Xinjian--
Best Regards.
Ma Xinjian
Also, I would appreciate it if you can share some details / steps for reproducing this error and your environment (is it a physical machine? VM etc?)
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 8 lines · Ma Xinjian
Quoted 1 line · KP Singh
Do you have bpf in your
CONFIG_LSMstring?That's the point!
I remove bpf from since I can't boot if bpf in it.
That does indicate a problem which needs to be fixed.
Quoted 7 lines
seems bpf in
CONFIG_LSMconflict withCONFIG_BPF_LSMHere is boot error:
"Cannot determine cgroup we are running in: No data available Failed to allocate manager object: No data available [!!!!!!] Failed to allocate manager object, freezing.
I found some references to these error messages and they seem to be coming from systemd but I am not sure.
https://github.com/lxc/lxc/issues/1669
https://github.com/containers/libpod/issues/1226
Quoted 9 lines
Freezing execution.
[ 35.773797] random: fast init done [ 130.560629] random: crng init done"Quoted 1 line
Also, can you share your
Kconfigplease?refer to attackment.
I doubt sth was wrong with my kconfig, maybe me some suggestion
I am not saying something is wrong with your Kconfig :) I just want to make sure we eliminate as many variables as possible.
I was able to boot this successfully using QEMU (after I enabled SCSI and VIRTIO). So it's likely dependent on some user-space configuration (again, I am not saying your config is wrong). But I will need more information to reproduce and debug this.
Can you try providing a reliable reproduction with a list of steps? e.g.
1. Download the vanilla image here.
2. Compile the kernel with defonconfig and kvmconfig (or your own config)
3. Boot the kernel in QEMU with the cmdline (...) and the QEMU args (...)
Thanks!
- KP
Quoted 2 lines
Besides, I tested on both physical machine and vm
[...]
Quoted 1 line
Quoted 1 line
Quoted 43 lines · KP Singh
Quoted 6 lines · Ma Xinjian
Quoted 1 line · KP Singh
Do you have bpf in your
CONFIG_LSMstring?That's the point!
I remove bpf from since I can't boot if bpf in it.
That does indicate a problem which needs to be fixed.
Quoted 7 lines
seems bpf in
CONFIG_LSMconflict withCONFIG_BPF_LSMHere is boot error:
"Cannot determine cgroup we are running in: No data available Failed to allocate manager object: No data available [!!!!!!] Failed to allocate manager object, freezing.
I found some references to these error messages and they seem to be coming from systemd but I am not sure.
https://github.com/lxc/lxc/issues/1669 https://github.com/containers/libpod/issues/1226Quoted 8 lines
Freezing execution.
[ 35.773797] random: fast init done [ 130.560629] random: crng init done"Quoted 1 line
Also, can you share your
Kconfigplease?refer to attackment.
I doubt sth was wrong with my kconfig, maybe me some suggestion
I am not saying something is wrong with your
Kconfig:) I just want to make sure we eliminate as many variables as possible.I was able to boot this successfully using QEMU (after I enabled SCSI and VIRTIO). So it's likely dependent on some user-space configuration (again, I am not saying your config is wrong). But I will need more information to reproduce and debug this.
Can you try providing a reliable reproduction with a list of steps? e.g.
Quoted 8 lines
1. Download the vanilla image here.
2. Compile the kernel with defonconfig and kvmconfig (or your own config)
3. Boot the kernel in QEMU with the cmdline (...) and the QEMU args (...)Thanks!
- KP
Thank you very much for your kind and quick reply.
I tested on LKP cluster of Intel. Everything works automatically.
https://github.com/intel/lkp-tests
---------------------
And I have found the cause.
It can't boot due to comfliction between cgroup configuration for CONFIG_BPF_LSM
and systemd.
similar to https://github.com/elogind/elogind/issues/18
we have decided to skip this test.
Thanks again.
- Ma
Quoted 4 lines
Quoted 2 lines
Besides, I tested on both physical machine and vm
[...]
Signature · 2 lines
Best Regards. Ma Xinjian