Skip to contentSkip to conversation

Command history and Command buffer editing

PATCH In review J Mac 2 participants 3 messages Sep 27, 2005 – Nov 16, 2005

lore
Share & tools
lore

J Mac

author
#0 lore raw

PATCH 1/1 Command history and Command buffer editing

I made this patch using 'diff' on two source trees; I got the original copies of the files from the gitweb interface at source.denx.net. I used the 'diff -purN OLD NEW' command as described in README to generate the patch.

All code changes are local to common/main.c

Define CONFIG_COMMAND_HISTORY and/or CONFIG_COMMAND_EDIT to enable the behaviour(s).

Please let me know if there is something I need to do to make the patch acceptable.

* Patch by James MacAulay Sept 27, 2005
- Add a configuration option CONFIG_COMMAND_HISTORY to implement command history. Uses up and down arrow keys to scroll through history. Other options are described in README.
- Add a configuration option CONFIG_COMMAND_EDIT to implement command buffer editing. Uses ^A, ^E, left and right arrow keys to move through command buffer. Other options are described in README.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: command_history_and_edit.patch.tar.gz
Type: application/x-gzip
Size: 3803 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050927/b76c2190/attachment.bin

author
#1 lore raw

d'oh!

I discovered a foolish mistake in my patch release methods. I missed a last minute update to the included headers section. here is the new patch...

* Patch by James MacAulay Sept 27, 2005
- Add a configuration option CONFIG_COMMAND_HISTORY to implement command history. Uses up and down arrow keys to scroll through history. Other options are described in README.
- Add a configuration option CONFIG_COMMAND_EDIT to implement command buffer editing. Uses ^A, ^E, left and right arrow keys to move through command buffer. Other options are described in README.

Quoted 12 lines · J Mac

I made this patch using 'diff' on two source trees; I got the original copies of the files from the gitweb interface at source.denx.net. I used the 'diff -purN OLD NEW' command as described in README to generate the patch.

All code changes are local to common/main.c

Define CONFIG_COMMAND_HISTORY and/or CONFIG_COMMAND_EDIT to enable the behaviour(s).

Please let me know if there is something I need to do to make the patch acceptable.

Quoted 10 lines

* Patch by James MacAulay Sept 27, 2005
- Add a configuration option CONFIG_COMMAND_HISTORY to implement command history. Uses up and down arrow keys to scroll through history. Other options are described in README.
- Add a configuration option CONFIG_COMMAND_EDIT to implement command buffer editing. Uses ^A, ^E, left and right arrow keys to move through command buffer. Other options are described in README.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: command_history_and_edit.patch.tar.gz
Type: application/x-gzip
Size: 3869 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050927/f2a0241f/attachment.bin

#2 lore raw

PATCH 1/1 Command history and Command buffer editing

In reply to J Mac

James -
I applied this patch when you first sent it out to my local development sources
and had no problems. I really like the added functionality.

I would definitely vote for adding it.

A suggestion: How about modifying things so that only unique commands get added
to the history? In other words, if I type 'printenv' two consecutive times,
only add the command once to the history buffer.

Keith

Quoted 1 line

I made this patch using 'diff' on two source trees; I got the original

copies

Quoted 2 lines

of the files from the gitweb interface at source.denx.net. I used the 'diff -purN OLD NEW' command as described in README to generate the

patch.

Quoted 11 lines

All code changes are local to common/main.c

Define CONFIG_COMMAND_HISTORY and/or CONFIG_COMMAND_EDIT to enable the behaviour(s).

Please let me know if there is something I need to do to make the patch acceptable.

* Patch by James MacAulay Sept 27, 2005
- Add a configuration option CONFIG_COMMAND_HISTORY to implement

command

Quoted 1 line

history. Uses up and down arrow keys to scroll through history.

Other

Quoted 3 lines

options are described in README.
- Add a configuration option CONFIG_COMMAND_EDIT to implement command buffer editing. Uses ^A, ^E, left and right arrow keys to move

through

Quoted 1 line

command buffer. Other options are described in README.