wifi: rtl8xxxu: Fix use after rcu_read_unlock in rtl8xxxu_bss_info_changed
PATCH v2 1/1 wifi: rtl8xxxu: Fix use after rcu_read_unlock in rtl8xxxu_bss_info_changed
Commit a8b5aef2cca1 ("wifi: rtl8xxxu: gen2: Enable 40 MHz channel width") introduced a line where the pointer returned by ieee80211_find_sta() is used after rcu_read_unlock().
Move rcu_read_unlock() a bit lower to fix this.
---
v2:
- Adjust the commit message.
--- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +1 -1
@@ -4645,7 +4645,6 @@ rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif,if (sta->deflink.ht_cap.cap & (IEEE80211_HT_CAP_SGI_40 |IEEE80211_HT_CAP_SGI_20 )) sgi =1 ; -rcu_read_unlock (); highest_rate =fls (ramask) -1 ;if (highest_rate <DESC_RATE_MCS0 ) {
@@ -4670,6 +4669,7 @@ rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif,else rarpt->txrate.bw =RATE_INFO_BW_20 ; } +rcu_read_unlock (); bit_rate =cfg80211_calculate_bitrate (&rarpt->txrate); rarpt->bit_rate = bit_rate; rarpt->desc_rate = highest_rate;
Signature · 1 line
2.38.0
Quoted 8 lines
-----Original Message-----
From: Bitterblue Smith <[email protected]>
Sent: Tuesday, November 22, 2022 4:57 AM
To: [email protected]
Cc: Jes Sorensen <[email protected]>; Ping-Ke Shih <[email protected]>
Subject: [PATCH v2] wifi: rtl8xxxu: Fix use afterrcu_read_unlockinrtl8xxxu_bss_info_changed
Quoted 8 lines
Commit
a8b5aef2cca1("wifi: rtl8xxxu: gen2: Enable 40 MHz channel width") introduced a line where the pointer returned byieee80211_find_sta()is used afterrcu_read_unlock().Move
rcu_read_unlock()a bit lower to fix this.Fixes a8b5aef2cca1 ("wifi: rtl8xxxu: gen2: Enable 40 MHz channel width")Signed-off-by Bitterblue Smith <[email protected]>
Quoted 32 lines
---
v2:
- Adjust the commit message.--- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +1
-2@@ -4645,7 +4645,6 @@ rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif,if (sta->deflink.ht_cap.cap & (IEEE80211_HT_CAP_SGI_40 |IEEE80211_HT_CAP_SGI_20 )) sgi =1 ; -rcu_read_unlock (); highest_rate =fls (ramask) -1 ;if (highest_rate <DESC_RATE_MCS0 ) {@@ -4670,6 +4669,7 @@ rtl8xxxu_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif,else rarpt->txrate.bw =RATE_INFO_BW_20 ; } +rcu_read_unlock (); bit_rate =cfg80211_calculate_bitrate (&rarpt->txrate); rarpt->bit_rate = bit_rate; rarpt->desc_rate = highest_rate; --2.38.0
------Please consider the environment before printing this e-mail.
Quoted 9 lines · Bitterblue Smith
Commit
a8b5aef2cca1("wifi: rtl8xxxu: gen2: Enable 40 MHz channel width") introduced a line where the pointer returned byieee80211_find_sta()is used afterrcu_read_unlock().Move
rcu_read_unlock()a bit lower to fix this.Fixes a8b5aef2cca1 ("wifi: rtl8xxxu: gen2: Enable 40 MHz channel width")Signed-off-by Bitterblue Smith <[email protected]>Reviewed-by Ping-Ke Shih <[email protected]>
Patch applied to wireless-next.git, thanks.
7927afb5e27b wifi: rtl8xxxu: Fix use after rcu_read_unlock in rtl8xxxu_bss_info_changed
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches