Skip to contentSkip to conversation

Fixes for gcc 3.3

PATCH In review Andrew Church 2 participants 2 messages May 18, 2003

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fixes for gcc 3.3

[Note: I am not subscribed to the list; please CC: me on responses.]

The following is a short set of modifications I had to make to the
2.4.20 source to get it to compile under gcc 3.3. There may be more; these are just the ones that showed up under my configuration. If anyone is working on (or planning to work on) kernel/gcc-3.3 compatibility issues, feel free to use this as a starting point.

--Andrew Church

    [email protected]
    http://achurch.org/

---------------------------------------------------------------------------

drivers/ide/ide-cd.h +1 -1
@@ -437,7 +437,7 @@
 
 	byte     curlba[3];
 	byte     nslots;
-	__u8 short slot_tablelen;
+	__u8     slot_tablelen;
 };
 
 
drivers/scsi/aic7xxx/aic7xxx_osm.c +19 -19
@@ -417,25 +417,25 @@
 MODULE_LICENSE("Dual BSD/GPL");
 #endif
 MODULE_PARM(aic7xxx, "s");
-MODULE_PARM_DESC(aic7xxx, "period delimited, options string.
-	verbose			Enable verbose/diagnostic logging
-	no_probe		Disable EISA/VLB controller probing
-	no_reset		Supress initial bus resets
-	extended		Enable extended geometry on all controllers
-	periodic_otag		Send an ordered tagged transaction periodically
-				to prevent tag starvation.  This may be
-				required by some older disk drives/RAID arrays. 
-	reverse_scan		Sort PCI devices highest Bus/Slot to lowest
-	tag_info:<tag_str>	Set per-target tag depth
-	seltime:<int>		Selection Timeout(0/256ms,1/128ms,2/64ms,3/32ms)
-
-	Sample /etc/modules.conf line:
-		Enable verbose logging
-		Disable EISA/VLB probing
-		Set tag depth on Controller 2/Target 2 to 10 tags
-		Shorten the selection timeout to 128ms from its default of 256
-
-	options aic7xxx='\"verbose.no_probe.tag_info:{{}.{}.{..10}}.seltime:1\"'
+MODULE_PARM_DESC(aic7xxx, "period delimited, options string.\n\
+	verbose			Enable verbose/diagnostic logging\n\
+	no_probe		Disable EISA/VLB controller probing\n\
+	no_reset		Supress initial bus resets\n\
+	extended		Enable extended geometry on all controllers\n\
+	periodic_otag		Send an ordered tagged transaction periodically\n\
+				to prevent tag starvation.  This may be\n\
+				required by some older disk drives/RAID arrays. \n\
+	reverse_scan		Sort PCI devices highest Bus/Slot to lowest\n\
+	tag_info:<tag_str>	Set per-target tag depth\n\
+	seltime:<int>		Selection Timeout(0/256ms,1/128ms,2/64ms,3/32ms)\n\
+\n\
+	Sample /etc/modules.conf line:\n\
+		Enable verbose logging\n\
+		Disable EISA/VLB probing\n\
+		Set tag depth on Controller 2/Target 2 to 10 tags\n\
+		Shorten the selection timeout to 128ms from its default of 256\n\
+\n\
+	options aic7xxx='\"verbose.no_probe.tag_info:{{}.{}.{..10}}.seltime:1\"'\n\
 ");
 #endif
 
net/core/rtnetlink.c +1 -1
@@ -394,7 +394,7 @@
  * Malformed skbs with wrong lengths of messages are discarded silently.
  */
 
-extern __inline__ int rtnetlink_rcv_skb(struct sk_buff *skb)
+__inline__ int rtnetlink_rcv_skb(struct sk_buff *skb)
 {
 	int err;
 	struct nlmsghdr * nlh;
#1 lore raw

drivers/ide/ide-cd.h line 441

Quoted 12 lines · [email protected] (Andrew Church) writes:

The following is a short set of modifications I had to make to the
2.4.20 source to get it to compile under gcc 3.3.

drivers/ide/ide-cd.h +1 -1
@@ -437,7 +437,7 @@
 
 	byte     curlba[3];
 	byte     nslots;
-	__u8 short slot_tablelen;
+	__u8     slot_tablelen;
 };

Please check out the 2.5 source whether things are fixed there already, and maybe differently. This for example should really be __u16.

Signature · 1 line
	Falk