pull request to the u-boot-aspeed
Hello everybody,
I would like to publish for review and discussion our implementation of the aspeed i2c driver and the VPD parser for the u-boot-aspeed, but the gerrit said that it have no such repository.
Which the best way to do that?
--
Regards,
Alexander Filippov
Software Engineer, YADRO.
Hi Alexander,
The process for u-boot changes is similar to kernel changes which is documented@ https://github.com/openbmc/docs/blob/master/kernel-development.md. I believe it does not involve gerrit which is for core OpenBMC userland feature development.
Attached is an example submission for a uboot change (first one of 17 patches). Hope this helps!
-Sai.
On 11/6/18, 11:33 PM, "openbmc on behalf of Alexander A. Filippov" <[email protected] on behalf of [email protected]> wrote:
Hello everybody,
I would like to publish for review and discussion our implementation of the aspeed i2c driver and the VPD parser for the u-boot-aspeed, but the gerrit said that it have no such repository.
Which the best way to do that?
--
Regards,
Alexander Filippov
Software Engineer, YADRO.
This series expands support for Aspeed AST2500 SoC, commonly used as Board Management Controller in many servers, to the point where it can actually be useful.
The main goal of this series is I2C and Network drivers, the rest are either cleanups or supporting patches. Most notable among them is addition of Watchdog Uclass, so that watchdog drivers can now use Driver Model.
One notable thing that is *missing* from this series is Device Tree configuration for I2C driver. The Linux Kernel I2C driver is still under review and it may affect the details of how devices need to be configured in the Device Tree. So, I decided to wait until it will show up in Linux Kernel DT and then pull it into U-Boot.
Maxim Sloyko (17):
aspeed: Update ast2500 Device Tree
dm: Simple Watchdog uclass
aspeed: Watchdog Timer Driver
aspeed: Make SCU lock/unlock functions part of SCU API
aspeed: Reset Driver
aspeed: Device Tree configuration for Reset Driver
aspeed: Refactor AST2500 RAM Driver and Sysreset Driver
aspeed: AST2500 Pinctrl Driver
aspeed: Enable Pinctrl Driver in AST2500 EVB
aspeed: Add P-Bus clock in ast2500 clock driver
aspeed: Add I2C Driver
aspeed: Enable I2C in EVB defconfig
aspeed: Add support for Clocks needed by MACs
aspeed: Refactor SCU to use consistent mask & shift
aspeed: Cleanup ast2500-u-boot.dtsi Device Tree
aspeed: Add AST2500/AST2400 compatible NIC Driver
aspeed: Network Driver configuration for EVB
arch/arm/dts/ast2500-evb.dts | 29 + arch/arm/dts/ast2500-u-boot.dtsi | 59 +- arch/arm/dts/ast2500.dtsi | 881 ++++++++++++++++++++++++- arch/arm/include/asm/arch-aspeed/pinctrl.h | 52 ++ arch/arm/include/asm/arch-aspeed/scu_ast2500.h | 132 +++- arch/arm/include/asm/arch-aspeed/wdt.h | 38 +- arch/arm/mach-aspeed/Kconfig | 8 +- arch/arm/mach-aspeed/ast2500/clk_ast2500.c | 15 + arch/arm/mach-aspeed/ast2500/sdram_ast2500.c | 17 +- arch/arm/mach-aspeed/ast_wdt.c | 47 +- configs/evb-ast2500_defconfig | 13 + drivers/clk/aspeed/clk_ast2500.c | 321 +++++++-- drivers/i2c/Kconfig | 9 + drivers/i2c/Makefile | 1 + drivers/i2c/ast_i2c.c | 355 ++++++++++ drivers/i2c/ast_i2c.h | 132 ++++ drivers/net/Kconfig | 8 + drivers/net/Makefile | 1 + drivers/net/ast_nic.c | 584 ++++++++++++++++ drivers/net/ast_nic.h | 198 ++++++ drivers/pinctrl/Kconfig | 9 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/aspeed/Makefile | 1 + drivers/pinctrl/aspeed/pinctrl_ast2500.c | 127 ++++ drivers/reset/Kconfig | 10 + drivers/reset/Makefile | 1 + drivers/reset/ast2500-reset.c | 109 +++ drivers/sysreset/sysreset_ast.c | 24 +- drivers/watchdog/Kconfig | 24 + drivers/watchdog/Makefile | 2 + drivers/watchdog/ast_wdt.c | 125 ++++ drivers/watchdog/wdt-uclass.c | 79 +++ include/dm/uclass-id.h | 1 + include/dt-bindings/clock/ast2500-scu.h | 2 + include/dt-bindings/reset/ast2500-reset.h | 45 ++ include/wdt.h | 97 +++ 36 files changed, 3390 insertions(+), 167 deletions(-) create mode 100644 arch/arm/include/asm/arch-aspeed/pinctrl.h create mode 100644 drivers/i2c/ast_i2c.c create mode 100644 drivers/i2c/ast_i2c.h create mode 100644 drivers/net/ast_nic.c create mode 100644 drivers/net/ast_nic.h create mode 100644 drivers/pinctrl/aspeed/Makefile create mode 100644 drivers/pinctrl/aspeed/pinctrl_ast2500.c create mode 100644 drivers/reset/ast2500-reset.c create mode 100644 drivers/watchdog/ast_wdt.c create mode 100644 drivers/watchdog/wdt-uclass.c create mode 100644 include/dt-bindings/reset/ast2500-reset.h create mode 100644 include/wdt.h
Signature · 1 line
2.12.0.367.g23dc2f6d3c-goog
Quoted 3 lines · Sai Dasari
Hi Alexander,
The process for u-boot changes is similar to kernel changes which is documented@ https://github.com/openbmc/docs/blob/master/kernel-development.md. I believe it does not involve gerrit which is for core OpenBMC userland feature development.
Thank you Sai for sharing the link. I'm actually looking at below page for kernel patches: which one is up to date?
https://github.com/openbmc/linux/wiki/DevelopmentProcess
Thanks,
Tao Ren
Quoted 9 lines · Tao Ren
Quoted 3 lines · Sai Dasari
Hi Alexander,
The process for u-boot changes is similar to kernel changes which is documented@ https://github.com/openbmc/docs/blob/master/kernel-development.md. I believe it does not involve gerrit which is for core OpenBMC userland feature development.
Thank you Sai for sharing the link. I'm actually looking at below page for kernel patches: which one is up to date?
I've kept the wiki one more up to date as I find it has a lower barrier to entry when making edits and updates.
However, I think they are complimentary. If not, let me know where they contradict and we can unify the documentation.
Cheers,
Joel
Quoted 9 lines · Joel Stanley
Quoted 8 lines · Tao Ren
Quoted 3 lines · Sai Dasari
Hi Alexander,
The process for u-boot changes is similar to kernel changes which is documented@ https://github.com/openbmc/docs/blob/master/kernel-development.md. I believe it does not involve gerrit which is for core OpenBMC userland feature development.
Thank you Sai for sharing the link. I'm actually looking at below page for kernel patches: which one is up to date?
Quoted 7 lines
I've kept the wiki one more up to date as I find it has a lower barrier to entry when making edits and updates.
However, I think they are complimentary. If not, let me know where they contradict and we can unify the documentation.
Thanks Joel for the clarify. If you don't mind, I can move/combine all the kernel stuff to openbmc/linux/wiki/DevelopmentProcess and link the page in openbmc/docs/blob/master/kernel-development.md.
Thanks,
Tao Ren
Thanks to all for replies.
Quoted 5 lines · Joel Stanley
I'd encourage you to submit the i2c driver for review to upstream u-boot. Cedric and I have spent some time recently in improving upstream u-boot support for the aspeed SoCs.
The upstream already has the implementation of the aspeed i2c driver. So, I had to look there before taking up our implementation...
Quoted 5 lines · Cédric Le Goater
i2c is already available from mainline U-Boot. But mainline does not have ast2400 support (dram training is missing) only ast2500 was implemented.
Is it the reason why the OpenBMC still use v2016.07?
Thanks,
Alexander.
Quoted 14 lines · Alexander A. Filippov
Thanks to all for replies.
Quoted 5 lines · Joel Stanley
I'd encourage you to submit the i2c driver for review to upstream u-boot. Cedric and I have spent some time recently in improving upstream u-boot support for the aspeed SoCs.
The upstream already has the implementation of the aspeed i2c driver. So, I had to look there before taking up our implementation...
Quoted 8 lines
Quoted 5 lines · Cédric Le Goater
i2c is already available from mainline U-Boot. But mainline does not have ast2400 support (dram training is missing) only ast2500 was implemented.
Is it the reason why the OpenBMC still use v2016.07?
We haven't found time to work on upstreaming u-boot.
If you were to add support for the ast2400 we could move all platforms to the upstream tree instead. This would be preferable to maintaining our own fork.
Hello,
[ ... ]
Quoted 8 lines
Quoted 1 line
Is it the reason why the OpenBMC still use v2016.07?
We haven't found time to work on upstreaming u-boot.
If you were to add support for the ast2400 we could move all platforms to the upstream tree instead. This would be preferable to maintaining our own fork.
One (quick) way to move forward with the support of the Aspeed AST2400 SoC in mainline would be to use the lowlevel init routine of Aspeed.
It would give us the DRAM init which is rather complex to rewrite and we could use and/or extend the other drivers which are already merged in mainline. The SPI driver is still in my branch and NC-SI support is missing.
Cheers,
C.
Quoted 4 lines · Alexander A. Filippov
Hello everybody,
I would like to publish for review and discussion our implementation of the aspeed i2c driver and the VPD parser for the u-boot-aspeed, but the gerrit said that it have no such repository.
I'd encourage you to submit the i2c driver for review to upstream u-boot. Cedric and I have spent some time recently in improving upstream u-boot support for the aspeed SoCs.
Cheers,
Joel
Quoted 5 lines · Joel Stanley
Quoted 4 lines · Alexander A. Filippov
Hello everybody,
I would like to publish for review and discussion our implementation of the aspeed i2c driver and the VPD parser for the u-boot-aspeed, but the gerrit said that it have no such repository.
i2c is already available from mainline U-Boot. But mainline does not have ast2400 support (dram training is missing) only ast2500 was implemented.
Quoted 3 lines
I'd encourage you to submit the i2c driver for review to upstream u-boot. Cedric and I have spent some time recently in improving upstream u-boot support for the aspeed SoCs.
The ftgmac100 mac driver is now merged in -next, plus a couple of other fixes, an updated DT for instance.
I have implemented a SPI driver but it needs to be reworked to the latest best pratices using spi-mem.
You can use my Aspeed branch as a base
https://github.com/legoater/u-boot/
It boots an ast2500 evb.
Cheers,
C.