BusLogic update - take 2
This is my second pass through the BusLogic SCSI driver. It incorporates some comments received on the first version.
This patch is against linux-2.6.1. It works for me but the normal caveats apply.
Please retrieve (~150kb) from:
<http://home.globalcrossing.net/~doyle/buslogic.patch>
Deleted dead code:
- BusLogic_ReportTargetDeviceInfo()
- BusLogic_SelectQueueDepths()
- BusLogic_SendBusDeviceReset()
- BusLogic_ResetCommand()
Fixed:
- removed dependency on "scsi_obsolete.h"
o Changes to BusLogic_ResetHostAdapter()
o Changes to BusLogic_AbortCommand()
- removed the gratuitous typedefs per Christoph's comments
- several functions with incorrect __init and __exit sections.
- Removed vestiges of the 'Error Recovery' command line function (which is fundamentally incompatible with the new EH design).
Left to do:
- Test eh_abort_handler
- Test eh_host_reset_handler
- Test as module
- Straighten out FlashPoint conditional compile so it doesn't require #include "FlashPoint.c".
- Please ignore the long line length and the very lengthy identifiers (for now).
Bob.
What's this:?
+#ifndef FAILURE
+#define FAILURE (-1)
+#endif
else the patch looks okay to me
Quoted 7 lines · Christoph Hellwig
What's this:?
(quoted diff) +3
-0+#ifndef FAILURE +#define FAILURE (-1) +#endifelse the patch looks okay to me
The BusLogic.c code does a #include "FlashPoint.c" which conditionally defines FAILURE when CONFIG_SCSI_OMIT_FLASHPOINT is not defined...
Eventually I'd like to get rid of that stupid include, compile the BusLogic and FlashPoint drivers separately, and have the BusLogic module conditionally load FlashPoint module - or something.
I'm not sure I have the stomach to touch the FlashPoint code.
Bob.