Skip to contentSkip to conversation

mconsole log doesn't work correctly

PATCH In review Sven 'Darkman' Michels 2 participants 2 messages Jan 30, 2004 – Feb 13, 2004 User-mode Linux (UML)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mconsole log doesn't work correctly

Hi there,

a small patch for the mconsole_log function:
just add an \n at the end of every line cause otherwise sys/klogd won't notice the line (at least not immedially).

Regards,
Sven

arch/um/drivers/mconsole_kern.c +1 -1
@@ -116,7 +116,7 @@ void mconsole_log(struct mc_request *req
 	while(isspace(*ptr)) ptr++;
 
 	len = req->len - (ptr - req->request.data);
-	printk("%.*s", len, ptr);
+	printk("%.*s\n", len, ptr);
 	mconsole_reply(req, "", 0, 0);
 }
 
#1 lore raw
Quoted 3 lines · [email protected] said:

a small patch for the mconsole_log function: just add an \n at the end of every line cause otherwise sys/klogd won't notice the line (at least not immedially).

Fixed, in a slightly different way, thanks. This will require the next version of uml_mconsole as well, since I mostly fixed it there.

Jeff

-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel