writeback: __sync_single_inode() trivial cleanup
PATCH 1/1 writeback: __sync_single_inode() trivial cleanup
Make the if-else straight in __sync_single_inode(). No behavior change.
Cc Michael Rubin <[email protected]>
Cc Peter Zijlstra <[email protected]>
Signed-off-by Fengguang Wu <[email protected]>
--- fs/fs-writeback.c | 15 +++++++-------- 1 files changed, 7 insertions(+), 8 deletions(-)
fs/fs-writeback.c +7 -8
@@ -261,8 +261,13 @@ __sync_single_inode(struct inode *inode,spin_lock (&inode_lock); inode->i_state &= ~I_SYNC ;if (!(inode->i_state &I_FREEING )) { -if (!(inode->i_state &I_DIRTY ) && -mapping_tagged (mapping,PAGECACHE_TAG_DIRTY )) { +if (inode->i_state &I_DIRTY ) { +/* +* Someone redirtied the inode while were writing back +* the pages. +*/ +redirty_tail (inode); + }else if (mapping_tagged (mapping,PAGECACHE_TAG_DIRTY )) {/* * We didn't write back all the pages. nfs_writepages() * sometimes bales out without doing anything. Redirty
@@ -306,12 +311,6 @@ __sync_single_inode(struct inode *inode, inode->i_state |=I_DIRTY_PAGES ;redirty_tail (inode); } - }else if (inode->i_state &I_DIRTY ) { -/* -* Someone redirtied the inode while were writing back -* the pages. -*/ -redirty_tail (inode); }else if (atomic_read (&inode->i_count)) {/* * The inode is clean, inuse