Skip to contentSkip to conversation

2.6.3 Slab corruption: errors are triggered when memory exceeds 2.5GB (correction)

BUG Manfred Spraul 6 participants 15 messages Feb 24, 2004 – Feb 26, 2004 Networking

lore
Share & tools
lore
#0 lore raw

From your logs:

Quoted 7 lines
Feb 23 14:54:24 calypso kernel: Slab corruption: start=e00000017e84ea00, expend=e00000017e84f1ff, problemat=e00000017e84f020
Feb 23 14:54:24 calypso kernel: Last user: [<a0000001003c9f30>](kfree_skbmem+0x30/0x80)
Feb 23 14:54:24 calypso kernel: Data: *****************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************
Feb 23 14:54:28 calypso kernel: **************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************6A ******************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************
Feb 23 14:54:28 calypso kernel: ************************************************************A5 

"6a" instead of 0x6b. One bit is wrong, this is often an indication of a hardware problem. Do you use ECC memory and is ECC enabled in the BIOS?

--
Manfred

#1 lore raw
Quoted 6 lines · Manfred Spraul

From your logs:

Quoted 3 lines
Feb 23 14:54:24 calypso kernel: Slab corruption: start=e00000017e84ea00, expend=e00000017e84f1ff, problemat=e00000017e84f020
Feb 23 14:54:24 calypso kernel: Last user: [<a0000001003c9f30>](kfree_skbmem+0x30/0x80)
Feb 23 14:54:24 calypso kernel: Data: ************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************!

**!

Quoted 2 lines

***************************************

Quoted 1 line
Feb 23 14:54:28 calypso kernel: **************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************6A *************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************!

**!

Quoted 6 lines

***************************************

Quoted 3 lines
Feb 23 14:54:28 calypso kernel: ************************************************************A5 

"6a" instead of 0x6b. One bit is wrong, this is often an indication of a hardware problem. Do you use ECC memory and is ECC enabled in the BIOS?

Actually, it's often caused by someone doing atomic_dec_and_test() against something which was already freed. Or spin_lock(). One would need to work out what field is at that offset. If it is an atomic_t or a spinlock_t, there you are.

#2 lore raw

Yes the machine is using ECC though I will need to confirm tommorrow that it is enabled, from memory it is. I am currently running memtest over the memory however it is limited to testing 2GB because it uses malloc, so this is not a reliable test.
I will continue to swap the memory modules to see if I can find a failed module.

If this fails to help I will then look for the offending atomic_t or spinlock_t.

Thanks for the replies
Darren

Quoted 24 lines · Andrew Morton
Quoted 6 lines · Manfred Spraul

From your logs:

Quoted 3 lines
Feb 23 14:54:24 calypso kernel: Slab corruption: start=e00000017e84ea00, expend=e00000017e84f1ff, problemat=e00000017e84f020
Feb 23 14:54:24 calypso kernel: Last user: [<a0000001003c9f30>](kfree_skbmem+0x30/0x80)
Feb 23 14:54:24 calypso kernel: Data: ************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************!

**!

Quoted 2 lines

***************************************

Quoted 1 line
Feb 23 14:54:28 calypso kernel: **************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************6A *************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************!

**!

Quoted 6 lines

***************************************

Quoted 3 lines
Feb 23 14:54:28 calypso kernel: ************************************************************A5 

"6a" instead of 0x6b. One bit is wrong, this is often an indication of a hardware problem. Do you use ECC memory and is ECC enabled in the BIOS?

Actually, it's often caused by someone doing atomic_dec_and_test() against something which was already freed. Or spin_lock(). One would need to work out what field is at that offset. If it is an atomic_t or a spinlock_t, there you are.

Quoted 5 lines

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

--------------------------------------------------
Darren Williams <dsw AT gelato.unsw.edu.au>
Gelato@UNSW <www.gelato.unsw.edu.au>
--------------------------------------------------

#3 lore raw
In reply to Andrew Morton
Quoted 3 lines · Andrew Morton

Actually, it's often caused by someone doing atomic_dec_and_test() against something which was already freed.

The previous user is always kfree_skbmem - I would be surprised if there are atomic operations against the skb data area.

Darren, could you try the latest bk snapshot? Linus yesterday merged a patch that hexdumps the affected bytes. We must try to find a pattern - always same offset into a page, always same physical address, always same offset into the object, etc.

--
Manfred

#4 lore raw

Hi Manfred

I have updated to the latest bk and new output can be found at:
http://quasar.cse.unsw.edu.au/~dsw/public-files/lemon-debug/
kern-log-bk

Also I am quite confident that it is not a hardware problem.

I took a look at alloc_skb(..) and there is a reference to an atomic_t token with this being the most suspect

150> atomic_set(&(skb_shinfo(skb)->dataref), 1);

Not sure though.

Darren

Quoted 13 lines · Manfred Spraul
Quoted 3 lines · Andrew Morton

Actually, it's often caused by someone doing atomic_dec_and_test() against something which was already freed.

The previous user is always kfree_skbmem - I would be surprised if there are atomic operations against the skb data area.

Darren, could you try the latest bk snapshot? Linus yesterday merged a patch that hexdumps the affected bytes. We must try to find a pattern - always same offset into a page, always same physical address, always same offset into the object, etc.

Quoted 8 lines

--
Manfred

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

--------------------------------------------------
Darren Williams <dsw AT gelato.unsw.edu.au>
Gelato@UNSW <www.gelato.unsw.edu.au>
--------------------------------------------------

#14 lore raw
In reply to Andrew Morton

Looking at the stack trace when transfering data to the Itanium box the eepro100 driver seems to be producing the slab errors.

To check this I swapped over to the Intel e100 driver and the slab errors have ceased.

A quick look at eepro100.c shows that it takes a lock in speedo_interrupt(..)

Then the callgraph looks something like this.

speedo_interrupt(..)

        |->speedo_rx(..)
            |->speedo_refill_rx_buffers(..)
                |->speedo_rx_alloc(..)
                   |->dev_alloc_skb(..)
                        |->alloc_skb(..)

Though I do not think the lock is held when alloc_skb(..) is called?

Andrey you would know more about what is going on in the eepro100 driver any comments.

I have posted the latest logs at:
http://quasar.cse.unsw.edu.au/~dsw/public-files/lemon-debug/

the file *-xffUL are the equivilent debug files.

Included here is also some disassembled code that may help

I found the back trace of the new slab error code limited debugging since earlier we were able to see the trace from the network code also.

Darren

Quoted 24 lines · Andrew Morton
Quoted 6 lines · Manfred Spraul

From your logs:

Quoted 3 lines
Feb 23 14:54:24 calypso kernel: Slab corruption: start=e00000017e84ea00, expend=e00000017e84f1ff, problemat=e00000017e84f020
Feb 23 14:54:24 calypso kernel: Last user: [<a0000001003c9f30>](kfree_skbmem+0x30/0x80)
Feb 23 14:54:24 calypso kernel: Data: ************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************!

**!

Quoted 2 lines

***************************************

Quoted 1 line
Feb 23 14:54:28 calypso kernel: **************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************6A *************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************!

**!

Quoted 6 lines

***************************************

Quoted 3 lines
Feb 23 14:54:28 calypso kernel: ************************************************************A5 

"6a" instead of 0x6b. One bit is wrong, this is often an indication of a hardware problem. Do you use ECC memory and is ECC enabled in the BIOS?

Actually, it's often caused by someone doing atomic_dec_and_test() against something which was already freed. Or spin_lock(). One would need to work out what field is at that offset. If it is an atomic_t or a spinlock_t, there you are.

Quoted 5 lines

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

--------------------------------------------------
Darren Williams <dsw AT gelato.unsw.edu.au>
Gelato@UNSW <www.gelato.unsw.edu.au>
--------------------------------------------------

#6 lore raw
In reply to Darren Williams
Quoted 6 lines · Darren Williams

Hi Manfred

I have updated to the latest bk and new output can be found at:
http://quasar.cse.unsw.edu.au/~dsw/public-files/lemon-debug/
kern-log-bk

Quoted 8 lines

Also I am quite confident that it is not a hardware problem.

I took a look at alloc_skb(..) and there is a reference to an atomic_t token with this being the most suspect

150> atomic_set(&(skb_shinfo(skb)->dataref), 1);

I don't think so:
The allocation that generates the error is skb->head: The cache name is "size-2048", thus the allocation is a kmalloc(1000-2000, probably 1536 for one eth frame). The skb itself is allocated from the skbuff_head_cache.

I don't see a pattern in the virtual addresses:
start=e000000101ee09a0, len=2048 start=e000000101ee09a0, len=2048 start=e000000101ee11b8, len=2048 start=e000000101ee19d0, len=2048 start=e000000101ee3218, len=2048 start=e00000017eed1b90, len=2048 start=e00000017eed23a8, len=2048 start=e00000017eed2bc0, len=2048 start=e00000017eed4308, len=2048 start=e00000017eed5338, len=2048 start=e00000017eed5338, len=2048 start=e00000017eed5b50, len=2048 start=e00000017eed5b50, len=2048 start=e00000017eed6b80, len=2048 start=e00000017eed82c8, len=2048 start=e00000017eedc288, len=2048 start=e00000017eedcaa0, len=2048 start=e00000017eeddad0, len=2048 start=e00000017eede2e8, len=2048 start=e00000017eedeb00, len=2048 start=e00000017ef60a60, len=2048 start=e00000017ef61a90, len=2048 start=e00000017ef622a8, len=2048 start=e00000017ef62ac0, len=2048 start=e00000017ef632d8, len=2048 start=e00000017ef65a50, len=2048 start=e00000017ef65a50, len=2048 start=e00000017ef65a50, len=2048 start=e00000017ef66a80, len=2048

That virtually rules out a bad memory chip.

But the corrupted byte is always at offset 0x620 into the allocation:
Slab corruption: start=e00000017ef65a50, len=2048
620: 6a 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b
--
Slab corruption: start=e000000101ee19d0, len=2048
620: 6a 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b
--
Slab corruption: start=e000000101ee3218, len=2048
620: 6a 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b
--
Slab corruption: start=e00000017ef66a80, len=2048
620: 6a 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b
--
Slab corruption: start=e000000101ee11b8, len=2048
620: 6a 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b

0x620 (1568) is behind the end of the actual eth frame. Who could modify that?

Darren, which nic do you use? Could you try what happens if you reduce the MTU?

--
Manfred

#7 lore raw
Quoted 2 lines · On Wed, 25 Feb 2004 07:21:56 +0100 Manfred Spraul <[email protected]>…

0x620 (1568) is behind the end of the actual eth frame. Who could modify that?

At the end of the SKB data area is where we keep struct skb_shared_info, something is messing with the SKB state after a free it appears.

And since it's turning the debugging value 0x6b to 0x6a it must be the "atomic_t dataref;" that is being mucked with.

#8 lore raw
Quoted 4 lines · David S. Miller

On Wed, 25 Feb 2004 07:21:56 +0100
Manfred Spraul <[email protected]> wrote:

Quoted 8 lines
Quoted 2 lines

0x620 (1568) is behind the end of the actual eth frame. Who could modify that?

At the end of the SKB data area is where we keep struct skb_shared_info, something is messing with the SKB state after a free it appears.

And since it's turning the debugging value 0x6b to 0x6a it must be the "atomic_t dataref;" that is being mucked with.

Ah-hah.

This should find it:

 25-akpm/include/linux/skbuff.h |    1 +
 25-akpm/net/core/dev.c         |    1 +
 25-akpm/net/core/skbuff.c      |    6 ++++++
 3 files changed, 8 insertions(+)
include/linux/skbuff.h renamed from include/linux/skbuff.h~dataref-debug +1 -0
diff -puN include/linux/skbuff.h~dataref-debug include/linux/skbuff.h
@@ -140,6 +140,7 @@ struct skb_frag_struct {
  */
 struct skb_shared_info {
 	atomic_t	dataref;
+	int		debug;
 	unsigned int	nr_frags;
 	unsigned short	tso_size;
 	unsigned short	tso_segs;
net/core/dev.c renamed from net/core/dev.c~dataref-debug +1 -0
diff -puN net/core/dev.c~dataref-debug net/core/dev.c
@@ -1272,6 +1272,7 @@ int __skb_linearize(struct sk_buff *skb,
 	/* Set up shinfo */
 	ninfo = (struct skb_shared_info*)(data + size);
 	atomic_set(&ninfo->dataref, 1);
+	ninfo->debug = 0;
 	ninfo->tso_size = skb_shinfo(skb)->tso_size;
 	ninfo->tso_segs = skb_shinfo(skb)->tso_segs;
 	ninfo->nr_frags = 0;
net/core/skbuff.c renamed from net/core/skbuff.c~dataref-debug +6 -0
diff -puN net/core/skbuff.c~dataref-debug net/core/skbuff.c
@@ -148,6 +148,7 @@ struct sk_buff *alloc_skb(unsigned int s
 	skb->end  = data + size;
 
 	atomic_set(&(skb_shinfo(skb)->dataref), 1);
+	skb_shinfo(skb)->debug  = 0;
 	skb_shinfo(skb)->nr_frags  = 0;
 	skb_shinfo(skb)->tso_size = 0;
 	skb_shinfo(skb)->tso_segs = 0;
@@ -184,6 +185,9 @@ static void skb_clone_fraglist(struct sk
 
 void skb_release_data(struct sk_buff *skb)
 {
+	if (!skb->cloned)
+		WARN_ON(skb_shinfo(skb)->debug != 0);
+
 	if (!skb->cloned ||
 	    atomic_dec_and_test(&(skb_shinfo(skb)->dataref))) {
 		if (skb_shinfo(skb)->nr_frags) {
@@ -320,6 +324,7 @@ struct sk_buff *skb_clone(struct sk_buff
 	C(tail);
 	C(end);
 
+	WARN_ON(skb_shinfo(skb)->debug != 0);
 	atomic_inc(&(skb_shinfo(skb)->dataref));
 	skb->cloned = 1;
 
@@ -526,6 +531,7 @@ int pskb_expand_head(struct sk_buff *skb
 	skb->h.raw   += off;
 	skb->nh.raw  += off;
 	skb->cloned   = 0;
+	skb_shinfo(skb)->debug = 0;
 	atomic_set(&skb_shinfo(skb)->dataref, 1);
 	return 0;
 

_

#9 lore raw

OK the patch is applied and the results are at:
http://quasar.cse.unsw.edu.au/~dsw/public-files/lemon-debug/
*-latest-skb

Darren

Quoted 84 lines · Andrew Morton
Quoted 4 lines · David S. Miller

On Wed, 25 Feb 2004 07:21:56 +0100
Manfred Spraul <[email protected]> wrote:

Quoted 8 lines
Quoted 2 lines

0x620 (1568) is behind the end of the actual eth frame. Who could modify that?

At the end of the SKB data area is where we keep struct skb_shared_info, something is messing with the SKB state after a free it appears.

And since it's turning the debugging value 0x6b to 0x6a it must be the "atomic_t dataref;" that is being mucked with.

Ah-hah.

This should find it:

 25-akpm/include/linux/skbuff.h |    1 +
 25-akpm/net/core/dev.c         |    1 +
 25-akpm/net/core/skbuff.c      |    6 ++++++
 3 files changed, 8 insertions(+)

diff -puN include/linux/skbuff.h~dataref-debug include/linux/skbuff.h

include/linux/skbuff.h renamed from include/linux/skbuff.h~dataref-debug +1 -0
@@ -140,6 +140,7 @@ struct skb_frag_struct {
  */
 struct skb_shared_info {
 	atomic_t	dataref;
+	int		debug;
 	unsigned int	nr_frags;
 	unsigned short	tso_size;
 	unsigned short	tso_segs;

diff -puN net/core/dev.c~dataref-debug net/core/dev.c

net/core/dev.c renamed from net/core/dev.c~dataref-debug +1 -0
@@ -1272,6 +1272,7 @@ int __skb_linearize(struct sk_buff *skb,
 	/* Set up shinfo */
 	ninfo = (struct skb_shared_info*)(data + size);
 	atomic_set(&ninfo->dataref, 1);
+	ninfo->debug = 0;
 	ninfo->tso_size = skb_shinfo(skb)->tso_size;
 	ninfo->tso_segs = skb_shinfo(skb)->tso_segs;
 	ninfo->nr_frags = 0;

diff -puN net/core/skbuff.c~dataref-debug net/core/skbuff.c

net/core/skbuff.c renamed from net/core/skbuff.c~dataref-debug +6 -0
@@ -148,6 +148,7 @@ struct sk_buff *alloc_skb(unsigned int s
 	skb->end  = data + size;
 
 	atomic_set(&(skb_shinfo(skb)->dataref), 1);
+	skb_shinfo(skb)->debug  = 0;
 	skb_shinfo(skb)->nr_frags  = 0;
 	skb_shinfo(skb)->tso_size = 0;
 	skb_shinfo(skb)->tso_segs = 0;
@@ -184,6 +185,9 @@ static void skb_clone_fraglist(struct sk
 
 void skb_release_data(struct sk_buff *skb)
 {
+	if (!skb->cloned)
+		WARN_ON(skb_shinfo(skb)->debug != 0);
+
 	if (!skb->cloned ||
 	    atomic_dec_and_test(&(skb_shinfo(skb)->dataref))) {
 		if (skb_shinfo(skb)->nr_frags) {
@@ -320,6 +324,7 @@ struct sk_buff *skb_clone(struct sk_buff
 	C(tail);
 	C(end);
 
+	WARN_ON(skb_shinfo(skb)->debug != 0);
 	atomic_inc(&(skb_shinfo(skb)->dataref));
 	skb->cloned = 1;
 
@@ -526,6 +531,7 @@ int pskb_expand_head(struct sk_buff *skb
 	skb->h.raw   += off;
 	skb->nh.raw  += off;
 	skb->cloned   = 0;
+	skb_shinfo(skb)->debug = 0;
 	atomic_set(&skb_shinfo(skb)->dataref, 1);
 	return 0;
 
Quoted 7 lines

_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

--------------------------------------------------
Darren Williams <dsw AT gelato.unsw.edu.au>
Gelato@UNSW <www.gelato.unsw.edu.au>
--------------------------------------------------

#12 lore raw
In reply to Manfred Spraul

Hi Manfred

The nic is Intel e100pro onboard card. Interestingly the following allocation that has caught my attention is this:

static inline struct RxFD *speedo_rx_alloc(struct net_device *dev, int entry)

{
	struct speedo_private *sp = (struct speedo_private *)dev->priv;
	struct RxFD *rxf;
	struct sk_buff *skb;
	/* Get a fresh skbuff to replace the consumed one. */
	skb = dev_alloc_skb(PKT_BUF_SZ + sizeof(struct RxFD));

This allocation on ia64 is 1500 bytes, and as I have explained in later e-mails when I use the Intel e100 driver the slab corruption goes away.

So I am guessing that it may be in the eepro100 driver.

Darren

Quoted 76 lines · Manfred Spraul
Quoted 6 lines · Darren Williams

Hi Manfred

I have updated to the latest bk and new output can be found at:
http://quasar.cse.unsw.edu.au/~dsw/public-files/lemon-debug/
kern-log-bk

Quoted 8 lines

Also I am quite confident that it is not a hardware problem.

I took a look at alloc_skb(..) and there is a reference to an atomic_t token with this being the most suspect

150> atomic_set(&(skb_shinfo(skb)->dataref), 1);

I don't think so:
The allocation that generates the error is skb->head: The cache name is "size-2048", thus the allocation is a kmalloc(1000-2000, probably 1536 for one eth frame). The skb itself is allocated from the skbuff_head_cache.

I don't see a pattern in the virtual addresses:
start=e000000101ee09a0, len=2048
start=e000000101ee09a0, len=2048
start=e000000101ee11b8, len=2048
start=e000000101ee19d0, len=2048
start=e000000101ee3218, len=2048
start=e00000017eed1b90, len=2048
start=e00000017eed23a8, len=2048
start=e00000017eed2bc0, len=2048
start=e00000017eed4308, len=2048
start=e00000017eed5338, len=2048
start=e00000017eed5338, len=2048
start=e00000017eed5b50, len=2048
start=e00000017eed5b50, len=2048
start=e00000017eed6b80, len=2048
start=e00000017eed82c8, len=2048
start=e00000017eedc288, len=2048
start=e00000017eedcaa0, len=2048
start=e00000017eeddad0, len=2048
start=e00000017eede2e8, len=2048
start=e00000017eedeb00, len=2048
start=e00000017ef60a60, len=2048
start=e00000017ef61a90, len=2048
start=e00000017ef622a8, len=2048
start=e00000017ef62ac0, len=2048
start=e00000017ef632d8, len=2048
start=e00000017ef65a50, len=2048
start=e00000017ef65a50, len=2048
start=e00000017ef65a50, len=2048
start=e00000017ef66a80, len=2048

That virtually rules out a bad memory chip.

But the corrupted byte is always at offset 0x620 into the allocation:
Slab corruption: start=e00000017ef65a50, len=2048
620: 6a 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b
--
Slab corruption: start=e000000101ee19d0, len=2048
620: 6a 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b
--
Slab corruption: start=e000000101ee3218, len=2048
620: 6a 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b
--
Slab corruption: start=e00000017ef66a80, len=2048
620: 6a 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b
--
Slab corruption: start=e000000101ee11b8, len=2048
620: 6a 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b

0x620 (1568) is behind the end of the actual eth frame. Who could modify that?

Darren, which nic do you use? Could you try what happens if you reduce the MTU?

Quoted 8 lines

--
Manfred

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

--------------------------------------------------
Darren Williams <dsw AT gelato.unsw.edu.au>
Gelato@UNSW <www.gelato.unsw.edu.au>
--------------------------------------------------

#13 lore raw
In reply to Darren Williams
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Darren" == Darren Williams <[email protected]> writes:

Darren> Hi Manfred I have updated to the latest bk and new output can Darren> be found at:
Darren> http://quasar.cse.unsw.edu.au/~dsw/public-files/lemon-debug/
Darren> kern-log-bk

Intersting. Offset 0x620 is well off the end of the struct skb, which is only 256 bytes big (I think), yet the object that's having problems is a 2k object.

Darren> I took a look at alloc_skb(..) and there is a reference to an Darren> atomic_t token with this being the most suspect

150> atomic_set(&(skb_shinfo(skb)->dataref), 1);

No, the skb_shinfo is off in kmalloced space, not part of the slab.

--
Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au The technical we do immediately, the political takes *forever*

#10 lore raw
In reply to Andrew Morton
Quoted 5 lines · Andrew Morton

Ah-hah.

This should find it:

I think we should first check that skb->dataref is really the problem: what about adding an unused field before the dataref? Something like

struct skb_shared_info {

+	int		unused;
	atomic_t	dataref;
	int		debug;

If the dataref decrease causes the problem, then the affected offset should change to 0x628.

--
Manfred

#11 lore raw

Hi Manfred

With the introduction of the unused int the slab corruption errors are not present.

Darren

Quoted 22 lines · Manfred Spraul
Quoted 5 lines · Andrew Morton

Ah-hah.

This should find it:

I think we should first check that skb->dataref is really the problem:
what about adding an unused field before the dataref? Something like

struct skb_shared_info {

(quoted diff) +1 -0
+	int		unused;
	atomic_t	dataref;
	int		debug;

If the dataref decrease causes the problem, then the affected offset should change to 0x628.

--
Manfred

Quoted 5 lines

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

--------------------------------------------------
Darren Williams <dsw AT gelato.unsw.edu.au>
Gelato@UNSW <www.gelato.unsw.edu.au>
--------------------------------------------------