SGI 910137: fsid export option broken in 2.6
Subsystems (2)
PATCH 1/1 SGI 910137: fsid export option broken in 2.6
G'day,
This patch against 2.6.3 fixes a bug where the fsid= export option is ignored if the export point is on a device with an old dev_t.
fs/nfsd/nfsfh.c +3 -0
@@ -344,6 +344,9 @@ fh_compose(struct svc_fh *fhp, struct sv ref_fh_fsid_type = ref_fh->fh_handle.fh_fsid_type;if (!(exp->ex_flags &NFSEXP_FSID ) || ref_fh_fsid_type ==2 ) ref_fh_fsid_type =0 ; + }else if (exp->ex_flags &NFSEXP_FSID ) { + ref_fh_version =1 ; + ref_fh_fsid_type =1 ; }if (ref_fh == fhp)fh_put (ref_fh);
Greg.
Signature · 12 lines
Greg Banks, R&D Software Engineer, SGI Australian Software Group. I don't speak for SGI. ------------------------------------------------------- SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now! http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click _______________________________________________ NFS maillist - [email protected] https://lists.sourceforge.net/lists/listinfo/nfs
Quoted 10 lines · On Friday February 27, [email protected] wrote:
G'day,
This patch against 2.6.3 fixes a bug where the fsid= export option is ignored if the export point is on a device with an old
dev_t.
fs/nfsd/nfsfh.c fh_compose(struct svc_fh *fhp, struct sv · line 352
Quoted 9 lines
fs/nfsd/nfsfh.c +3
-0@@ -344,6 +344,9 @@ fh_compose(struct svc_fh *fhp, struct sv ref_fh_fsid_type = ref_fh->fh_handle.fh_fsid_type;if (!(exp->ex_flags &NFSEXP_FSID ) || ref_fh_fsid_type ==2 ) ref_fh_fsid_type =0 ; + }else if (exp->ex_flags &NFSEXP_FSID ) { + ref_fh_version =1 ; + ref_fh_fsid_type =1 ; }if (ref_fh == fhp)fh_put (ref_fh);
WHAT!!! Where did all this fsid_type==2 stuff come from.... Al Viro it would appear.
I don't like it at all!
I'll look into it and fix it all up early next week.
Thanks for pointing it out to me.
NeilBrown
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
Quoted 3 lines · Neil Brown
WHAT!!! Where did all this fsid_type==2 stuff come from.... Al Viro it would appear.
Yes.
Quoted 1 line
I don't like it at all!
Oh. I was thinking of writing an Ethereal disector for it. Guess I won't now.
Greg.
Signature · 12 lines
Greg Banks, R&D Software Engineer, SGI Australian Software Group. I don't speak for SGI. ------------------------------------------------------- SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now! http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click _______________________________________________ NFS maillist - [email protected] https://lists.sourceforge.net/lists/listinfo/nfs