Fix to enable bluez SCO USB urbs.

PATCH In review James Courtier-Dutton 2 participants 4 messages Feb 27, 2004 – Feb 29, 2004 Bluetooth drivers

lore

Share & tools

lore

James Courtier-Dutton

author

2004-02-27 23:57 UTC #0 lore raw

PATCH 1/1 Fix to enable bluez SCO USB urbs.

Here is a patch for /usr/src/linux-2.6.3/drivers/bluetooth/hci_usb.c

Without the interval set, the latest kernel 2.6.3 usb code will reject the usb_submit_urb().

Without this patch no ISOC urbs are submitted, and thus no SCO data is passed.

The proper fix would really be to only enable these when a SCO connection is actually open.

Cheers
James

hci_usb.c renamed from hci_usb.c.org +2 -0

@@ -263,6 +263,7 @@
 
 	urb->context  = husb;
 	urb->dev      = husb->udev;
+	urb->interval = husb->isoc_in_ep->desc.bInterval;
 	urb->pipe     = usb_rcvisocpipe(husb->udev, husb->isoc_in_ep->desc.bEndpointAddress);
 	urb->complete = hci_usb_rx_complete;

@@ -490,6 +491,7 @@
 	
 	urb->context  = husb;
 	urb->dev      = husb->udev;
+	urb->interval = husb->isoc_out_ep->desc.bInterval;
 	urb->pipe     = usb_sndisocpipe(husb->udev, husb->isoc_out_ep->desc.bEndpointAddress);
 	urb->complete = hci_usb_tx_complete;
 	urb->transfer_flags = URB_ISO_ASAP;

Marcel Holtmann

maintainer

2004-02-28 12:52 UTC #1 lore raw

Hi James,

Quoted 7 lines

Here is a patch for /usr/src/linux-2.6.3/drivers/bluetooth/hci_usb.c
Without the interval set, the latest kernel 2.6.3 usb code will reject the usb_submit_urb().
Without this patch no ISOC urbs are submitted, and thus no SCO data is passed.

the same patch is already in 2.6.4-rc1.

Quoted 2 lines

The proper fix would really be to only enable these when a SCO connection is actually open.

Of course. Send me patches for it.

Regards

Marcel

-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
Bluez-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

James Courtier-Dutton

author

2004-02-29 02:40 UTC #2 lore raw

Quoted 13 lines · Marcel Holtmann

Hi James,
Quoted 5 lines
Here is a patch for /usr/src/linux-2.6.3/drivers/bluetooth/hci_usb.c
Without the interval set, the latest kernel 2.6.3 usb code will reject the usb_submit_urb().
Without this patch no ISOC urbs are submitted, and thus no SCO data is passed.
the same patch is already in 2.6.4-rc1.

Quoted 12 lines

Quoted 1 line
The proper fix would really be to only enable these when a SCO connection is actually open.
Of course. Send me patches for it.
Regards
Marcel

Where do I get the most up to date bluetooth kernel modules?
I cannot find them in the sf.net CVS.
I also cannot find any info on where to get them on the www.bluez.org web site.

Cheers
James

Marcel Holtmann

maintainer

2004-02-29 02:39 UTC #3 lore raw

Hi James,

Quoted 4 lines

Where do I get the most up to date bluetooth kernel modules? I cannot find them in the sf.net CVS.
I also cannot find any info on where to get them on the www.bluez.org web site.

as soon as I have a set of three or more full tested patches, I push them for inclusion into 2.6 and I update the latest 2.6 -mh patch at
http://www.bluez.org/patches.html

Regards

Marcel