Skip to contentSkip to conversation

2.6.12-rc2 and as-iosched

DISCUSSION Kenneth Parrish 2 participants 4 messages Jul 18, 2005 – Jul 19, 2005 Block layer

lore
Share & tools
lore
#0 lore raw

Randy> Need more info.

Greetings. :)
CONFIG_HZ_ changes the block device elevator time-out values -- didn't see.

#1 lore raw
Quoted 4 lines · Kenneth Parrish

Randy> Need more info.

Greetings. :)
CONFIG_HZ_ changes the block device elevator time-out values -- didn't see.

I cannot reproduce here with cfq and HZ == 250, the jiffies <-> msec conversions are working fine. Please provide a proper bug report, did you change the values and not getting the expected back, or what is going wrong??

Signature · 1 line
Jens Axboe
#2 lore raw
Quoted 10 lines · Jens Axboe
Quoted 4 lines · Kenneth Parrish

Randy> Need more info.

Greetings. :)
CONFIG_HZ_ changes the block device elevator time-out values -- didn't see.

I cannot reproduce here with cfq and HZ == 250, the jiffies <-> msec conversions are working fine. Please provide a proper bug report, did you change the values and not getting the expected back, or what is going wrong??

ok, AS is definitely broken, it does an internal HZ <-> msec conversion in the store/show functions as well. This should fix it.

drivers/block/as-iosched.c renamed from opt/kernel/linux-2.6.13-rc3/drivers/block/as-iosched.c +1 -9
@@ -1935,23 +1935,15 @@
 static ssize_t
 as_var_show(unsigned int var, char *page)
 {
-	var = (var * 1000) / HZ;
 	return sprintf(page, "%d\n", var);
 }
 
 static ssize_t
 as_var_store(unsigned long *var, const char *page, size_t count)
 {
-	unsigned long tmp;
 	char *p = (char *) page;
 
-	tmp = simple_strtoul(p, &p, 10);
-	if (tmp != 0) {
-		tmp = (tmp * HZ) / 1000;
-		if (tmp == 0)
-			tmp = 1;
-	}
-	*var = tmp;
+	*var = simple_strtoul(p, &p, 10);
 	return count;
 }
 
Signature · 1 line
Jens Axboe
#3 lore raw

-=> [email protected] wrote to Kenneth Parrish <=-

ax> ok, AS is definitely broken, it does an internal HZ <-> msec ax> conversion in the store/show functions as well. This should fix ax> it.
thank ya :-)