Skip to contentSkip to conversation

Strange code in head.S

DISCUSSION Sylvain Munaut 2 participants 2 messages Mar 5, 2004 – Mar 6, 2004

lore
Share & tools
lore
#0 lore raw

Hello,

While looking at head.S, I noticed that in the FTR Section CPU_FTR_HAS_HIGH_BATS, the register used during all the mtspr SPRN_DBATxx,r20 is r20.
But shouldn't it be r10 ?
In the 2.4 version it was r20 but for all the preceding code of clear_bat, it has been replaced with r10 but not in the FTR ...

Maybe I'm wrong, I'm not working on an arch that uses it. It's just seems strange to me ...

Sylvain Munaut

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

#1 lore raw
Quoted 11 lines · Sylvain Munaut

Hello,

While looking at head.S, I noticed that in the FTR Section CPU_FTR_HAS_HIGH_BATS, the register used during all the mtspr SPRN_DBATxx,r20 is r20.
But shouldn't it be r10 ?
In the 2.4 version it was r20 but for all the preceding code of clear_bat, it has been replaced with r10 but not in the FTR ...

Maybe I'm wrong, I'm not working on an arch that uses it. It's just seems strange to me ...

Good catch !

Ben.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/