Skip to contentSkip to conversation

8139too assertions

TRIVIAL Applied Rene Herman 2 participants 2 messages Mar 10, 2004 – Mar 12, 2004 Network drivers

lore
Share & tools
lore
#0 lore raw

Hi Jeff,

current placements of these asserts seems unhelpful; we've already oopsed.

Incremental to IFG patch only for line-numbers.

Rene.

drivers/net/8139too.c renamed from drivers/net/8139too.c~ +2 -3
@@ -974,12 +974,11 @@
 	if (i < 0)
 		return i;
 
+	assert (dev != NULL);
 	tp = dev->priv;
+	assert (tp != NULL);
 	ioaddr = tp->mmio_addr;
-
 	assert (ioaddr != NULL);
-	assert (dev != NULL);
-	assert (tp != NULL);
 
 	addr_len = read_eeprom (ioaddr, 0, 8) == 0x8129 ? 8 : 6;
 	for (i = 0; i < 3; i++)