Skip to contentSkip to conversation

wifi: mt76: mt7921e: fix crash in chip reset fail

PATCH In review [email protected] 3 participants 3 messages Sep 15, 2022 – Sep 16, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wifi: mt76: mt7921e: fix crash in chip reset fail

From: Deren Wu <[email protected]>

commit fa3fbe64037839f448dc569212bafc5a495d8219 upstream.

In case of drv own fail in reset, we may need to run mac_reset several times. The sequence would trigger system crash as the log below.

Because we do not re-enable/schedule "tx_napi" before disable it again, the process would keep waiting for state change in napi_diable(). To avoid the problem and keep status synchronize for each run, goto final resource handling if drv own failed.

[ 5857.353423] mt7921e 0000:3b:00.0: driver own failed
[ 5858.433427] mt7921e 0000:3b:00.0: Timeout for driver own
[ 5859.633430] mt7921e 0000:3b:00.0: driver own failed
[ 5859.633444] ------------[ cut here ]------------
[ 5859.633446] WARNING: CPU: 6 at kernel/kthread.c:659 kthread_park+0x11d
[ 5859.633717] Workqueue: mt76 mt7921_mac_reset_work [mt7921_common]
[ 5859.633728] RIP: 0010:kthread_park+0x11d/0x150
[ 5859.633736] RSP: 0018:ffff8881b676fc68 EFLAGS: 00010202
......
[ 5859.633766] Call Trace:
[ 5859.633768]  <TASK>
[ 5859.633771]  mt7921e_mac_reset+0x176/0x6f0 [mt7921e]
[ 5859.633778]  mt7921_mac_reset_work+0x184/0x3a0 [mt7921_common]
[ 5859.633785]  ? mt7921_mac_set_timing+0x520/0x520 [mt7921_common]
[ 5859.633794]  ? __kasan_check_read+0x11/0x20
[ 5859.633802]  process_one_work+0x7ee/0x1320
[ 5859.633810]  worker_thread+0x53c/0x1240
[ 5859.633818]  kthread+0x2b8/0x370
[ 5859.633824]  ? process_one_work+0x1320/0x1320
[ 5859.633828]  ? kthread_complete_and_exit+0x30/0x30
[ 5859.633834]  ret_from_fork+0x1f/0x30
[ 5859.633842]  </TASK>
---
 drivers/net/wireless/mediatek/mt76/mt7921/pci_mac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/mediatek/mt76/mt7921/pci_mac.c +1 -1
index b0f58bcf70cb..106c88b723b9 100644
@@ -345,7 +345,7 @@ int mt7921e_mac_reset(struct mt7921_dev *dev)
 
 	err = mt7921e_driver_own(dev);
 	if (err)
-		return err;
+		goto out;
 
 	err = mt7921_run_firmware(dev);
 	if (err)
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 3 lines · On Thu, Sep 15, 2022 at 01:32:35PM +0800, [email protected] wrote:

From: Deren Wu <[email protected]>

commit fa3fbe64037839f448dc569212bafc5a495d8219 upstream.

This is already in the 5.19.9 kernel release, right? Do we need it again?

thanks,

greg k-h

#2 lore raw

Hi, Greg

Quoted 8 lines · Greg KH
Quoted 3 lines · On Thu, Sep 15, 2022 at 01:32:35PM +0800, [email protected] wrote:

From: Deren Wu <[email protected]>

commit fa3fbe64037839f448dc569212bafc5a495d8219 upstream.

This is already in the 5.19.9 kernel release, right? Do we need it again?

Ah, If so, we don't need it again. It seemed unavailable when I submitted the patch. Sorry for bothering you.

Sean

Quoted 4 lines

thanks,

greg k-h