Skip to contentSkip to conversation

Re: [Fwd: "Enhanced" MD code avaible for review]

Fwd: "Enhanced" MD code avaible for review Christoph Hellwig 4 participants 9 messages Mar 17, 2004 1 message not in the archive MD RAID

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 3 lines · Jeff Garzik
Quoted 2 lines

A patch to fs/partitions/check.c is also required for this release to function correctly:

Hmm. I don't think Jeff wrote that.

Quoted 4 lines
Quoted 1 line

http://people.freebsd.org/~gibbs/linux/SRC/md_announce_whole_device.diff

Vetoed. Kernel-level autodetection code is deprecated already, don't even try to add functionality for it.

So do you speak for the entire community in expressing that auto-detection will never make sense in the kernel? Are you completely unwilling to entertain even a minor discussion on the topic for those of us that don't understand the concerns the community has in supporting it?

Quoted 1 line

As for the actual code please post diffs instead of tarballs.

If you look at the posted code, you'll see that diffs make little sense at this point. But I will generate diffs in addition to the tarball with the next release later this week.

--
Justin

#3 lore raw
Quoted 5 lines · Justin T. Gibbs
Quoted 3 lines · Jeff Garzik
Quoted 2 lines

A patch to fs/partitions/check.c is also required for this release to function correctly:

Hmm. I don't think Jeff wrote that.

That's why it's doubly-quoted, right?

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

http://people.freebsd.org/~gibbs/linux/SRC/md_announce_whole_device.diff

Vetoed. Kernel-level autodetection code is deprecated already, don't even try to add functionality for it.

So do you speak for the entire community in expressing that auto-detection will never make sense in the kernel? Are you completely unwilling to entertain even a minor discussion on the topic for those of us that don't understand the concerns the community has in supporting it?

I speak about the concencus the 'community' has reached in the past. If you invested the tiniest amount of googling you'd have seen messages from Neil where he sais he'd rather get rid of autodetection ioctls in favour of mdadm doing the work, and patches extending autodetection beeing rejected. Which pretty much fits into the general do it in userspace if you can rule.

Quoted 5 lines
Quoted 1 line

As for the actual code please post diffs instead of tarballs.

If you look at the posted code, you'll see that diffs make little sense at this point. But I will generate diffs in addition to the tarball with the next release later this week.

Diffs alwasy make sense if you touch existing code.

#4 lore raw
Quoted 8 lines · Justin T. Gibbs
Quoted 5 lines
Quoted 3 lines · Jeff Garzik
Quoted 2 lines

A patch to fs/partitions/check.c is also required for this release to function correctly:

Hmm. I don't think Jeff wrote that.

That's why it's doubly-quoted, right?

Hmm. I didn't realize that Jeff was ever part of this thread. I authored the text that you quoted and was just surprised to see Jeff's name near it. Never mind.

Quoted 11 lines
Quoted 4 lines

So do you speak for the entire community in expressing that auto-detection will never make sense in the kernel? Are you completely unwilling to entertain even a minor discussion on the topic for those of us that don't understand the concerns the community has in supporting it?

I speak about the concencus the 'community' has reached in the past. If you invested the tiniest amount of googling you'd have seen messages from Neil where he sais he'd rather get rid of autodetection ioctls in favour of mdadm doing the work, and patches extending autodetection beeing rejected. Which pretty much fits into the general do it in userspace if you can rule.

I'm aware of Neil's past comments on the subject, but I was not aware of a more full discussion on what this means in terms of lost functionality for Linux. I would like to have that discussion. I'm more than willing to adjust our strategy once that discussion takes place and a consensus is reached.

--
Justin

#5 lore raw
Quoted 3 lines · Justin T. Gibbs

Hmm. I didn't realize that Jeff was ever part of this thread. I authored the text that you quoted and was just surprised to see Jeff's name near it. Never mind.

he forwarded the mail to me, and I didn't remove his name from the mutt inserted when replying, not intentional, but with the double quotes it shouldn't be that confusing either..

Quoted 5 lines

I'm aware of Neil's past comments on the subject, but I was not aware of a more full discussion on what this means in terms of lost functionality for Linux. I would like to have that discussion. I'm more than willing to adjust our strategy once that discussion takes place and a consensus is reached.

We're not far enough to actually removing functionlly yet. For that early userspace needs to get a little more mature and more widely used.

We're not going to add more functionaly like that. though.

#6 lore raw

(added linux-kernel to CC, where IMO the discussion on wider issues belongs)

Quoted 8 lines · Christoph Hellwig
Quoted 5 lines · Justin T. Gibbs

I'm aware of Neil's past comments on the subject, but I was not aware of a more full discussion on what this means in terms of lost functionality for Linux. I would like to have that discussion. I'm more than willing to adjust our strategy once that discussion takes place and a consensus is reached.

Quoted 4 lines

We're not far enough to actually removing functionlly yet. For that early userspace needs to get a little more mature and more widely used.

We're not going to add more functionaly like that. though.

If early userspace isn't ready, it sounds like a choice between "nothing" and "it works".

We want a clean, tasteful solution, sure. But I think we can work within the confines of the existing 2.6 API, and not postpone this stuff under early userspace is ready.

<rant>
Overall... the storage industry finally got off their ass and created a vendor-neutral RAID format, and they're actually using it. Linux users don't deserve to be left out in the cold until 2.7.x klibc stuff is in, since they will be buying such RAID hardware right now.

I got into the Linux kernel game years ago in a large part because of precisely this -- getting Linux users going on hardware that would otherwise be Windows-only, without my help. (or would otherwise be a grotty and buggy vendor driver, without my help:)) </rant>

Jeff

#7 lore raw
Quoted 6 lines · Jeff Garzik

If early userspace isn't ready, it sounds like a choice between "nothing" and "it works".

We want a clean, tasteful solution, sure. But I think we can work within the confines of the existing 2.6 API, and not postpone this stuff under early userspace is ready.

Umm, early userspace works nicely, you don't need the klibc and initramfs buzzwords for that, good 'ol initrd still works and people actually use it, e.g. for dm.

#8 lore raw
Quoted 10 lines · Christoph Hellwig
Quoted 3 lines · Jeff Garzik

If early userspace isn't ready, it sounds like a choice between "nothing" and "it works".

We want a clean, tasteful solution, sure. But I think we can work within the confines of the existing 2.6 API, and not postpone this stuff under early userspace is ready.

Umm, early userspace works nicely, you don't need the klibc and initramfs buzzwords for that, good 'ol initrd still works and people actually use it, e.g. for dm.

Agreed. initrd works in 2.4, too...

Jeff

#9 lore raw
In reply to Christoph Hellwig
Quoted 9 lines · Christoph Hellwig
Quoted 9 lines
Quoted 4 lines
Quoted 1 line

http://people.freebsd.org/~gibbs/linux/SRC/md_announce_whole_device.diff

Vetoed. Kernel-level autodetection code is deprecated already, don't even try to add functionality for it.

So do you speak for the entire community in expressing that auto-detection will never make sense in the kernel? Are you completely unwilling to entertain even a minor discussion on the topic for those of us that don't understand the concerns the community has in supporting it?

I personally see the use for it, but alas. This have also been an for EVMS and the reason they`ve changed so radically change between 1.2 and 2.0

Quoted 6 lines

I speak about the concencus the 'community' has reached in the past. If you invested the tiniest amount of googling you'd have seen messages from Neil where he sais he'd rather get rid of autodetection ioctls in favour of mdadm doing the work, and patches extending autodetection beeing rejected. Which pretty much fits into the general do it in userspace if you can rule.

Yes.
Personally I have different views on it, but that's the direction that especially the hardcore kernel developers on the linux kernel mailing list views the world and auto discovery etc.

Hendrik