Skip to contentSkip to conversation

status of PREEMPT and SMP together?

DISCUSSION Chris Friesen 3 participants 4 messages Mar 17, 2004 – Mar 18, 2004

lore
Share & tools
lore
#0 lore raw

Some of the Kconfig files (ppc/ppc64) seem to be of the opinion that there are races when both SMP and PREEMPT are enabled.

Is this still the case, or are they out of date?

Thanks,

Chris

Signature · 4 lines
Chris Friesen                    | MailStop: 043/33/F10
Nortel Networks                  | work: (613) 765-0557
3500 Carling Avenue              | fax:  (613) 765-2986
Nepean, ON K2H 8E9 Canada        | email: [email protected]
#1 lore raw
Quoted 4 lines · Chris Friesen

Some of the Kconfig files (ppc/ppc64) seem to be of the opinion that there are races when both SMP and PREEMPT are enabled.

Is this still the case, or are they out of date?

Hrm, I thought I sent Anton a patch to fix that.

The comment is out of date. Technically speaking, the potential SMP+PREEMPT races exist on UP+PREEMPT, too.

Running SMP+PREEMPT on a 4-way here :-)

Robert Love

#2 lore raw
Quoted 2 lines

Hrm, I thought I sent Anton a patch to fix that.

Sorry, I had planned to send it once Linus got over his deep freeze mode but forgot. Here it is.

Now that the option is selectable I marked it BROKEN for the moment since we havent got around to doing the low level exception bits yet... Do you have a G5 yet? :)

Quoted 4 lines

The comment is out of date. Technically speaking, the potential SMP+PREEMPT races exist on UP+PREEMPT, too.

Running SMP+PREEMPT on a 4-way here :-)

--

From: Robert Love <[email protected]>

arch/ppc64/Kconfig's entry for CONFIG_PREEMPT is missing the description after the "bool" statement, so the entry does not show up.

Also, the help description mentions a restriction that is not [any longer] true.

===== arch/ppc64/Kconfig 1.50 vs edited =====

arch/ppc64/Kconfig +2 -4
@@ -174,14 +179,12 @@
 	depends on DISCONTIGMEM
 
 config PREEMPT
-	bool
+	bool "Preemptible Kernel"
+	depends on BROKEN
 	help
 	  This option reduces the latency of the kernel when reacting to
 	  real-time or interactive events by allowing a low priority process to
 	  be preempted even if it is in kernel mode executing a system call.
-	  Unfortunately the kernel code has some race conditions if both
-	  CONFIG_SMP and CONFIG_PREEMPT are enabled, so this option is
-	  currently disabled if you are building an SMP kernel.
 
 	  Say Y here if you are building a kernel for a desktop, embedded
 	  or real-time system.  Say N if you are unsure.
#3 lore raw
Quoted 2 lines · Anton Blanchard

Sorry, I had planned to send it once Linus got over his deep freeze mode but forgot. Here it is.

Thanks.

Quoted 3 lines

Now that the option is selectable I marked it BROKEN for the moment since we havent got around to doing the low level exception bits yet... Do you have a G5 yet? :)

Unfortunately, no. ;-)

I think the low-level bits are there for PPC32, right? So just PPC64 is missing the kernel entry/exit and interrupt changes?

Robert Love