Skip to contentSkip to conversation

minor portability issue in ip_queue

PATCH New Pablo Neira 1 participant 1 message Apr 15, 2004 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 minor portability issue in ip_queue

Hi,

I think that there's a minor issue in ip_queue related to portability, actually most architectures use long as time_t and suseconds_t but some weird don't (parisc and sparc64).

So, If I'm not wrong, I think that maybe this could lead to some problems using ip_queue in those platforms. Whatever you think, please let me know.

regards,
Pablo

include/linux/netfilter_ipv4/ip_queue.h +2 -2
@@ -21,8 +21,8 @@
 typedef struct ipq_packet_msg {
 	unsigned long packet_id;	/* ID of queued packet */
 	unsigned long mark;		/* Netfilter mark value */
-	long timestamp_sec;		/* Packet arrival time (seconds) */
-	long timestamp_usec;		/* Packet arrvial time (+useconds) */
+	time_t timestamp_sec;		/* Packet arrival time (seconds) */
+	suseconds_t timestamp_usec;	/* Packet arrvial time (+useconds) */
 	unsigned int hook;		/* Netfilter hook we rode in on */
 	char indev_name[IFNAMSIZ];	/* Name of incoming interface */
 	char outdev_name[IFNAMSIZ];	/* Name of outgoing interface */