Skip to contentSkip to conversation

Recent regression of ALC655 on VIA

DISCUSSION R CHAN 2 participants 3 messages Apr 16, 2004 – Apr 17, 2004

lore
Share & tools
lore

R CHAN

author
#0 lore raw

Hi, recent Alsa changes (ac97_patch.c) seem to have broken my ALC655 ac97 codec on via82xx. The breakage happened around 2.6.5.

Specifically, I can no longer set

Mic As Center/LFE control

Unlike Line-In As Surround it is now reported
as a volume control with Mono values from 0-0.
Can't set that bit at all.

Secondly, I can't get 5.1 sound at all - though
duplicate front does work.

Previously, I tested surround and center/lfe using the following plugs. I was able to test them as stereo pairs - now I can't get sound using them at. Any suggestions?

#setup 5.1 device using hw:0,1
#Device 0 is stereo
#Device 1 is 5.1
pcm.via51

{
	type plug;
	slave {
		pcm "hw:0,1";
		channels 6;
		rate 48000;
	}
}

#Streams 2,3 = surround speakers
pcm.via23

{
	type plug;
	slave via51;
	ttable.2.0 1;
	ttable.3.1 1;
}

#Streams 4,5 = center/lfe speakers
pcm.via45

{
	type plug;
	slave via51;
	ttable.4.0 1;
	ttable.5.1 1;

}

-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click

#1 lore raw

At Fri, 16 Apr 2004 15:25:42 +0800,

Quoted 11 lines · R CHAN

Hi, recent Alsa changes (ac97_patch.c) seem to have broken my ALC655 ac97 codec on via82xx. The breakage happened around 2.6.5.

Specifically, I can no longer set

Mic As Center/LFE control

Unlike Line-In As Surround it is now reported
as a volume control with Mono values from 0-0.
Can't set that bit at all.

try the attached patch.

Quoted 2 lines

Secondly, I can't get 5.1 sound at all - though
duplicate front does work.

doesn't 'aplay -Dsurroun51 some-6ch-sample.wav' work?

Takashi

Index: alsa-kernel/pci/ac97/ac97_codec.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/pci/ac97/ac97_codec.c,v retrieving revision 1.117

pci/ac97/ac97_codec.c +1 -1
diff -u -r1.117 ac97_codec.c
@@ -880,7 +880,7 @@
 		.info = snd_ac97_info_single,
 		.get = snd_ac97_get_single,
 		.put = snd_ac97_put_spsa,
-		.private_value = AC97_EXTENDED_STATUS | (4 << 8) | (3 << 16) | (0 << 24),
+		.private_value = AC97_SINGLE_VALUE(AC97_EXTENDED_STATUS, 4, 3, 0)
 	},
 };
 

Index: alsa-kernel/pci/ac97/ac97_local.h
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/pci/ac97/ac97_local.h,v retrieving revision 1.4

pci/ac97/ac97_local.h +2 -1
diff -u -r1.4 ac97_local.h
@@ -22,10 +22,11 @@
  *
  */
 
+#define AC97_SINGLE_VALUE(reg,shift,mask,invert) ((reg) | ((shift) << 8) | ((mask) << 16) | ((invert) << 24))
 #define AC97_SINGLE(xname, reg, shift, mask, invert) \
 { .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, .info = snd_ac97_info_single, \
   .get = snd_ac97_get_single, .put = snd_ac97_put_single, \
-  .private_value = (reg) | ((shift) << 8) | ((mask) << 16) | ((invert) << 24) }
+  .private_value =  AC97_SINGLE_VALUE(reg, shift, mask, invert) }
 
 /* ac97_codec.c */
 extern const char *snd_ac97_stereo_enhancements[];

Index: alsa-kernel/pci/ac97/ac97_patch.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/pci/ac97/ac97_patch.c,v retrieving revision 1.43

pci/ac97/ac97_patch.c +2 -0
diff -u -r1.43 ac97_patch.c
@@ -1090,6 +1090,7 @@
 		.info = snd_ac97_info_single,
 		.get = snd_ac97_alc650_mic_get,
 		.put = snd_ac97_alc650_mic_put,
+		.private_value = AC97_SINGLE_VALUE(0, 0, 1, 0) /* only mask needed */
 	},
 };
 
@@ -1190,6 +1191,7 @@
 		.info = snd_ac97_info_single,
 		.get = snd_ac97_alc655_mic_get,
 		.put = snd_ac97_alc655_mic_put,
+		.private_value = AC97_SINGLE_VALUE(0, 0, 1, 0) /* only mask needed */
 	},
 };
 
#2 lore raw

Your patch has fixed the problem - 5.1 is working again and I can set the 'Mic As Center/LFE' control. Thank you.

Quoted 11 lines · Takashi Iwai

At Fri, 16 Apr 2004 15:25:42 +0800,

Quoted 7 lines · R CHAN

Hi, recent Alsa changes (ac97_patch.c) seem to have broken my ALC655 ac97 codec on via82xx. The breakage happened around 2.6.5.

Specifically, I can no longer set

Mic As Center/LFE control

Quoted 9 lines
Quoted 5 lines

Unlike Line-In As Surround it is now reported
as a volume control with Mono values from 0-0.
Can't set that bit at all.

try the attached patch.

-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click