drivers/scsi/pcmcia MIN/MAX/NUMBER removal
Subsystems (3)
PATCH 1/1 drivers/scsi/pcmcia MIN/MAX/NUMBER removal
Patch (against 2.6.6-rc1) removes unnecessary min/max/number macros and changes calls to use kernel.h macros instead.
Feedback is always welcome
Michael
drivers/scsi/pcmcia/nsp_cs.c +6 -6
@@ -315,7 +315,7 @@int i;/* setup sync data */ -for ( i =0 ; i <NUMBER (data->Sync); i++ ) { +for ( i =0 ; i <ARRAY_SIZE (data->Sync); i++ ) { data->Sync[i] = tmp_sync; } }
@@ -600,7 +600,7 @@unsigned int base = SCpnt->device->host->io_port;nsp_hw_data *data = (nsp_hw_data *)SCpnt->device->host->hostdata;char *buf = data->MsgBuffer; -int len =MIN (MSGBUF_SIZE , data->MsgLen); +int len =min (MSGBUF_SIZE , data->MsgLen);int ptr;int ret;
@@ -774,7 +774,7 @@continue ; } - res =MIN (res, SCpnt->SCp.this_residual); + res =min (res, SCpnt->SCp.this_residual);switch (data->TransferMode) {case MODE_IO32 :
@@ -868,7 +868,7 @@continue ; } - res =MIN (SCpnt->SCp.this_residual,WFIFO_CRIT ); + res =min (SCpnt->SCp.this_residual,WFIFO_CRIT );//nsp_dbg(NSP_DEBUG_DATA_IO, "ptr=0x%p this=0x%x res=0x%x", SCpnt->SCp.ptr, SCpnt->SCp.this_residual, res); switch (data->TransferMode) {
@@ -1490,7 +1490,7 @@spin_unlock_irqrestore (&(data->Lock), flags);SPRINTF ("SDTR status\n" ); -for (id =0 ; id <NUMBER (data->Sync); id++) { +for (id =0 ; id <ARRAY_SIZE (data->Sync); id++) {SPRINTF ("id %d: " , id);
@@ -1534,7 +1534,7 @@ } - thislength =MIN (thislength, length); + thislength =min (thislength, length); *start = buffer + offset;return thislength;
drivers/scsi/pcmcia/nsp_cs.h +0 -2
@@ -26,9 +26,7 @@/************************************ * Some useful macros... */ -#define NUMBER (arr) ((int) (sizeof(arr) / sizeof(arr[0])))/* from XtNumber() in /usr/X11R6/include/X11/Intrinsic.h */ #define BIT (x) (1L << (x)) -#define MIN (a,b) ((a) > (b) ? (b) : (a))/* SCSI initiator must be ID 7 */ #define NSP_INITIATOR_ID 7
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors