drivers/scsi/nsp MIN/MAX/NUMBER removal
PATCH 1/1 drivers/scsi/nsp MIN/MAX/NUMBER removal
Patch (against 2.6.6-rc1) removes unnecessary min/max/number macros and changes calls to use kernel.h macros instead.
Feedback is always welcome
Michael
drivers/scsi/nsp32.c +12 -12
@@ -859,7 +859,7 @@* or current nexus is not existed, unexpected * reselection is occurred. Send reject message. */ -if (newid >=NUMBER (data->lunt) || newlun >=NUMBER (data->lunt[0 ])) { +if (newid >=ARRAY_SIZE (data->lunt) || newlun >=ARRAY_SIZE (data->lunt[0 ])) {nsp32_msg (KERN_WARNING ,"unknown id/lun" );return FALSE; }else if (data->lunt[newid][newlun].SCpnt ==NULL ) {
@@ -1568,7 +1568,7 @@SPRINTF ("SDTR status\n" ); -for (id =0 ; id <NUMBER (data->target); id++) { +for (id =0 ; id <ARRAY_SIZE (data->target); id++) {SPRINTF ("id %d: " , id);
@@ -1610,7 +1610,7 @@ } - thislength =MIN (thislength, length); + thislength =min (thislength, length); *start = buffer + offset;return thislength;
@@ -2753,17 +2753,17 @@case CLOCK_4 :/* If data->clock is CLOCK_4, then select 40M sync table. */ data->synct = nsp32_sync_table_40M; - data->syncnum =NUMBER (nsp32_sync_table_40M); + data->syncnum =ARRAY_SIZE (nsp32_sync_table_40M);break ;case CLOCK_2 :/* If data->clock is CLOCK_2, then select 20M sync table. */ data->synct = nsp32_sync_table_20M; - data->syncnum =NUMBER (nsp32_sync_table_20M); + data->syncnum =ARRAY_SIZE (nsp32_sync_table_20M);break ;case PCICLK :/* If data->clock is PCICLK, then select pci sync table. */ data->synct = nsp32_sync_table_pci; - data->syncnum =NUMBER (nsp32_sync_table_pci); + data->syncnum =ARRAY_SIZE (nsp32_sync_table_pci);break ;default : nsp32_msg(KERN_WARNING,
@@ -2771,7 +2771,7 @@/* Use default value CLOCK_4 */ data->clock =CLOCK_4 ; data->synct = nsp32_sync_table_40M; - data->syncnum =NUMBER (nsp32_sync_table_40M); + data->syncnum =ARRAY_SIZE (nsp32_sync_table_40M); }/*
@@ -2805,9 +2805,9 @@ goto free_autoparam; } -for (i =0 ; i <NUMBER (data->lunt); i++) { -for (j =0 ; j <NUMBER (data->lunt[0 ]); j++) { -int offset = i *NUMBER (data->lunt[0 ]) + j; +for (i =0 ; i <ARRAY_SIZE (data->lunt); i++) { +for (j =0 ; j <ARRAY_SIZE (data->lunt[0 ]); j++) { +int offset = i *ARRAY_SIZE (data->lunt[0 ]) + j;nsp32_lunt tmp = { .SCpnt =NULL , .save_datp = 0,
@@ -2825,7 +2825,7 @@/* * setup target */ -for (i =0 ; i <NUMBER (data->target); i++) { +for (i =0 ; i <ARRAY_SIZE (data->target); i++) {nsp32_target *target = &(data->target[i]); target->limit_entry =0 ;
@@ -3021,7 +3021,7 @@* fall back to asynchronous transfer mode * initialize SDTR negotiation flag */ -for (i =0 ; i <NUMBER (data->target); i++) { +for (i =0 ; i <ARRAY_SIZE (data->target); i++) {nsp32_target *target = &data->target[i]; target->sync_flag =0 ;
drivers/scsi/nsp32.h +0 -4
@@ -70,11 +70,7 @@/* * MACRO */ -#define NUMBER (arr) ((int) (sizeof(arr) / sizeof(arr[0])))#define BIT (x) (1UL << (x)) -#ifndef MIN -# define MIN (a,b) ((a) > (b) ? (b) : (a)) -#endif /* * BASIC Definitions
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors