Skip to contentSkip to conversation

kernel>=2.6.4-rc3 hung or panic on C1[18]0

parisc-linux Joel Soete 2 participants 2 messages Apr 26, 2004

lore
Share & tools
lore

Joel Soete

author
#0 lore raw

Hi all,

I know it shouldn't be the source of the pb but btw I noticed:

Quoted 1 line

ncr53c8xx.c:7594: u_long baddr = map_scsi_single_data(np, cmd);

cmd is a "struct scsi_cmnd *" (the parameter of ncr_scatter)

Quoted 1 line

sym53c8xx_comm.h:699:static int __map_scsi_sg_data(struct device *dev,

Scsi_Cmnd *cmd)
...
sym53c8xx_comm.h:708: use_sg = dma_map_sg(dev, cmd->buffer, cmd->use_sg,
dma_dir);

and here cmd is a "Scsi_Cmnd *" which is so of different type because of "typedef struct scsi_cmnd Scsi_Cmnd"

What should it be done?

Thanks in advance for your attention,
Joel

----------------------------------------------------------------------------------------
Tiscali ADSL: 35 €/mois, la meilleure offre du marché!
http://reg.tiscali.be/default.asp?lg=fr

#1 lore raw
Quoted 2 lines · Joel Soete

and here cmd is a "Scsi_Cmnd *" which is so of different type because of "typedef struct scsi_cmnd Scsi_Cmnd"

uhm...the typedef says Scsi_Cmnd *IS* struct scsi_cmnd. Therefor "Scsi_Cmnd *" is the same type as "struct scsi_cmnd *".

Quoted 1 line

What should it be done?

Get rid of Scsi_Cmnd typedef?
I personally consider it bad style to use both forms in the same subsystem and don't really care which is used. But that's an issue for the subsystem maintainer to decide. :^)

grant