2.6.6-rc3-mm2 oops in psmouse/serio after resuming from APM suspend-to-ram
On a Thinkpad T41 after going into suspend via APM and then resuming, the psmouse driver seems to crash after resetting itself, at which point the PS/2 mouse device (obviously) stops responding and I can't unload the psmouse module. I don't know if this is a new bug or not, as this is the first time I'm trying APM suspend on this laptop. The oops and the kernel messages before it:
Synaptics Touchpad, model: 1
Firmware: 5.9
Sensor: 44
new absolute packet format
Touchpad has extended capability bits
-> multifinger detection
-> palm detection
-> pass-through port
printing eip:
c0206121
Oops: 0002 [#1]
PREEMPT
CPU: 0
EIP: 0060:[__serio_unregister_port+17/64] Not tainted VLI
EFLAGS: 00010246 (2.6.6-rc3-mm2)
EIP is at __serio_unregister_port+0x11/0x40
eax: ec67b534 ebx: ec67b504 ecx: 00000000 edx: 00000000
esi: c02d7a60 edi: c02d79a0 ebp: c02d79c0 esp: efda7f94
ds: 007b es: 007b ss: 0068
Process kseriod (pid: 104, threadinfo=efda7000 task=efdd3130)
Stack: ed37b000 f0920d5b ec6813c4 ec6813bc c0205dfd efda7000 fffff000
efda7fc0
efda7000 c0205e85 c027b1d7 00000000 efdd3130 c0113f80 00100100
00200200
00000000 00000000 00000000 c0205e40 00000000 00000000 00000000
c0103d7d
Call Trace:
[__crc_unlock_buffer+2625559/3107416] psmouse_disconnect+0x2b/0x90 [psmouse]
[serio_handle_events+157/224] serio_handle_events+0x9d/0xe0 [serio_thread+69/320] serio_thread+0x45/0x140 [default_wake_function+0/16] default_wake_function+0x0/0x10 [serio_thread+0/320] serio_thread+0x0/0x140 [kernel_thread_helper+5/24] kernel_thread_helper+0x5/0x18
Code: 00 5b c3 8d b4 26 00 00 00 00 ba 04 00 00 00
e9 76 fe ff ff 8d b6 00 00 00 00 53 89 c3 e8 f8 fb ff ff 8d 43 30 8b 53 30 8b 48 04 <89> 4a 04 89 11 89 40 04 89 43 30 8b 43 2c 85 c0 74 07 8b 50 18
Hi,
Quoted 7 lines · Ari Pollak
On a Thinkpad T41 after going into suspend via APM and then resuming, the psmouse driver seems to crash after resetting itself, at which point the PS/2 mouse device (obviously) stops responding and I can't unload the psmouse module. I don't know if this is a new bug or not, as this is the first time I'm trying APM suspend on this laptop. The oops and the kernel messages before it:
I think this should take care of your oops:
===== drivers/input/mouse/psmouse-base.c 1.57 vs edited =====
drivers/input/mouse/psmouse-base.c +5 -5
@@ -424,17 +424,17 @@if (set_properties) { psmouse->vendor ="Synaptics" ; psmouse->name ="TouchPad" ; - } -if (max_proto >PSMOUSE_IMEX ) { -if (synaptics_init (psmouse) ==0 ) -return PSMOUSE_SYNAPTICS ; +if (max_proto >PSMOUSE_IMEX ) { +if (synaptics_init (psmouse) ==0 ) +return PSMOUSE_SYNAPTICS ;/* * Some Synaptics touchpads can emulate extended protocols (like IMPS/2). * Unfortunately Logitech/Genius probes confuse some firmware versions so * we'll have to skip them. */ - max_proto =PSMOUSE_IMEX ; + max_proto =PSMOUSE_IMEX ; + } }/* * Make sure that touchpad is in relative mode, gestures (taps) are enabled
This patch did indeed fix the problem; thanks! Hopefully it will be in the next -mm update.
One of these days I need to learn how to debug my own crashes.
Quoted 28 lines · Dmitry Torokhov
I think this should take care of your oops:
=====
drivers/input/mouse/psmouse-base.c1.57 vs edited =====drivers/input/mouse/psmouse-base.c +5
-5@@ -424,17 +424,17 @@if (set_properties) { psmouse->vendor ="Synaptics" ; psmouse->name ="TouchPad" ; - } -if (max_proto >PSMOUSE_IMEX ) { -if (synaptics_init (psmouse) ==0 ) -return PSMOUSE_SYNAPTICS ; +if (max_proto >PSMOUSE_IMEX ) { +if (synaptics_init (psmouse) ==0 ) +return PSMOUSE_SYNAPTICS ;/* * Some Synaptics touchpads can emulate extended protocols (like IMPS/2). * Unfortunately Logitech/Genius probes confuse some firmware versions so * we'll have to skip them. */ - max_proto =PSMOUSE_IMEX ; + max_proto =PSMOUSE_IMEX ; + } }/* * Make sure that touchpad is in relative mode, gestures (taps) are enabled
Quoted 3 lines · Ari Pollak
This patch did indeed fix the problem; thanks! Hopefully it will be in the next -mm update.
Actually the previous patch is a bad one, I think this one is better:
===================================================================
[email protected], 2004-05-10 00:33:57-05:00, [email protected]
Input: do not call synaptics_init unless we are ready to do full
mouse setup
psmouse-base.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
===================================================================
drivers/input/mouse/psmouse-base.c +1 -1
@@ -427,7 +427,7 @@ }if (max_proto >PSMOUSE_IMEX ) { -if (synaptics_init (psmouse) ==0 ) +if (!set_properties ||synaptics_init (psmouse) ==0 )return PSMOUSE_SYNAPTICS ;/* * Some Synaptics touchpads can emulate extended protocols (like IMPS/2).
Hm, this patch does work, but it seems to break the synaptics driver for XFree86:
(II) Synaptics touchpad driver version 0.13.0 Configured Mouse no synaptics event device found (checked 5 nodes) (EE) xf86OpenSerial: No Device specified.
Synaptics driver unable to open device
(EE) PreInit failed for input device "Configured Mouse" (II) UnloadModule: "synaptics"
Quoted 30 lines
I think this should take care of your oops:
=====
drivers/input/mouse/psmouse-base.c1.57 vs edited =====drivers/input/mouse/psmouse-base.c +5
-5@@ -424,17 +424,17 @@if (set_properties) { psmouse->vendor ="Synaptics" ; psmouse->name ="TouchPad" ; - } -if (max_proto >PSMOUSE_IMEX ) { -if (synaptics_init (psmouse) ==0 ) -return PSMOUSE_SYNAPTICS ; +if (max_proto >PSMOUSE_IMEX ) { +if (synaptics_init (psmouse) ==0 ) +return PSMOUSE_SYNAPTICS ;/* * Some Synaptics touchpads can emulate extended protocols (like IMPS/2). * Unfortunately Logitech/Genius probes confuse some firmware versions so * we'll have to skip them. */ - max_proto =PSMOUSE_IMEX ; + max_proto =PSMOUSE_IMEX ; + } }/* * Make sure that touchpad is in relative mode, gestures (taps) are enabled