Skip to contentSkip to conversation

usb sleep patch

linux-usb-devel Oliver Neukum 2 participants 2 messages May 18, 2004 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 5 lines

+ * msleep - sleep safely even with waitqueue interruptions
+ * msecs: Time in milliseconds to sleep for
+ */
+static inline void msleep(unsigned int msecs)

Why do you make it inline? After a milisecond the cache is cold, so we should shrink the code.

Regards
Oliver

#3 lore raw
Quoted 8 lines · Oliver Neukum
Quoted 5 lines

+ * msleep - sleep safely even with waitqueue interruptions
+ * msecs: Time in milliseconds to sleep for
+ */
+static inline void msleep(unsigned int msecs)

Why do you make it inline? After a milisecond the cache is cold, so we should shrink the code.

I wasn't thinking, see my final proposed patch.

thanks,

greg k-h