Skip to contentSkip to conversation

introduction and first questions

Kernel-janitors Yoon Soo 2 participants 2 messages May 26, 2004 – May 27, 2004 Kernel janitors

lore
Share & tools
lore

Yoon Soo

author
#0 lore raw

Hi all,

I am new in this list and there are some points which are not very clear to me. But first of all, I read the todo list and worked on the point to get rid of the 'old-fashioned' way to access the driver_data field direct and replaced them with the proper dev_get/set_drvdata or pci_get/set_drvdata.

I created the patch like mentioned in the patchsubmitting-howto of the source documentation, and have tested it. What are now the further steps, just sending the patch as attachement to this list? Another question is, which original source code version should be taken..2.6.6 (as I did) or the most actual from the cvs tree?

Very many thanks in advance for helping me making the first steps ;)

greets

ys

PS. As I have seen while working on my patch, tty->driver_data should also not accessed directly, and for the consistency tty_get_drvdata and tty_set_drvdata should be added too and called instead of the direct access. Is this the right list to discuss this matter? Or is it in work?

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

hi yoon,

On Wed, 26 May 2004, Yoon Soo wrote:

...

Quoted 5 lines

I created the patch like mentioned in the patchsubmitting-howto of the source documentation, and have tested it. What are now the further steps, just sending the patch as attachement to this list? Another question is, which original source code version should be taken..2.6.6 (as I did) or the most actual from the cvs tree?

the more actual the better, but mention on which version your patch applies. please send the patch inline to the kj mailinglist, not attached. take a look at 6) -> SubmittingPatches

do take care not to introduce trailing space
or to convert tabs into spaces
quick egrep -n "^\+(.* $| )" helps.
do not forget to mention in your description the testing (just compiled in lack of hardware, or actually run).

Quoted 1 line

Very many thanks in advance for helping me making the first steps ;)

you' ll get more feedback as soon your patches lands. if you don't get any feedback that may also be a good sign, and your patch may get into next kj patch set.

good luck
a++ maks

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors