Skip to contentSkip to conversation

Problems with 3c59x in 2.6.7-rc1-bk*

PATCH Phil Brutsche 1 participant 1 message May 28, 2004 Network drivers

lore
Share & tools
lore
#0 lore raw

With a 3c905C NIC, I get a kernel panic & hard lock while trying to bring up the interface at boot.

After reverting the following patch (introduced in 2.6.6-bk1) there are no more kernel panics. 2.6.6 and earlier work fine with this card.

drivers/net/3c59x.c 2004-05-10 04:25:39 -07:00 renamed from drivers/net/3c59x.c 2004-03-13 22:54:58 -08:00 +1 -1
diff -Nru a/drivers/net/3c59x.c b/drivers/net/3c59x.c
@@ -520,7 +520,7 @@
        {"3c905B-FX Cyclone 100baseFx",
         PCI_USES_IO|PCI_USES_MASTER, IS_CYCLONE|HAS_HWCKSM, 128, },
        {"3c905C Tornado",
-        PCI_USES_IO|PCI_USES_MASTER, IS_TORNADO|HAS_NWAY|HAS_HWCKSM, 128, },
+       PCI_USES_IO|PCI_USES_MASTER, IS_TORNADO|HAS_NWAY|HAS_HWCKSM|EXTRA_PREAMBLE, 128, },
        {"3c980 Cyclone",
         PCI_USES_IO|PCI_USES_MASTER, IS_CYCLONE|HAS_HWCKSM, 128, },
        {"3c980C Python-T",

The strange part? The patch description shows that it tries to fix 100baseTX-FD problems with 3c905C cards... which it precisely what works fine here WITHOUT the patch.

Yell if anyone needs the text of the panic.

(Andrew, this is directed at you because the changelog shows the patch came to Linus from you via -mm)

Signature · 2 lines
Phil Brutsche
[email protected]