Skip to contentSkip to conversation

libata regression 2.6.6-rc1 -> 2.6.6-rc2 located

PATCH Brad Campbell 2 participants 2 messages May 29, 2004 SCSI

lore
Share & tools
lore
#0 lore raw

I managed to narrow it down to a diff between 2.6.6-rc1 and 2.6.6-rc2

2.6.6-rc1 works fine and 2.6.6-rc2 exhibits the lockup on the third card.

Reverting this hunk makes everything happy again.
I also tested this against 2.6.7-rc1-bk4 and it solves the problem. I don't pretend to understand why, just did the donkey testing to locate it.

drivers/scsi/sata_promise.c 2004-05-29 19:41:47.000000000 +0400 renamed from drivers/scsi/sata_promise.c 2004-05-29 19:53:40.000000000 +0400 +2 -2
diff -urN linux-2.6.5-a/drivers/scsi/sata_promise.c linux-2.6.5-b/drivers/scsi/sata_promise.c
@@ -1180,14 +1180,14 @@
 
 static void pdc_tf_load_mmio(struct ata_port *ap, struct ata_taskfile *tf)
 {
-       if (tf->protocol != ATA_PROT_DMA)
+       if (tf->protocol == ATA_PROT_PIO)
                ata_tf_load_mmio(ap, tf);
 }
 
 
 static void pdc_exec_command_mmio(struct ata_port *ap, struct ata_taskfile *tf)
 {
-       if (tf->protocol != ATA_PROT_DMA)
+       if (tf->protocol == ATA_PROT_PIO)
                ata_exec_command_mmio(ap, tf);
 }
 

Hope this helps shed some light.. Still don't understand why it works perfectly with only 2 cards however.

Regards,
Brad

#1 lore raw
Quoted 12 lines · Brad Campbell

diff -urN linux-2.6.5-a/drivers/scsi/sata_promise.c linux-2.6.5-b/drivers/scsi/sata_promise.c
--- linux-2.6.5-a/drivers/scsi/sata_promise.c 2004-05-29
19:53:40.000000000 +0400
+++ linux-2.6.5-b/drivers/scsi/sata_promise.c 2004-05-29
19:41:47.000000000 +0400

drivers/scsi/sata_promise.c 2004-05-29 19:41:47.000000000 +0400 renamed from drivers/scsi/sata_promise.c 2004-05-29 19:53:40.000000000 +0400 +1 -1
@@ -1180,14 +1180,14 @@
 
 static void pdc_tf_load_mmio(struct ata_port *ap, struct ata_taskfile *tf)
 {
-       if (tf->protocol != ATA_PROT_DMA)
+       if (tf->protocol == ATA_PROT_PIO)
                ata_tf_load_mmio(ap, tf);

drivers/scsi/sata_promise.c 2004-05-29 19:41:47.000000000 +0400 line 1193

Quoted 10 lines
drivers/scsi/sata_promise.c 2004-05-29 19:41:47.000000000 +0400 renamed from drivers/scsi/sata_promise.c 2004-05-29 19:53:40.000000000 +0400 +1 -1
 }
 
 
 static void pdc_exec_command_mmio(struct ata_port *ap, struct 
 ata_taskfile *tf)
 {
-       if (tf->protocol != ATA_PROT_DMA)
+       if (tf->protocol == ATA_PROT_PIO)
                ata_exec_command_mmio(ap, tf);
 }

Great work, thanks.

Short term, I'll revert this patch. The change was more of a "preparation for the future", and not strictly required.

I think I understand why, but I'll need to ponder a bit more on the long term solution.

Jeff