Skip to contentSkip to conversation

TRIVIAL: Fix linux/mtd/nftl.h for user-space inclusion

PATCH Bernardo Innocenti 2 participants 6 messages Jun 1, 2004 Memory technology devices (MTD)

lore
Share & tools
lore

Bernardo Innocenti

author
#0 lore raw

Fix linux/mtd/nftl.h for user-space inclusion (required to build mtd-utils).

Please apply.

include/linux/mtd/nftl.h +0 -0
@@ -8,7 +8,6 @@

#define __MTD_NFTL_H__

#include <linux/mtd/mtd.h>
-#include <linux/mtd/blktrans.h>

/* Block Control Information */

@@ -76,6 +75,8 @@

#ifdef __KERNEL__

+#include <linux/mtd/blktrans.h>
+
/* these info are used in ReplUnitTable */
#define BLOCK_NIL 0xffff /* last block of a chain */
#define BLOCK_FREE 0xfffe /* free block */

Signature · 2 lines
 // Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/  http://www.develer.com/
#1 lore raw
Quoted 3 lines · Bernardo Innocenti

Fix linux/mtd/nftl.h for user-space inclusion (required to build mtd-utils).

Please apply.

It should be including mtd/nftl-user.h not linux/nftl.h

Signature · 1 line
dwmw2
author
#2 lore raw
Quoted 7 lines · David Woodhouse
Quoted 3 lines · Bernardo Innocenti

Fix linux/mtd/nftl.h for user-space inclusion (required to build mtd-utils).

Please apply.

It should be including mtd/nftl-user.h not linux/nftl.h

The header nftl-user.h doesn't exist in neither linux-2.6.6 and in the version of mtd-utils imported in uClinux-dist (a rather old version, I shall admit).

If nftl.h isn't supposed to be included from user-space, the "#ifdef __KERNEL__ ... #endif" it contains is useless.

I may change mtd-utils locally, but I think this fix should also go into the kernel "just in case".

Signature · 2 lines
 // Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/  http://www.develer.com/
#3 lore raw
Quoted 5 lines · Bernardo Innocenti
Quoted 4 lines · David Woodhouse
Quoted 2 lines · Bernardo Innocenti

Fix linux/mtd/nftl.h for user-space inclusion (required to build mtd-utils).

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Please apply.

It should be including mtd/nftl-user.h not linux/nftl.h

The header nftl-user.h doesn't exist in neither linux-2.6.6 and in the version of mtd-utils imported in uClinux-dist (a rather old version, I shall admit).

nftl-user.h is in CVS, along with a version of the userspace tools which uses it.

Quoted 3 lines

If nftl.h isn't supposed to be included from user-space, the "#ifdef __KERNEL__ ... #endif" it contains is useless.

It it also removed in CVS.

Signature · 1 line
dwmw2
author
#4 lore raw
Quoted 7 lines · David Woodhouse
Quoted 4 lines

The header nftl-user.h doesn't exist in neither
linux-2.6.6 and in the version of mtd-utils
imported in uClinux-dist (a rather old version,
I shall admit).

nftl-user.h is in CVS, along with a version of the userspace tools which uses it.

Ok, I'll check it out from CVS and post a patch to the uClinux-dev mailing-list adding this header in user/mtd-utils.

Is it 100% binary-compatible with all kernels?

Signature · 2 lines
 // Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/  http://www.develer.com/
#5 lore raw
Quoted 7 lines · Bernardo Innocenti
Quoted 5 lines · David Woodhouse
Quoted 4 lines

The header nftl-user.h doesn't exist in neither
linux-2.6.6 and in the version of mtd-utils
imported in uClinux-dist (a rather old version,
I shall admit).

Quoted 8 lines
Quoted 2 lines

nftl-user.h is in CVS, along with a version of the userspace tools which uses it.

Ok, I'll check it out from CVS and post a patch to the uClinux-dev mailing-list adding this header in user/mtd-utils.

Is it 100% binary-compatible with all kernels?

Yes, I believe so.

Signature · 1 line
dwmw2