drivers/char/epca.c MIN/MAX removal
Subsystems (2)
PATCH 1/1 drivers/char/epca.c MIN/MAX removal
Patch (against 2.6.7) removes unnecessary min/max macros and changes calls to use kernel.h macros instead.
Feedback is always welcome
Michael
drivers/char/epca.c +3 -4
@@ -74,7 +74,6 @@#define DIGIINFOMAJOR 35/* For Digi specific ioctl */ -#define MIN (a,b) ((a) < (b) ? (a) : (b))#define MAXCARDS 7#define epcaassert (x, msg) if (!(x)) epca_error(__LINE__, msg)
@@ -826,7 +825,7 @@bytesAvailable will then take on this newly calculated value. ---------------------------------------------------------------------- */ - bytesAvailable =MIN (dataLen, bytesAvailable); + bytesAvailable =min (dataLen, bytesAvailable);/* First we read the data in from the file system into a temp buffer */
@@ -921,7 +920,7 @@space; reduce the amount of data to fit the space. ---------------------------------------------------------------------- */ - bytesAvailable =MIN (remain, bytesAvailable); + bytesAvailable =min (remain, bytesAvailable);txwinon (ch);while (bytesAvailable >0 )
@@ -932,7 +931,7 @@data copy fills to the end of card buffer. ------------------------------------------------------------------- */ - dataLen =MIN (bytesAvailable, dataLen); + dataLen =min (bytesAvailable, dataLen);memcpy (ch->txptr + head, buf, dataLen); buf += dataLen; head += dataLen;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 1/1 drivers/char/esp.c MIN/MAX removal
Patch (against 2.6.7) removes unnecessary min/max macros and changes calls to use kernel.h macros instead.
Feedback is always welcome
Michael
drivers/char/esp.c +2 -6
@@ -19,7 +19,7 @@* * rs_set_termios fixed to look also for changes of the input * flags INPCK, BRKINT, PARMRK, IGNPAR and IGNBRK. -* Bernd Anh���upl 05/17/96. +* Bernd Anh���������pl 05/17/96. * * --- End of notices from serial.c --- *
@@ -140,7 +140,7 @@static void change_speed (struct esp_struct *info);static void rs_wait_until_sent (struct tty_struct *,int ); - +/* * The ESP card has a clock rate of 14.7456 MHz (that is, 2**ESPC_SCALE * times the normal 1.8432 Mhz clock of most serial boards).
@@ -150,10 +150,6 @@/* Standard COM flags (except for COM4, because of the 8514 problem) */ #define STD_COM_FLAGS (ASYNC_BOOT_AUTOCONF | ASYNC_SKIP_TEST) -#ifndef MIN -#define MIN (a,b) ((a) < (b) ? (a) : (b)) -#endif -/* * tmp_buf is used as a temporary buffer by serial_write. We need to * lock it in case the memcpy_fromfs blocks while swapping in a page,
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Re: [Kernel-janitors] [PATCH] drivers/char/esp.c MIN/MAX removal
In reply to Michael VeeckQuoted 16 lines · Michael Veeck
Patch (against 2.6.7) removes unnecessary min/max macros and changes calls to use
kernel.hmacros instead.Feedback is always welcome
Michael
drivers/char/esp.c line 25
Quoted 8 lines
drivers/char/esp.c +1
-1@@ -19,7 +19,7 @@* * rs_set_termios fixed to look also for changes of the input * flags INPCK, BRKINT, PARMRK, IGNPAR and IGNBRK. -* Bernd Anh?upl 05/17/96. +* Bernd Anh???pl 05/17/96. * * --- End of notices from serial.c --- *
utf8?
drivers/char/esp.c line 146
Quoted 9 lines
drivers/char/esp.c +1
-1@@ -140,7 +140,7 @@static void change_speed (struct esp_struct *info);static void rs_wait_until_sent (struct tty_struct *,int ); - +/* * The ESP card has a clock rate of 14.7456 MHz (that is, 2**ESPC_SCALE * times the normal 1.8432 Mhz clock of most serial boards).
space fix
drivers/char/esp.c line 155
Quoted 11 lines
drivers/char/esp.c +0
-4@@ -150,10 +150,6 @@/* Standard COM flags (except for COM4, because of the 8514 problem) */ #define STD_COM_FLAGS (ASYNC_BOOT_AUTOCONF | ASYNC_SKIP_TEST) -#ifndef MIN -#define MIN (a,b) ((a) < (b) ? (a) : (b)) -#endif -/* * tmp_buf is used as a temporary buffer by serial_write. We need to * lock it in case the memcpy_fromfs blocks while swapping in a page,
real min max stuff!
please do not random "fixes" in parallell,
if a file really needs white space fixes use automatic tool for that. thanks maks
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors