drivers/macintosh/macserial.c MIN/MAX
Subsystems (2)
PATCH 1/1 drivers/macintosh/macserial.c MIN/MAX
Patch (against 2.6.7) removes unnecessary min/max macros and changes calls to use kernel.h macros instead.
Feedback is always welcome
Michael
drivers/macintosh/macserial.c +7 -13
@@ -158,10 +158,6 @@static void rxdma_start (struct mac_serial * info,int current);static void rxdma_to_tty (struct mac_serial * info); -#ifndef MIN -#define MIN (a,b) ((a) < (b) ? (a) : (b)) -#endif -/* * tmp_buf is used as a temporary buffer by serial_write. We need to * lock it in case the copy_from_user blocks while swapping in a page,
@@ -1485,9 +1481,8 @@if (from_user) {down (&tmp_buf_sem);while (1 ) { - c =MIN (count, -MIN (SERIAL_XMIT_SIZE - info->xmit_cnt -1 , -SERIAL_XMIT_SIZE - info->xmit_head)); + c =min_t (int, count,min (SERIAL_XMIT_SIZE - info->xmit_cnt -1 , +SERIAL_XMIT_SIZE - info->xmit_head));if (c <=0 )break ;
@@ -1498,8 +1493,8 @@break ; }spin_lock_irqsave (&info->lock, flags); - c =MIN (c,MIN (SERIAL_XMIT_SIZE - info->xmit_cnt -1 , -SERIAL_XMIT_SIZE - info->xmit_head)); + c =min_t (int, c,min (SERIAL_XMIT_SIZE - info->xmit_cnt -1 , +SERIAL_XMIT_SIZE - info->xmit_head));memcpy (info->xmit_buf + info->xmit_head, tmp_buf, c); info->xmit_head = ((info->xmit_head + c) & (SERIAL_XMIT_SIZE -1 ));
@@ -1513,9 +1508,8 @@ }else {while (1 ) {spin_lock_irqsave (&info->lock, flags); - c =MIN (count, -MIN (SERIAL_XMIT_SIZE - info->xmit_cnt -1 , -SERIAL_XMIT_SIZE - info->xmit_head)); + c =min_t (int, count,min (SERIAL_XMIT_SIZE - info->xmit_cnt -1 , +SERIAL_XMIT_SIZE - info->xmit_head));if (c <=0 ) {spin_unlock_irqrestore (&info->lock, flags);break ;
@@ -2052,7 +2046,7 @@ }else if (char_time ==0 ) char_time =1 ;if (timeout) - char_time =MIN (char_time, timeout); + char_time = min_t(unsigned long, char_time, timeout);while ((read_zsreg (info->zs_channel,1 ) &ALL_SNT ) ==0 ) { current->state =TASK_INTERRUPTIBLE ;schedule_timeout (char_time);
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors