ibm_ocp ethernet OPB clocks

In pretty much all versions of the kernel (I checked 2.4.x, 2.6.7), one finds in drivers/net/ibm_ocp/ibm_ocp_emac.h:

#define EMAC_M1_OPB_CLK_66              0x00000010      /* 66Mhz */
#define EMAC_M1_OPB_CLK_83              0x00000008      /* 83hz */

I believe these bitfield values are reversed... at least according to the 440GX usermanual, page 879. Bug/typo? Is the usermanual wrong? Or perhaps other 4xx series processors have different definitions?

The definitions for 100MHz and >100MHz appear to be correct though.

Is there a current maintainer for this driver?

-Ralph

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

I doublechecked that these didn't creep back in since I was sure I fixed them. In 2.6.7 there is no drivers/net/ibm_ocp/ibm_ocp_emac.h That driver has never been in kernel.org 2.6.7. I've just removed it in linuxppc-2.5, since it's been deprecated by the new EMAC driver. The corrected values are in there. Same goes for current 2.4. Try a current kernel.

That's me, now.

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Thanks for the feedback... You are right, I was looking at linuxppc-2.5 and not the mainline. The vanilla 2.6.7 tarball seems to have the right thing defined in drivers/net/ibm_emac, I presume this is the new driver... I'll give it a whirl, if I can get it to boot :)

-R

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/