Skip to contentSkip to conversation

no set_current_state() before

Kernel-janitors Brian King 3 participants 3 messages Jul 13, 2004 – Jul 16, 2004 Kernel janitors

lore
Share & tools
lore

Brian King

author
#0 lore raw

Since I'm not seeing a return value on msleep to be able to tell if it terminates prematurely, TASK_UNINTERRUPTIBLE is the preferred state.

Thanks

-Brian

Quoted 11 lines · Nishanth Aravamudan

Hi,

In continuing to replace, where appropriate, code with msleep() calls, I ran across the following file(s) / function(s), which do not invoke set_current_state() before schedule_timeout(), which causes the latter to return immediately:

drivers/scsi/ipr.c::ipr_store_diagnostics()

If someone could tell me which state (TASK_INTERRUPTIBLE or TASK_UNINTERRUPTIBLE) is desired, I can fix this and perhaps replace the calls with msleep().

Thanks,
Nish

Signature · 3 lines
Brian King
eServer Storage I/O
IBM Linux Technology Center

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

Hi Nish,
in both cases TASK_UNINTERRUPTIBLE is the correct state and both calls are indeed broken. Thanks for the hint, I'll fix this in our CVS right away.

blue skies,
Martin

Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH Schönaicherstr. 220, D-71032 Böblingen, Telefon: 49 - (0)7031 - 16-2247
E-Mail: [email protected]

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw
In reply to Brian King

Hi,
sorry for the delay in responding to this e-mail, I have been
out of the office for a couple of days.

In answer to your question TASK_UNINTERRUPTIBLE would be
appropriate for this call. Thank you for pointing it out. I assume that you will be making the change in the Kernel source tree.

Kind Regards

Kevin Curtis
Linux Development
FarSite Communications Ltd
http://www.farsite.co.uk

tel:  +44 1256 330461
fax:  +44 1256 854931

-----Original Message-----
From: Nishanth Aravamudan [mailto:[email protected]]
Sent: 13 July 2004 18:21
To: [email protected]
Cc: [email protected]
Subject: no set_current_state() before schedule_timeout()

Hi,

In continuing to replace, where appropriate, code with msleep() calls, I

ran across the following file(s) / function(s), which do not invoke set_current_state() before schedule_timeout(), which causes the latter to return immediately:

drivers/net/wan/farsync.c::fst_issue_cmd()

If someone could tell me which state (TASK_INTERRUPTIBLE or TASK_UNINTERRUPTIBLE) is desired, I can fix this and perhaps replace the

calls with msleep().

Thanks,
Nish

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors