Skip to contentSkip to conversation

clean up comments in arch/ia64/mm/init.c

PATCH Joshua Aas 2 participants 3 messages Jul 14, 2004 – Jul 15, 2004

lore
Share & tools
lore

Joshua Aas

author
#0 lore raw

While working on another patch in arch/ia64/mm/init.c, I found a comment that doesn't seem to make sense and one that just has a minor whitespace problem. The problem with the comment after setup_gate() is that boot memory seems to have already been freed a few lines earlier in the function and nothing else happens in mem_init() after the call to setup_gate() (unless compiling for IA32).

If there aren't any objections, it would be nice to have this patch applied so as not to confuse people in the future.

----------------------------------------

arch/ia64/mm/init.c 2004-07-14 16:50:59.000000000 -0500 renamed from arch/ia64/mm/init.c 2004-06-16 00:19:22.000000000 -0500 +2 -2
@@ -169,7 +169,7 @@ free_initrd_mem (unsigned long start, un
 {
        struct page *page;
        /*
-        * EFI uses 4KB pages while the kernel can use 4KB  or bigger.
+        * EFI uses 4KB pages while the kernel can use 4KB or bigger.
         * Thus EFI and the kernel may have different page sizes. It is
         * therefore possible to have the initrd share the same page as
         * the end of the kernel (given current setup).
@@ -580,7 +580,7 @@ mem_init (void)
                if (!fsyscall_table[i] || nolwsys)
                        fsyscall_table[i] = sys_call_table[i] | 1;
        }
-       setup_gate();   /* setup gate pages before we free up boot memory... */
+       setup_gate();
 
 #ifdef CONFIG_IA32_SUPPORT
        ia32_boot_gdt_init();

----------------------------------------

Signature · 4 lines
Josh Aas
Silicon Graphics, Inc. (SGI)
Linux System Software
651-683-3068
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Joshua Aas

Joshua> While working on another patch in arch/ia64/mm/init.c, I Joshua> found a comment that doesn't seem to make sense and one that Joshua> just has a minor whitespace problem. The problem with the Joshua> comment after setup_gate() is that boot memory seems to have Joshua> already been freed a few lines earlier in the function and Joshua> nothing else happens in mem_init() after the call to Joshua> setup_gate() (unless compiling for IA32). If there aren't Joshua> any objections, it would be nice to have this patch applied Joshua> so as not to confuse people in the future.

-EPATCHDOESNTAPPLY.

I think your mailer mangles whitespace. Try sending it as a MIME attachement.

	--david
author
#2 lore raw
In reply to Joshua Aas
Quoted 13 lines · David Mosberger
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Joshua Aas

Joshua> While working on another patch in arch/ia64/mm/init.c, I Joshua> found a comment that doesn't seem to make sense and one that Joshua> just has a minor whitespace problem. The problem with the Joshua> comment after setup_gate() is that boot memory seems to have Joshua> already been freed a few lines earlier in the function and Joshua> nothing else happens in mem_init() after the call to Joshua> setup_gate() (unless compiling for IA32). If there aren't Joshua> any objections, it would be nice to have this patch applied Joshua> so as not to confuse people in the future.

Quoted 6 lines

-EPATCHDOESNTAPPLY.

I think your mailer mangles whitespace. Try sending it as a MIME attachement.

	--david

Patch is attached.

Signature · 4 lines
Josh Aas
Silicon Graphics, Inc. (SGI)
Linux System Software
651-683-3068
arch/ia64/mm/init.c +2 -2
@@ -169,7 +169,7 @@ free_initrd_mem (unsigned long start, un
 {
 	struct page *page;
 	/*
-	 * EFI uses 4KB pages while the kernel can use 4KB  or bigger.
+	 * EFI uses 4KB pages while the kernel can use 4KB or bigger.
 	 * Thus EFI and the kernel may have different page sizes. It is
 	 * therefore possible to have the initrd share the same page as
 	 * the end of the kernel (given current setup).
@@ -580,7 +580,7 @@ mem_init (void)
 		if (!fsyscall_table[i] || nolwsys)
 			fsyscall_table[i] = sys_call_table[i] | 1;
 	}
-	setup_gate();	/* setup gate pages before we free up boot memory... */
+	setup_gate();
 
 #ifdef CONFIG_IA32_SUPPORT
 	ia32_boot_gdt_init();