Skip to contentSkip to conversation

What is the BUG() call in ll_rw_blk.c (2.4.26) for?

DISCUSSION Tom Dickson 2 participants 2 messages Jul 21, 2004

lore
Share & tools
lore
#0 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

void submit_bh(int rw, struct buffer_head * bh)
{
~ int count = bh->b_size >> 9;

~ if (!test_bit(BH_Lock, &bh->b_state))
~ BUG();

Does anyone know what that BUG(); is testing? We're seeing it and want to track down what we're doing that is causing it.

It's at line 1289 of drivers/block/ll_rw_blk.c

Thanks!

- -Tom

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFA/re42dxAfYNwANIRAsM2AKCZK64SB8H3ypeOp6r9srECt8lSEgCfeyya amEarqisYBF6MocYu6m/Nbo=
=HZZk
-----END PGP SIGNATURE-----

#1 lore raw
Quoted 10 lines · Tom Dickson

void submit_bh(int rw, struct buffer_head * bh)
{
~ int count = bh->b_size >> 9;

~ if (!test_bit(BH_Lock, &bh->b_state))
~ BUG();

Does anyone know what that BUG(); is testing? We're seeing it and want to track down what we're doing that is causing it.

You must lock the buffer_head before calling submit_bh. If the buffer_head is not locked, you see the BUG.

Shaggy

Signature · 2 lines
David Kleikamp
IBM Linux Technology Center