Skip to contentSkip to conversation

x86/S3: don't lose previously collected CPU data (AMD extra)

PATCH In review Jan Beulich 2 participants 2 messages Jul 17, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/S3: don't lose previously collected CPU data (AMD extra)

smp_store_cpu_info() doesn't call identify_cpu() again during S3 resume, hence it is wrong to zap APs' data while bringing them down (and we're not just parking them there) during suspend.

Fixes 7126b7f806d5 ("x86/CPU: re-work populating of cpu_data[]")
xen/arch/x86/smpboot.c +2 -1
@@ -982,7 +982,8 @@ static void cpu_smpboot_free(unsigned in
 
     if ( remove )
     {
-        reset_cpuinfo(&c[cpu], false);
+        if ( system_state != SYS_STATE_suspend )
+            reset_cpuinfo(&c[cpu], false);
 
         FREE_CPUMASK_VAR(per_cpu(cpu_sibling_mask, cpu));
         FREE_CPUMASK_VAR(per_cpu(cpu_core_mask, cpu));
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Jan Beulich

smp_store_cpu_info() doesn't call identify_cpu() again during S3 resume, hence it is wrong to zap APs' data while bringing them down (and we're not just parking them there) during suspend.

Fixes 7126b7f806d5 ("x86/CPU: re-work populating of cpu_data[]")

Juergen