Skip to contentSkip to conversation

rw stat clarification

DISCUSSION Stephan Mueller 3 participants 3 messages Oct 1 – Oct 14

lore
Share & tools
lore
#0 lore raw

Hi there

/sys/fs/xfs/$FS/stats/stats has a counter "rw" showing read and write call counters. The output is actually

rw #writes #reads // eg first writes, than reads

This is quite confusing (at least for me), when the metric is called "rw" suggesting first reads, then writes. Also the docs [1] call it "rw - Read/Write Stats" but then list the fields in the correct order

- xs_write_calls
- xs_read_calls

May I go ahead and make it

rw #reads #writes

or better not break people's scripts and just add a clarification to docs?

Have a nice day
stephan

[1] https://xfs.org/index.php/Runtime_Stats#rw_-_Read/Write_Stats

#1 lore raw

Hi Stephan,

Quoted 6 lines · Stephan Mueller

...
May I go ahead and make it

rw #reads #writes

Nope, this is an ABI. Userspace code has been written to this interface for >20 years.

cheers.

--
Nathan

#2 lore raw
Quoted 5 lines · Nathan Scott

Hi Stephan,

Quoted 1 line · Stephan Mueller
Quoted 8 lines
Quoted 5 lines

...
May I go ahead and make it

rw #reads #writes

Nope, this is an ABI. Userspace code has been written to this interface for >20 years.

Indeed. But it would be really useful if we could better document the interface and/or make it more discoverable.

I guess we should draft up a document for it, or maybe even have another sysfs file making it self-discoverable?

Also one think I've wondered about: Can we add new values to existing lines without breaking consumers? Where the biggest consumer really is PCP, so that's probably the most interesting answer.