Skip to contentSkip to conversation

Why has the timeout be removed?

PATCH Thomas Renninger 2 participants 2 messages Jul 1, 2014 – Jul 2, 2014

lore
Share & tools
lore
#0 lore raw

Hi,

commit 8ee18253644a812184c60e31d7ee3d3f6d8f45c0

Author: Harald Hoyer <[email protected]>
Date:   Tue Mar 4 13:46:14 2014 +0100

dracut: don't let devices timeout

https://bugzilla.redhat.com/show_bug.cgi?id=949697

See the whole diff at the end.
This one removes timeouts on the rootfs and if the rootfs cannot be accessed early boot will remain hung forever.

Unfortunately I cannot access the bug reference from the changelog and the changelog does not describe the problem.

I would like to revive the/a timeout, but need to understand why it got removed.

Thanks,

Thomas

=============================================

modules.d/98systemd/rootfs-generator.sh +1 -1
index a11ce59..2c09895 100755
@@ -29,7 +29,7 @@ generator_wait_for_dev()
         mkdir -p /run/systemd/generator/${_name}.device.d
         {
             echo "[Unit]"
-            echo "JobTimeoutSec=3600"
+            echo "JobTimeoutSec=0"
         } > /run/systemd/generator/${_name}.device.d/timeout.conf
     fi
 }
modules.d/99base/dracut-lib.sh +1 -1
index 763b7e2..e4d7da8 100755
@@ -891,7 +891,7 @@ wait_for_dev()
             mkdir -p ${PREFIX}/etc/systemd/system/${_name}.device.d
             {
                 echo "[Unit]"
-                echo "JobTimeoutSec=3600"
+                echo "JobTimeoutSec=0"
             } > ${PREFIX}/etc/systemd/system/${_name}.device.d/timeout.conf
             _needreload=1
         fi

=============================================

#1 lore raw
Quoted 57 lines · Thomas Renninger

Hi,

commit 8ee18253644a812184c60e31d7ee3d3f6d8f45c0

Author: Harald Hoyer <[email protected]>
Date:   Tue Mar 4 13:46:14 2014 +0100

dracut: don't let devices timeout

https://bugzilla.redhat.com/show_bug.cgi?id=949697

See the whole diff at the end.
This one removes timeouts on the rootfs and if the rootfs cannot be accessed early boot will remain hung forever.

Unfortunately I cannot access the bug reference from the changelog and the changelog does not describe the problem.

I would like to revive the/a timeout, but need to understand why it got removed.

Thanks,

Thomas

=============================================

modules.d/98systemd/rootfs-generator.sh +1 -1
index a11ce59..2c09895 100755
@@ -29,7 +29,7 @@ generator_wait_for_dev()
         mkdir -p /run/systemd/generator/${_name}.device.d
         {
             echo "[Unit]"
-            echo "JobTimeoutSec=3600"
+            echo "JobTimeoutSec=0"
         } > /run/systemd/generator/${_name}.device.d/timeout.conf
     fi
 }
modules.d/99base/dracut-lib.sh +1 -1
index 763b7e2..e4d7da8 100755
@@ -891,7 +891,7 @@ wait_for_dev()
             mkdir -p ${PREFIX}/etc/systemd/system/${_name}.device.d
             {
                 echo "[Unit]"
-                echo "JobTimeoutSec=3600"
+                echo "JobTimeoutSec=0"
             } > ${PREFIX}/etc/systemd/system/${_name}.device.d/timeout.conf
             _needreload=1
         fi
Quoted 2 lines

=============================================

The main reason was that for encrypted devices it would timeout, if you don't enter the password in time.

If you solve that, then you can reintroduce the timeout.