scsi_tcq.h questions

I have a question related to the utility functions found in scsi_tcq.h. The comment above scsi_activate_tcq indicates that the depth passed in should be the maximum depth the device can cope with and the real queue depth would be adjustable. This seems to contradict what is done in 53c700.c, as queue depth is a sysfs file which is defaulted to 4 and can be raised to 16. Since scsi_adjust_queue_depth never calls blk_queue_resize_tags, we end up with a larger queue depth in scsi than the block layer is aware of.

So, which is correct? Should scsi_adjust_queue_depth be changed to call blk_queue_resize_tags and the comment be removed from scsi_activate_tcq, or should the call to scsi_adjust_queue_depth in scsi_activate_tcq be removed and the queue depth passed in scsi_activate_tcq be a true max queue depth, in which case 53c700 should be changed to reflect this?

Brian King
eServer Storage I/O
IBM Linux Technology Center