Skip to contentSkip to conversation

why hold bkl during do_coredump?

DISCUSSION Josh Aas 2 participants 2 messages Aug 3, 2004 – Aug 5, 2004

lore
Share & tools
lore

Josh Aas

author
#0 lore raw

I'm looking at not holding the bkl during do_coredump, but I can't figure out why its being held in the first place. I can only think of the need to not mess with the current memory map, but mmap_sem is currently held as well. Anybody know what is going on here?

Signature · 4 lines
Josh Aas
Silicon Graphics, Inc. (SGI)
Linux System Software
651-683-3068
#1 lore raw
Quoted 5 lines · Josh Aas

I'm looking at not holding the bkl during do_coredump, but I can't
figure out why its being held in the first place. I can only think of the need to not mess with the current memory map, but mmap_sem is currently held as well. Anybody know what is going on here?

The only thing I can see in there which needs lock_kernel() is the access to core_pattern - it's changed by sysctl, which also takes lock_kernel().

Probably, adding a lock_kernel() and a comment around the call to format_corename() should suffice. Please make format_corename() static while you're there.