Skip to contentSkip to conversation

workqueue: jumps to use_dfl_pwq if the target cpumask is equal wq's

PATCH Applied Daeseok Youn 2 participants 3 messages Apr 16, 2014 Workqueue

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 workqueue: jumps to use_dfl_pwq if the target cpumask is equal wq's

Replace blocks of code which checks whether pwq is defalut with jump to use_dfl_pwq. It is same as before.

---
 kernel/workqueue.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
kernel/workqueue.c +1 -4
index 3150b21..0679854 100644
@@ -4087,10 +4087,7 @@ static void wq_update_unbound_numa(struct workqueue_struct *wq, int cpu,
 		if (cpumask_equal(cpumask, pwq->pool->attrs->cpumask))
 			goto out_unlock;
 	} else {
-		if (pwq == wq->dfl_pwq)
-			goto out_unlock;
-		else
-			goto use_dfl_pwq;
+		goto use_dfl_pwq;
 	}
 
 	mutex_unlock(&wq->mutex);
Signature · 1 line
1.7.4.4
maintainer
#1 lore raw

Hello,

Quoted 3 lines · Daeseok Youn

Replace blocks of code which checks whether pwq is defalut with jump to use_dfl_pwq. It is same as before.

A better wording would be sth like

wq_update_unbound_numa(), when it's decided that the newly updated cpumask equals the default, looks at whether the current pwq is already the default one and skips setting pwq to the default one. This extra step is unnecessary and we can always jump to use_dfl_pwq instead. Simplify the code by removing the conditional. This doesn't make any functional difference.

Quoted 10 lines
---
 kernel/workqueue.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
kernel/workqueue.c +0 -0
index 3150b21..0679854 100644

kernel/workqueue.c static void wq_update_unbound_numa(struct workqueue_struct *wq, int cpu, · line 4090

Quoted 8 lines
kernel/workqueue.c +1 -4
@@ -4087,10 +4087,7 @@ static void wq_update_unbound_numa(struct workqueue_struct *wq, int cpu,
 		if (cpumask_equal(cpumask, pwq->pool->attrs->cpumask))
 			goto out_unlock;
 	} else {
-		if (pwq == wq->dfl_pwq)
-			goto out_unlock;
-		else
-			goto use_dfl_pwq;
+		goto use_dfl_pwq;

As I said before, please update the comment above to match the new code.

Thanks.

Signature · 1 line
tejun
#2 lore raw

Hi,

Ok. I will update the comment in the code and patch description.

Thanks for review.

Regards,
Daeseok Youn.

2014-04-17 2:38 GMT+09:00 Tejun Heo <[email protected]>:

Quoted 42 lines

Hello,

Quoted 3 lines · Daeseok Youn

Replace blocks of code which checks whether pwq is defalut with jump to use_dfl_pwq. It is same as before.

A better wording would be sth like

wq_update_unbound_numa(), when it's decided that the newly updated cpumask equals the default, looks at whether the current pwq is already the default one and skips setting pwq to the default one. This extra step is unnecessary and we can always jump to use_dfl_pwq instead. Simplify the code by removing the conditional. This doesn't make any functional difference.

Quoted 10 lines
---
 kernel/workqueue.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
kernel/workqueue.c +0 -0
index 3150b21..0679854 100644

kernel/workqueue.c static void wq_update_unbound_numa(struct workqueue_struct *wq, int cpu, · line 4090

Quoted 8 lines
kernel/workqueue.c +1 -4
@@ -4087,10 +4087,7 @@ static void wq_update_unbound_numa(struct workqueue_struct *wq, int cpu,
              if (cpumask_equal(cpumask, pwq->pool->attrs->cpumask))
                      goto out_unlock;
      } else {
-             if (pwq == wq->dfl_pwq)
-                     goto out_unlock;
-             else
-                     goto use_dfl_pwq;
+             goto use_dfl_pwq;

As I said before, please update the comment above to match the new code.

Thanks.

--
tejun