Skip to contentSkip to conversation

ip_gre.c: update last_rx after netif_rx

Kernel-janitors Jay Bourque 2 participants 4 messages Aug 14, 2004 – Aug 23, 2004

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

Fix to update last_rx after netif_rx
This is my first patch so I'd appreciate any feedback.

-Jay

net/ipv4/ip_gre.c.new Sat Aug 14 12:17:16 2004 renamed from net/ipv4/ip_gre.c Sat Aug 14 05:55:48 2004 +1 -0
@@ -646,6 +646,7 @@ int ipgre_rcv(struct sk_buff *skb)
         nf_reset(skb);
         ipgre_ecn_decapsulate(iph, skb);
         netif_rx(skb);
+       tunnel->dev->last_rx = jiffies;
         read_unlock(&ipgre_lock);
         return(0);
     }

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw
Quoted 8 lines · Jay Bourque

Fix to update last_rx after netif_rx
This is my first patch so I'd appreciate any feedback.

(quoted diff) +0 -1
-Jay

net/ipv4/ip_gre.c.new Sat Aug 14 12:17:16 2004 int ipgre_rcv(struct sk_buff *skb) · line 652

Quoted 7 lines
net/ipv4/ip_gre.c.new Sat Aug 14 12:17:16 2004 renamed from net/ipv4/ip_gre.c Sat Aug 14 05:55:48 2004 +1 -0
@@ -646,6 +646,7 @@ int ipgre_rcv(struct sk_buff *skb)
        nf_reset(skb);
        ipgre_ecn_decapsulate(iph, skb);
        netif_rx(skb);
+       tunnel->dev->last_rx = jiffies;
        read_unlock(&ipgre_lock);
        return(0);
    }

well i hadn't researched that TODO item, when saying go for it, sorry, but grepping for 'last_rx' in 2.6.8 shows only 2 items. Arnaldo did lots of conversion at the beginning of the 2.4.x serie. i think this task should be removed from TODO as the way to go is to have correct rx pathes, but i'm not that good in networking code.
see: http://www.ussg.iu.edu/hypermail/linux/kernel/0302.2/1314.html

please confirm Arnaldo?

thanks

--
maks

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw
In reply to Jay Bourque
Quoted 8 lines · Jay Bourque

Fix to update last_rx after netif_rx
This is my first patch so I'd appreciate any feedback.

(quoted diff) +0 -1
-Jay

net/ipv4/ip_gre.c.new Sat Aug 14 12:17:16 2004 int ipgre_rcv(struct sk_buff *skb) · line 652

Quoted 7 lines
net/ipv4/ip_gre.c.new Sat Aug 14 12:17:16 2004 renamed from net/ipv4/ip_gre.c Sat Aug 14 05:55:48 2004 +1 -0
@@ -646,6 +646,7 @@ int ipgre_rcv(struct sk_buff *skb)
        nf_reset(skb);
        ipgre_ecn_decapsulate(iph, skb);
        netif_rx(skb);
+       tunnel->dev->last_rx = jiffies;
        read_unlock(&ipgre_lock);
        return(0);
    }

doesn't look complete, see patch below, but please read on:

the kj todo has an entry about "update last_rx after netif_rx", i wonder what that timestamping is good for, and newer sources 2.4.27 and 2.6.8 show 2 occurences of last_rx.

patches doing that are for young 2.4:
http://seclists.org/linux-kernel/2001/Feb/4846.html

i presume that this task is outdated,
thanks for putting light on that.

--
maks
kernel janitor http://janitor.kernelnewbies.org/

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#3 lore raw

hello jay,

Quoted 6 lines · maximilian attems
Quoted 4 lines · Jay Bourque

Fix to update last_rx after netif_rx
This is my first patch so I'd appreciate any feedback.

-Jay

..

Quoted 1 line

i presume that this task is outdated,

well nobody is really interested in aboves issue, thanks for bringing up that old dust, task removed from kernel janitor TODO.

please choose another item of the kj TODO list? happy to read you soon.

--
maks
kernel janitor http://janitor.kernelnewbies.org/

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors